* [PATCH] Allow HPET force enable on ICH10 HPET
@ 2008-12-16 1:35 Andi Kleen
2008-12-18 7:33 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2008-12-16 1:35 UTC (permalink / raw)
To: x86, linux-kernel
Allow HPET force enable on ICH10 HPET
Intel "Smackover" x58 BIOS don't have HPET enabled in the BIOS, so allow
to force enable it at least. The register layout is the same
as in other recent ICHs, so all the code can be reused.
Using numerical PCI-ID because it's unlikely the PCI-ID will be used
anywhere else.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
arch/x86/kernel/quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6.28-rc4-test/arch/x86/kernel/quirks.c
===================================================================
--- linux-2.6.28-rc4-test.orig/arch/x86/kernel/quirks.c 2008-10-24 13:34:40.000000000 +0200
+++ linux-2.6.28-rc4-test/arch/x86/kernel/quirks.c 2008-12-15 17:31:24.000000000 +0100
@@ -170,7 +170,8 @@
ich_force_enable_hpet);
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_7,
ich_force_enable_hpet);
-
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x3a16, /* ICH10 */
+ ich_force_enable_hpet);
static struct pci_dev *cached_dev;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Allow HPET force enable on ICH10 HPET
2008-12-16 1:35 [PATCH] Allow HPET force enable on ICH10 HPET Andi Kleen
@ 2008-12-18 7:33 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2008-12-18 7:33 UTC (permalink / raw)
To: Andi Kleen; +Cc: x86, linux-kernel
On Tue 2008-12-16 02:35:47, Andi Kleen wrote:
> Allow HPET force enable on ICH10 HPET
>
> Intel "Smackover" x58 BIOS don't have HPET enabled in the BIOS, so allow
> to force enable it at least. The register layout is the same
> as in other recent ICHs, so all the code can be reused.
>
> Using numerical PCI-ID because it's unlikely the PCI-ID will be used
> anywhere else.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Why not fix it properly... in the BIOS?
> @@ -170,7 +170,8 @@
> ich_force_enable_hpet);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_7,
> ich_force_enable_hpet);
> -
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x3a16, /* ICH10 */
> + ich_force_enable_hpet);
>
> static struct pci_dev *cached_dev;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-18 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-16 1:35 [PATCH] Allow HPET force enable on ICH10 HPET Andi Kleen
2008-12-18 7:33 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.