cs5435: break; in S_CTRL routine appears bogus

cs5435: break; in S_CTRL routine appears bogus

[Andy Walls]

Hans,

The break; statement you pointed out in the cs5435 driver does appear to
be bogus.  I haven't tested removing it yet.

Unfortunately there is no history in the hg log about this particular
line.  I can rationalize how it got there from a cx18-centric testing
point of view.  But obviously this module needs to work for other
drivers in the future.

Regards,
Andy


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Re: cs5435: break; in S_CTRL routine appears bogus

[Hans Verkuil]

On Friday 19 December 2008 12:39:40 Andy Walls wrote:
> Hans,
>
> The break; statement you pointed out in the cs5435 driver does appear to
> be bogus.  I haven't tested removing it yet.
>
> Unfortunately there is no history in the hg log about this particular
> line.  I can rationalize how it got there from a cx18-centric testing
> point of view.  But obviously this module needs to work for other
> drivers in the future.

I analyzed it and it's just a bogus line that can be removed. cx18 will 
never attempt to set these controls in the cs5345, so it is clearly some 
debug line that was never deleted.

I've converted cs5345 to v4l2_subdev and fixed this at the same time (it's 
how I found it). So I will add it to my v4l-dvb-subdev repo and ask for 
Mauro to pull from it.

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list