All of lore.kernel.org
 help / color / mirror / Atom feed
* linux-next: Tree for December 19
@ 2008-12-19 12:57 Stephen Rothwell
  2008-12-19 21:01 ` linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option) Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2008-12-19 12:57 UTC (permalink / raw)
  To: linux-next; +Cc: LKML

[-- Attachment #1: Type: text/plain, Size: 8379 bytes --]

Hi all,

Changes since 20081218:

Removed trees:
	perfmon3
	fscache

Undropped tree:
	rr

Dropped trees (temporarily):
	scsi (build problem)
	mtd (build problems)
	kvm (build problem)
	semaphore-removal (due to unfixed conflicts against Linus' tree)
	cpu_alloc (build problem)
	audit (difficult conflicts)

The rr_cpumask tree lost its conflicts (one was tansferred to the rr
tree).

----------------------------------------------------------------------------

I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
(patches at
http://www.kernel.org/pub/linux/kernel/people/sfr/linux-next/).  If you
are tracking the linux-next tree using git, you should not use "git pull"
to do so as that will try to merge the new linux-next release with the
old one.  You should use "git fetch" as mentioned in the FAQ on the wiki
(see below).

You can see which trees have been included by looking in the Next/Trees
file in the source.  There are also quilt-import.log and merge.log files
in the Next directory.  Between each merge, the tree was built with
a ppc64_defconfig for powerpc and an allmodconfig for x86_64. After the
final fixups (if any), it is also built with powerpc allnoconfig,
44x_defconfig and allyesconfig (minus CONFIG_PROFILE_ALL_BRANCHES) and
i386, sparc and sparc64 defconfig.

Below is a summary of the state of the merge.

We are up to 132 trees (counting Linus' and 15 trees of patches pending for
Linus' tree), more are welcome (even if they are currently empty).
Thanks to those who have contributed, and to those who haven't, please do.

Status of my local build tests will be at
http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give
advice about cross compilers/configs that work, we are always open to add
more builds.

Thanks to Jan Dittmer for adding the linux-next tree to his build tests
at http://l4x.org/k/ , the guys at http://test.kernel.org/ and Randy
Dunlap for doing many randconfig builds.

There is a wiki covering stuff to do with linux-next at
http://linux.f-seidel.de/linux-next/pmwiki/ .  Thanks to Frank Seidel.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

$ git checkout master
$ git reset --hard stable
Merging origin/master
Merging arm-current/master
Merging m68k-current/for-linus
Merging powerpc-merge/merge
Merging sparc-current/master
Merging scsi-rc-fixes/master
Merging net-current/master
Merging sound-current/for-linus
Merging pci-current/for-linus
Merging wireless-current/master
Merging kbuild-current/master
Merging quilt/driver-core.current
Merging quilt/usb.current
Merging cpufreq-current/fixes
Merging input-current/for-linus
Merging md-current/for-2.6.26
Merging audit-current/for-linus
Merging dwmw2/master
Merging arm/devel
Merging avr32/avr32-arch
Merging blackfin/for-linus
Merging cris/for-next
Merging ia64/test
Merging m68k/for-next
Merging m68knommu/for-next
Merging mips/mips-for-linux-next
Merging parisc/master
Merging powerpc/next
Merging 4xx/next
Merging galak/next
Merging pxa/for-next
Merging s390/features
CONFLICT (content): Merge conflict in drivers/char/Makefile
Merging sh/master
Merging sparc/master
Merging x86/auto-x86-next
Merging xtensa/master
Merging quilt/driver-core
CONFLICT (content): Merge conflict in arch/powerpc/platforms/85xx/mpc85xx_mds.c
Merging quilt/usb
Merging tip-core/auto-core-next
Merging cpus4096/auto-cpus4096-next
CONFLICT (content): Merge conflict in scripts/recordmcount.pl
Merging ftrace/auto-ftrace-next
Merging genirq/auto-genirq-next
Merging safe-poison-pointers/auto-safe-poison-pointers-next
Merging sched/auto-sched-next
Merging stackprotector/auto-stackprotector-next
Merging timers/auto-timers-next
Merging pci/linux-next
Merging quilt/device-mapper
CONFLICT (content): Merge conflict in drivers/md/dm.c
Merging hid/for-next
Merging quilt/i2c
Merging quilt/jdelvare-hwmon
Merging quilt/kernel-doc
Merging v4l-dvb/master
Merging jfs/next
Merging kbuild/master
Merging quilt/ide
Merging libata/NEXT
Merging nfs/linux-next
Merging xfs/master
CONFLICT (content): Merge conflict in fs/xfs/xfs_rename.c
Merging infiniband/for-next
Merging acpi/test
Merging nfsd/nfsd-next
Merging ieee1394/for-next
Merging ubi/linux-next
Merging dlm/next
Merging ocfs2/linux-next
Merging ext4/next
Merging async_tx/next
Merging udf/for_next
Merging net/master
CONFLICT (delete/modify): arch/sparc64/kernel/idprom.c deleted in HEAD and modified in net/master. Version net/master of arch/sparc64/kernel/idprom.c left in tree.
CONFLICT (content): Merge conflict in fs/lockd/host.c
CONFLICT (content): Merge conflict in fs/lockd/mon.c
$ git rm -f arch/sparc64/kernel/idprom.c
Applying: net: async_tx merge fix
Merging wireless/master
Merging crypto/master
Merging vfs/for-next
Merging sound/for-next
Merging cpufreq/next
Merging v9fs/for-next
Merging rr_cpumask/master
Merging quilt/rr
CONFLICT (content): Merge conflict in kernel/sched.c
Merging cifs/master
CONFLICT (content): Merge conflict in fs/cifs/connect.c
Applying: cifs: update for new IP4/6 address printing
Merging mmc/next
Merging gfs2/master
Merging input/next
Merging semaphore/semaphore
Merging bkl-removal/bkl-removal
CONFLICT (content): Merge conflict in fs/ioctl.c
Merging ubifs/linux-next
Merging lsm/for-next
Merging block/for-next
CONFLICT (content): Merge conflict in fs/bio.c
Merging embedded/master
Merging firmware/master
CONFLICT (content): Merge conflict in drivers/net/tg3.c
CONFLICT (content): Merge conflict in firmware/Makefile
CONFLICT (content): Merge conflict in firmware/WHENCE
Merging pcmcia/master
Merging battery/master
Merging leds/for-mm
Merging backlight/for-mm
Merging kgdb/kgdb-next
Merging slab/for-next
Merging uclinux/for-next
Merging md/for-next
Merging kmemcheck/auto-kmemcheck-next
CONFLICT (content): Merge conflict in MAINTAINERS
CONFLICT (content): Merge conflict in arch/x86/mm/Makefile
CONFLICT (content): Merge conflict in mm/slab.c
CONFLICT (content): Merge conflict in mm/slub.c
Merging generic-ipi/auto-generic-ipi-next
Merging mfd/for-next
Merging hdlc/hdlc-next
Merging drm/drm-next
Merging voltage/for-next
Merging security-testing/next
CONFLICT (content): Merge conflict in drivers/char/tty_audit.c
CONFLICT (content): Merge conflict in fs/cifs/cifs_fs_sb.h
CONFLICT (content): Merge conflict in fs/ocfs2/namei.c
CONFLICT (content): Merge conflict in fs/xfs/linux-2.6/xfs_cred.h
CONFLICT (content): Merge conflict in fs/xfs/linux-2.6/xfs_globals.h
CONFLICT (content): Merge conflict in fs/xfs/linux-2.6/xfs_ioctl.c
CONFLICT (content): Merge conflict in fs/xfs/xfs_vnodeops.h
Merging lblnet/master
CONFLICT (content): Merge conflict in Documentation/feature-removal-schedule.txt
Merging quilt/ttydev
CONFLICT (content): Merge conflict in fs/devpts/inode.c
Merging agp/agp-next
Merging oprofile/auto-oprofile-next
Merging fastboot/auto-fastboot-next
Merging sparseirq/auto-sparseirq-next
Merging iommu/auto-iommu-next
Merging uwb/for-upstream
Merging watchdog/master
Merging proc/proc
Merging bdev/master
Merging dwmw2-iommu/master
Merging cputime/cputime
CONFLICT (content): Merge conflict in kernel/sched.c
Merging osd/linux-next
Merging fatfs/master
Merging fuse/for-next
Merging jc_docs/docs-next
Merging nommu/master
CONFLICT (content): Merge conflict in Documentation/sysctl/vm.txt
CONFLICT (content): Merge conflict in kernel/fork.c
Merging boot-params/master
CONFLICT (content): Merge conflict in arch/arm/kernel/setup.c
CONFLICT (content): Merge conflict in arch/parisc/kernel/setup.c
CONFLICT (content): Merge conflict in arch/sh/boards/mach-microdev/setup.c
CONFLICT (content): Merge conflict in arch/sh/boards/mach-migor/setup.c
CONFLICT (content): Merge conflict in init/main.c
Merging trivial/for-next
Merging quilt/staging
CONFLICT (delete/modify): drivers/staging/winbond/linux/wbusb.c deleted in quilt/staging and modified in HEAD. Version HEAD of drivers/staging/winbond/linux/wbusb.c left in tree.
CONFLICT (content): Merge conflict in drivers/staging/wlan-ng/p80211netdev.c
CONFLICT (content): Merge conflict in drivers/staging/wlan-ng/p80211wext.c
$ git rm -f drivers/staging/winbond/linux/wbusb.c
Merging scsi-post-merge/master

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option)
  2008-12-19 12:57 linux-next: Tree for December 19 Stephen Rothwell
@ 2008-12-19 21:01 ` Bartlomiej Zolnierkiewicz
  2008-12-19 21:07   ` Yinghai Lu
  2008-12-19 21:40   ` linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option) Ingo Molnar
  0 siblings, 2 replies; 10+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-12-19 21:01 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, LKML, Yinghai Lu, Ingo Molnar

On Friday 19 December 2008, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20081218:
 
Just few very minor issues w.r.t. "x86, sparseirq: move irq_desc according
to smp_affinity, v7" (commit 48a1b10aff588833b73994704c47bbd0deb73e9c):

+config NUMA_MIGRATE_IRQ_DESC
+	bool "Move irq desc when changing irq smp_affinity"
+	depends on SPARSE_IRQ && SMP
+	default n
+	help
+	  This enables moving irq_desc to cpu/node that irq will use handled.
+
+	  If you don't know what to do here, say N.

This is a bit confusing (at least I was confused since I don't have NUMA
set in my config) -- either it should depend on NUMA or the config option
name should be changed.

@@ -2346,14 +2466,34 @@ static void irq_complete_move(struct irq_desc **descp)
 	struct irq_cfg *cfg = desc->chip_data;
 	unsigned vector, me;
 
-	if (likely(!cfg->move_in_progress))
+	if (likely(!cfg->move_in_progress)) {
+#ifdef CONFIG_NUMA_MIGRATE_IRQ_DESC
+		if (likely(!cfg->move_desc_pending))
+			return;
+
+		/* domain is not change, but affinity is changed */

this comment sounds weird

perhaps: /* only affinity is changed */ would be better?

+++ b/kernel/irq/numa_migrate.c
@@ -0,0 +1,127 @@
+/*
+ * linux/kernel/irq/handle.c
+ *
+ * Copyright (C) 1992, 1998-2006 Linus Torvalds, Ingo Molnar
+ * Copyright (C) 2005-2006, Thomas Gleixner, Russell King
+ *
+ * This file contains the core interrupt handling code.
+ *
+ * Detailed information is available in Documentation/DocBook/genericirq
+ *
+ */

hmmm? ;-)

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option)
  2008-12-19 21:01 ` linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option) Bartlomiej Zolnierkiewicz
@ 2008-12-19 21:07   ` Yinghai Lu
  2008-12-19 21:42     ` Ingo Molnar
  2008-12-19 21:40   ` linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option) Ingo Molnar
  1 sibling, 1 reply; 10+ messages in thread
From: Yinghai Lu @ 2008-12-19 21:07 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz; +Cc: Stephen Rothwell, linux-next, LKML, Ingo Molnar

Bartlomiej Zolnierkiewicz wrote:
> On Friday 19 December 2008, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20081218:
>  
> Just few very minor issues w.r.t. "x86, sparseirq: move irq_desc according
> to smp_affinity, v7" (commit 48a1b10aff588833b73994704c47bbd0deb73e9c):
> 
> +config NUMA_MIGRATE_IRQ_DESC
> +	bool "Move irq desc when changing irq smp_affinity"
> +	depends on SPARSE_IRQ && SMP
> +	default n
> +	help
> +	  This enables moving irq_desc to cpu/node that irq will use handled.
> +
> +	  If you don't know what to do here, say N.
> 
> This is a bit confusing (at least I was confused since I don't have NUMA
> set in my config) -- either it should depend on NUMA or the config option
> name should be changed.

should be changed to 
depends on SPARSE_IRQ && NUMA

> 
> @@ -2346,14 +2466,34 @@ static void irq_complete_move(struct irq_desc **descp)
>  	struct irq_cfg *cfg = desc->chip_data;
>  	unsigned vector, me;
>  
> -	if (likely(!cfg->move_in_progress))
> +	if (likely(!cfg->move_in_progress)) {
> +#ifdef CONFIG_NUMA_MIGRATE_IRQ_DESC
> +		if (likely(!cfg->move_desc_pending))
> +			return;
> +
> +		/* domain is not change, but affinity is changed */
> 
> this comment sounds weird

for logical flat mode, domain will be online_cpu_mask.
so need to move irq_desc when smp_affinity is changed.

> 
> perhaps: /* only affinity is changed */ would be better?
> 
> +++ b/kernel/irq/numa_migrate.c
> @@ -0,0 +1,127 @@
> +/*
> + * linux/kernel/irq/handle.c
> + *
> + * Copyright (C) 1992, 1998-2006 Linus Torvalds, Ingo Molnar
> + * Copyright (C) 2005-2006, Thomas Gleixner, Russell King
> + *
> + * This file contains the core interrupt handling code.
> + *
> + * Detailed information is available in Documentation/DocBook/genericirq
> + *
> + */
> 
> hmmm? ;-)

seperated from irq/handle.c

oh, will remove those lines.

YH

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option)
  2008-12-19 21:01 ` linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option) Bartlomiej Zolnierkiewicz
  2008-12-19 21:07   ` Yinghai Lu
@ 2008-12-19 21:40   ` Ingo Molnar
  1 sibling, 0 replies; 10+ messages in thread
From: Ingo Molnar @ 2008-12-19 21:40 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz; +Cc: Stephen Rothwell, linux-next, LKML, Yinghai Lu


* Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:

> On Friday 19 December 2008, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20081218:
>  
> Just few very minor issues w.r.t. "x86, sparseirq: move irq_desc according
> to smp_affinity, v7" (commit 48a1b10aff588833b73994704c47bbd0deb73e9c):
> 
> +config NUMA_MIGRATE_IRQ_DESC
> +	bool "Move irq desc when changing irq smp_affinity"
> +	depends on SPARSE_IRQ && SMP
> +	default n
> +	help
> +	  This enables moving irq_desc to cpu/node that irq will use handled.
> +
> +	  If you don't know what to do here, say N.
> 
> This is a bit confusing (at least I was confused since I don't have NUMA 
> set in my config) -- either it should depend on NUMA or the config 
> option name should be changed.

yeah, should be "depends on NUMA".

> @@ -2346,14 +2466,34 @@ static void irq_complete_move(struct irq_desc **descp)
>  	struct irq_cfg *cfg = desc->chip_data;
>  	unsigned vector, me;
>  
> -	if (likely(!cfg->move_in_progress))
> +	if (likely(!cfg->move_in_progress)) {
> +#ifdef CONFIG_NUMA_MIGRATE_IRQ_DESC
> +		if (likely(!cfg->move_desc_pending))
> +			return;
> +
> +		/* domain is not change, but affinity is changed */
> 
> this comment sounds weird
> 
> perhaps: /* only affinity is changed */ would be better?

perhaps:

	/* domain has not changed, but affinity did */

> +++ b/kernel/irq/numa_migrate.c
> @@ -0,0 +1,127 @@
> +/*
> + * linux/kernel/irq/handle.c
> + *
> + * Copyright (C) 1992, 1998-2006 Linus Torvalds, Ingo Molnar
> + * Copyright (C) 2005-2006, Thomas Gleixner, Russell King
> + *
> + * This file contains the core interrupt handling code.
> + *
> + * Detailed information is available in Documentation/DocBook/genericirq
> + *
> + */
> 
> hmmm? ;-)

indeed, needs fixing too :)

	Ingo

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option)
  2008-12-19 21:07   ` Yinghai Lu
@ 2008-12-19 21:42     ` Ingo Molnar
  2008-12-19 21:48       ` [PATCH] sparseirq: fix numa_migrate_irq_desc dependency and comments Yinghai Lu
  0 siblings, 1 reply; 10+ messages in thread
From: Ingo Molnar @ 2008-12-19 21:42 UTC (permalink / raw)
  To: Yinghai Lu; +Cc: Bartlomiej Zolnierkiewicz, Stephen Rothwell, linux-next, LKML


* Yinghai Lu <yinghai@kernel.org> wrote:

> > +++ b/kernel/irq/numa_migrate.c
> > @@ -0,0 +1,127 @@
> > +/*
> > + * linux/kernel/irq/handle.c
> > + *
> > + * Copyright (C) 1992, 1998-2006 Linus Torvalds, Ingo Molnar
> > + * Copyright (C) 2005-2006, Thomas Gleixner, Russell King
> > + *
> > + * This file contains the core interrupt handling code.
> > + *
> > + * Detailed information is available in Documentation/DocBook/genericirq
> > + *
> > + */
> > 
> > hmmm? ;-)
> 
> seperated from irq/handle.c
> 
> oh, will remove those lines.

Yeah, replace them with something like:

/*
 * NUMA irq-desc migration code
 *
 * Migrate IRQ data structures (irq_desc, chip_data, etc.) over to
 * the new "home node" of the IRQ.
 */

	Ingo

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] sparseirq: fix numa_migrate_irq_desc dependency and comments
  2008-12-19 21:42     ` Ingo Molnar
@ 2008-12-19 21:48       ` Yinghai Lu
  2008-12-19 21:57         ` Ingo Molnar
  0 siblings, 1 reply; 10+ messages in thread
From: Yinghai Lu @ 2008-12-19 21:48 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Bartlomiej Zolnierkiewicz, Stephen Rothwell, linux-next, LKML,
	Thomas Gleixner, H. Peter Anvin



Impact: clean up

Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> pointed out config and comments
are not right.

update it depend to NUMA, and fix some comments

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/Kconfig          |    2 +-
 arch/x86/kernel/io_apic.c |    2 +-
 kernel/irq/numa_migrate.c |   11 +++--------
 3 files changed, 5 insertions(+), 10 deletions(-)

Index: linux-2.6/arch/x86/Kconfig
===================================================================
--- linux-2.6.orig/arch/x86/Kconfig
+++ linux-2.6/arch/x86/Kconfig
@@ -259,7 +259,7 @@ config SPARSE_IRQ
 
 config NUMA_MIGRATE_IRQ_DESC
 	bool "Move irq desc when changing irq smp_affinity"
-	depends on SPARSE_IRQ && SMP
+	depends on SPARSE_IRQ && NUMA
 	default n
 	help
 	  This enables moving irq_desc to cpu/node that irq will use handled.
Index: linux-2.6/arch/x86/kernel/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/io_apic.c
+++ linux-2.6/arch/x86/kernel/io_apic.c
@@ -2519,7 +2519,7 @@ static void irq_complete_move(struct irq
 		if (likely(!cfg->move_desc_pending))
 			return;
 
-		/* domain is not change, but affinity is changed */
+		/* domain has not changed, but affinity did */
 		me = smp_processor_id();
 		if (cpu_isset(me, desc->affinity)) {
 			*descp = desc = move_irq_desc(desc, me);
Index: linux-2.6/kernel/irq/numa_migrate.c
===================================================================
--- linux-2.6.orig/kernel/irq/numa_migrate.c
+++ linux-2.6/kernel/irq/numa_migrate.c
@@ -1,13 +1,8 @@
 /*
- * linux/kernel/irq/handle.c
- *
- * Copyright (C) 1992, 1998-2006 Linus Torvalds, Ingo Molnar
- * Copyright (C) 2005-2006, Thomas Gleixner, Russell King
- *
- * This file contains the core interrupt handling code.
- *
- * Detailed information is available in Documentation/DocBook/genericirq
+ * NUMA irq-desc migration code
  *
+ * Migrate IRQ data structures (irq_desc, chip_data, etc.) over to
+ * the new "home node" of the IRQ.
  */
 
 #include <linux/irq.h>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] sparseirq: fix numa_migrate_irq_desc dependency and comments
  2008-12-19 21:48       ` [PATCH] sparseirq: fix numa_migrate_irq_desc dependency and comments Yinghai Lu
@ 2008-12-19 21:57         ` Ingo Molnar
  0 siblings, 0 replies; 10+ messages in thread
From: Ingo Molnar @ 2008-12-19 21:57 UTC (permalink / raw)
  To: Yinghai Lu
  Cc: Bartlomiej Zolnierkiewicz, Stephen Rothwell, linux-next, LKML,
	Thomas Gleixner, H. Peter Anvin


* Yinghai Lu <yinghai@kernel.org> wrote:

> Impact: clean up
> 
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> pointed out config and comments
> are not right.
> 
> update it depend to NUMA, and fix some comments
> 
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> 
> ---
>  arch/x86/Kconfig          |    2 +-
>  arch/x86/kernel/io_apic.c |    2 +-
>  kernel/irq/numa_migrate.c |   11 +++--------
>  3 files changed, 5 insertions(+), 10 deletions(-)

applied to tip/irq/sparseirq, thanks!

Note, the usual way to credit review/bug feedback is to add this line:

  Reported-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

and then you dont have to mention a full email in the changelog itself. 
See below how the final commit ended up looking like.

	Ingo

-------------->
>From b909895739427874c089bc0e03dc119f99cab2dd Mon Sep 17 00:00:00 2001
From: Yinghai Lu <yinghai@kernel.org>
Date: Fri, 19 Dec 2008 13:48:34 -0800
Subject: [PATCH] sparseirq: fix numa_migrate_irq_desc dependency and comments

Impact: reduce kconfig variable scope and clean up

Bartlomiej pointed out that the config dependencies and comments are not right.

update it depend to NUMA, and fix some comments

Reported-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/Kconfig          |    2 +-
 arch/x86/kernel/io_apic.c |    2 +-
 kernel/irq/numa_migrate.c |   11 +++--------
 3 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 60a0088..5c24382 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -250,7 +250,7 @@ config SPARSE_IRQ
 
 config NUMA_MIGRATE_IRQ_DESC
 	bool "Move irq desc when changing irq smp_affinity"
-	depends on SPARSE_IRQ && SMP
+	depends on SPARSE_IRQ && NUMA
 	default n
 	help
 	  This enables moving irq_desc to cpu/node that irq will use handled.
diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
index bfe1245..a74887b 100644
--- a/arch/x86/kernel/io_apic.c
+++ b/arch/x86/kernel/io_apic.c
@@ -2471,7 +2471,7 @@ static void irq_complete_move(struct irq_desc **descp)
 		if (likely(!cfg->move_desc_pending))
 			return;
 
-		/* domain is not change, but affinity is changed */
+		/* domain has not changed, but affinity did */
 		me = smp_processor_id();
 		if (cpu_isset(me, desc->affinity)) {
 			*descp = desc = move_irq_desc(desc, me);
diff --git a/kernel/irq/numa_migrate.c b/kernel/irq/numa_migrate.c
index 0178e22..089c374 100644
--- a/kernel/irq/numa_migrate.c
+++ b/kernel/irq/numa_migrate.c
@@ -1,13 +1,8 @@
 /*
- * linux/kernel/irq/handle.c
- *
- * Copyright (C) 1992, 1998-2006 Linus Torvalds, Ingo Molnar
- * Copyright (C) 2005-2006, Thomas Gleixner, Russell King
- *
- * This file contains the core interrupt handling code.
- *
- * Detailed information is available in Documentation/DocBook/genericirq
+ * NUMA irq-desc migration code
  *
+ * Migrate IRQ data structures (irq_desc, chip_data, etc.) over to
+ * the new "home node" of the IRQ.
  */
 
 #include <linux/irq.h>

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: linux-next: Tree for December 19
  2009-12-19  8:42 ` Geert Uytterhoeven
@ 2009-12-23  7:52   ` Stephen Rothwell
  0 siblings, 0 replies; 10+ messages in thread
From: Stephen Rothwell @ 2009-12-23  7:52 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: linux-next, LKML

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

Hi Geert,

On Sat, 19 Dec 2009 09:42:19 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> On Sat, Dec 19, 2009 at 01:04, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Well, I decided I had time for one more so it will be based in -rc1).
> 
> Hurray!

:-)

> But http://kisskb.ellerman.id.au/kisskb/buildresult/1852835/ shows
> linux-next/m68k-allmodconfig fails
> in security/keys/keyctl.c, while this got fixed in 2.6.33-rc1?? It
> compiled fine in linus/m68k-allmodconfig,
> as expected

That build was of next-20091218 ... the build of next-20091219
(http://kisskb.ellerman.id.au/kisskb/buildresult/1853405/) failed
differently :-(

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: linux-next: Tree for December 19
  2009-12-19  0:04 linux-next: Tree for December 19 Stephen Rothwell
@ 2009-12-19  8:42 ` Geert Uytterhoeven
  2009-12-23  7:52   ` Stephen Rothwell
  0 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2009-12-19  8:42 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, LKML

On Sat, Dec 19, 2009 at 01:04, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> I said:
>> News:  there will be no linux-next releases until at least Dec 24 and,
>> more likely, Dec 29.  Have a Merry Christmas and take a break.  :-)
>
> Well, I decided I had time for one more so it will be based in -rc1).

Hurray!

But http://kisskb.ellerman.id.au/kisskb/buildresult/1852835/ shows
linux-next/m68k-allmodconfig fails
in security/keys/keyctl.c, while this got fixed in 2.6.33-rc1?? It
compiled fine in linus/m68k-allmodconfig,
as expected

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 10+ messages in thread

* linux-next: Tree for December 19
@ 2009-12-19  0:04 Stephen Rothwell
  2009-12-19  8:42 ` Geert Uytterhoeven
  0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2009-12-19  0:04 UTC (permalink / raw)
  To: linux-next; +Cc: LKML

[-- Attachment #1: Type: text/plain, Size: 8043 bytes --]

Hi all,

I said:
> News:  there will be no linux-next releases until at least Dec 24 and,
> more likely, Dec 29.  Have a Merry Christmas and take a break.  :-)

Well, I decided I had time for one more so it will be based in -rc1).

This one has not had the build testing *between* merges, but has had all
the normal build testing at the end.  Since the latter testing showed no
problems, this just means that there may be more unbisectable points in
the tree (but that is unlikely).

Changes since 20091218:

The mips tree lost its conflicts.

The rr tree lost its conflicts and merge fixup.

The backlight tree lost its conflicts.

The drm tree lost its conflict.

The fsnotify tree lost its build failure and it conflicts.

The limits tree gained a conflict against Linus' tree.

The tip tree gained a conflict against the limits tree.

----------------------------------------------------------------------------

I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
(patches at http://www.kernel.org/pub/linux/kernel/v2.6/next/ ).  If you
are tracking the linux-next tree using git, you should not use "git pull"
to do so as that will try to merge the new linux-next release with the
old one.  You should use "git fetch" as mentioned in the FAQ on the wiki
(see below).

You can see which trees have been included by looking in the Next/Trees
file in the source.  There are also quilt-import.log and merge.log files
in the Next directory.  Between each merge, the tree was built with
a ppc64_defconfig for powerpc and an allmodconfig for x86_64. After the
final fixups (if any), it is also built with powerpc allnoconfig (32 and
64 bit), ppc44x_defconfig and allyesconfig (minus
CONFIG_PROFILE_ALL_BRANCHES - this fails its final link) and i386, sparc
and sparc64 defconfig. These builds also have
CONFIG_ENABLE_WARN_DEPRECATED, CONFIG_ENABLE_MUST_CHECK and
CONFIG_DEBUG_INFO disabled when necessary.

Below is a summary of the state of the merge.

We are up to 155 trees (counting Linus' and 22 trees of patches pending
for Linus' tree), more are welcome (even if they are currently empty).
Thanks to those who have contributed, and to those who haven't, please do.

Status of my local build tests will be at
http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give
advice about cross compilers/configs that work, we are always open to add
more builds.

Thanks to Jan Dittmer for adding the linux-next tree to his build tests
at http://l4x.org/k/ , the guys at http://test.kernel.org/ and Randy
Dunlap for doing many randconfig builds.

There is a wiki covering stuff to do with linux-next at
http://linux.f-seidel.de/linux-next/pmwiki/ .  Thanks to Frank Seidel.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

$ git checkout master
$ git reset --hard stable
Merging origin/master
Merging fixes/fixes
Merging arm-current/master
Merging m68k-current/for-linus
Merging powerpc-merge/merge
Merging sparc-current/master
Merging scsi-rc-fixes/master
Merging net-current/master
Merging sound-current/for-linus
Merging pci-current/for-linus
Merging wireless-current/master
Merging kbuild-current/for-linus
Merging quilt/driver-core.current
Merging quilt/tty.current
Merging quilt/usb.current
Merging quilt/staging.current
Merging cpufreq-current/fixes
Merging input-current/for-linus
Merging md-current/for-linus
Merging audit-current/for-linus
Merging crypto-current/master
Merging ide-curent/master
Merging dwmw2/master
Merging arm/devel
Merging davinci/davinci-next
Merging msm/for-next
Merging omap/for-next
Merging pxa/for-next
Merging samsung/next-samsung
Merging avr32/avr32-arch
Merging blackfin/for-linus
Merging cris/for-next
Merging ia64/test
Merging m68k/for-next
Merging m68knommu/for-next
Merging microblaze/next
Merging mips/mips-for-linux-next
Merging parisc/next
Merging powerpc/next
Merging 4xx/next
Merging 52xx-and-virtex/next
Merging galak/next
Merging s390/features
Merging sh/master
Merging sparc/master
Merging xtensa/master
Merging ceph/for-next
Merging cifs/master
Merging configfs/linux-next
Merging ecryptfs/next
Merging ext3/for_next
Merging ext4/next
Merging fatfs/master
Merging fuse/for-next
Merging gfs2/master
Merging jfs/next
Merging logfs/master
Merging nfs/linux-next
Merging nfsd/nfsd-next
Merging nilfs2/for-next
Merging ocfs2/linux-next
CONFLICT (content): Merge conflict in fs/ocfs2/file.c
Merging squashfs/master
Merging udf/for_next
Merging v9fs/for-next
CONFLICT (add/add): Merge conflict in fs/9p/cache.c
Merging ubifs/linux-next
Merging xfs/master
CONFLICT (add/add): Merge conflict in fs/xfs/linux-2.6/xfs_trace.h
CONFLICT (content): Merge conflict in include/linux/fs.h
Merging reiserfs-bkl/reiserfs/kill-bkl
Merging vfs/for-next
Merging pci/linux-next
Merging hid/for-next
Merging quilt/i2c
Merging bjdooks-i2c/next-i2c
Merging quilt/jdelvare-hwmon
Merging quilt/kernel-doc
Merging v4l-dvb/master
Merging kbuild/for-next
Merging kconfig/for-next
Merging ide/master
Merging libata/NEXT
Merging infiniband/for-next
Merging acpi/test
Merging ieee1394/for-next
CONFLICT (content): Merge conflict in drivers/media/dvb/firewire/firedtv-1394.c
CONFLICT (content): Merge conflict in drivers/media/dvb/firewire/firedtv-avc.c
CONFLICT (add/add): Merge conflict in drivers/media/dvb/firewire/firedtv-fw.c
CONFLICT (content): Merge conflict in drivers/media/dvb/firewire/firedtv.h
Merging ubi/linux-next
Merging kvm/linux-next
Merging dlm/next
Merging scsi/master
Merging async_tx/next
Merging net/master
Merging wireless/master
Merging mtd/master
Merging crypto/master
Merging sound/for-next
Merging cpufreq/next
Merging quilt/rr
Merging mmc/next
Merging tmio-mmc/linux-next
Merging input/next
Merging lsm/for-next
Merging block/for-next
Merging quilt/device-mapper
Merging embedded/master
Merging firmware/master
Merging pcmcia/master
Merging battery/master
Merging leds/for-mm
Merging backlight/for-mm
Merging kgdb/kgdb-next
Merging slab/for-next
Merging uclinux/for-next
Merging md/for-next
Merging mfd/for-next
Merging hdlc/hdlc-next
Merging drm/drm-next
Merging voltage/for-next
Merging security-testing/next
Merging lblnet/master
Merging agp/agp-next
Merging uwb/for-upstream
Merging watchdog/master
Merging bdev/master
Merging dwmw2-iommu/master
Merging cputime/cputime
Merging osd/linux-next
Merging jc_docs/docs-next
Merging nommu/master
Merging trivial/for-next
Merging audit/for-next
Merging quilt/aoe
Merging suspend/linux-next
Merging bluetooth/master
Merging fsnotify/for-next
Merging irda/for-next
CONFLICT (content): Merge conflict in drivers/net/irda/irda-usb.c
Merging hwlat/for-linus
CONFLICT (content): Merge conflict in MAINTAINERS
CONFLICT (content): Merge conflict in drivers/misc/Makefile
Merging drbd/for-jens
Merging catalin/for-next
Merging alacrity/linux-next
CONFLICT (content): Merge conflict in include/linux/Kbuild
CONFLICT (content): Merge conflict in lib/Kconfig
Merging i7core_edac/linux_next
Merging devicetree/next-devicetree
Merging spi/next-spi
Merging limits/writable_limits
CONFLICT (content): Merge conflict in arch/x86/ia32/ia32entry.S
CONFLICT (content): Merge conflict in arch/x86/include/asm/unistd_32.h
CONFLICT (content): Merge conflict in arch/x86/include/asm/unistd_64.h
CONFLICT (content): Merge conflict in arch/x86/kernel/syscall_table_32.S
CONFLICT (content): Merge conflict in fs/exec.c
Merging omap_dss2/for-next
Merging tip/auto-latest
CONFLICT (content): Merge conflict in include/linux/sched.h
Merging edac-amd/for-next
Merging oprofile/for-next
Merging percpu/for-next
Merging workqueues/for-next
Merging sfi/sfi-test
Merging asm-generic/next
Merging hwpoison/hwpoison
Merging sysctl/master
Merging quilt/driver-core
Merging quilt/tty
Merging quilt/usb
Merging quilt/staging
Merging scsi-post-merge/master

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2009-12-23  7:52 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-19 12:57 linux-next: Tree for December 19 Stephen Rothwell
2008-12-19 21:01 ` linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option) Bartlomiej Zolnierkiewicz
2008-12-19 21:07   ` Yinghai Lu
2008-12-19 21:42     ` Ingo Molnar
2008-12-19 21:48       ` [PATCH] sparseirq: fix numa_migrate_irq_desc dependency and comments Yinghai Lu
2008-12-19 21:57         ` Ingo Molnar
2008-12-19 21:40   ` linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option) Ingo Molnar
2009-12-19  0:04 linux-next: Tree for December 19 Stephen Rothwell
2009-12-19  8:42 ` Geert Uytterhoeven
2009-12-23  7:52   ` Stephen Rothwell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.