* [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE
@ 2008-11-08 17:52 Anton Vorontsov
2008-11-10 18:16 ` Scott Wood
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Anton Vorontsov @ 2008-11-08 17:52 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
Boards should know when QE_USB is used, so that they can configure USB
clocks and pins.
Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE,
but selects are evil since they don't support dependencies.
While at it, also remove 'host' from the symbol description, since the
QE_USB code is used to support the gadget driver as well.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
index 76ffbc4..41ac3df 100644
--- a/arch/powerpc/sysdev/qe_lib/Kconfig
+++ b/arch/powerpc/sysdev/qe_lib/Kconfig
@@ -22,5 +22,6 @@ config UCC
config QE_USB
bool
+ default y if USB_GADGET_FSL_QE
help
- QE USB Host Controller support
+ QE USB Controller support
--
1.5.6.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE
2008-11-08 17:52 [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE Anton Vorontsov
@ 2008-11-10 18:16 ` Scott Wood
2008-12-03 19:33 ` Anton Vorontsov
2008-12-30 18:12 ` Kumar Gala
2 siblings, 0 replies; 5+ messages in thread
From: Scott Wood @ 2008-11-10 18:16 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
On Sat, Nov 08, 2008 at 08:52:54PM +0300, Anton Vorontsov wrote:
> Boards should know when QE_USB is used, so that they can configure USB
> clocks and pins.
>
> Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE,
> but selects are evil since they don't support dependencies.
Can anyone explain *why* select ignores dependencies, rather than
recursively enabling the dependencies (and giving an error if it can't,
or if a dependency has an || in it and is unmet)?
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE
2008-11-08 17:52 [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE Anton Vorontsov
2008-11-10 18:16 ` Scott Wood
@ 2008-12-03 19:33 ` Anton Vorontsov
2008-12-23 17:22 ` Anton Vorontsov
2008-12-30 18:12 ` Kumar Gala
2 siblings, 1 reply; 5+ messages in thread
From: Anton Vorontsov @ 2008-12-03 19:33 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On Sat, Nov 08, 2008 at 08:52:54PM +0300, Anton Vorontsov wrote:
> Boards should know when QE_USB is used, so that they can configure USB
> clocks and pins.
>
> Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE,
> but selects are evil since they don't support dependencies.
>
> While at it, also remove 'host' from the symbol description, since the
> QE_USB code is used to support the gadget driver as well.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
Anything wrong with this one?
Thanks,
> arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
> index 76ffbc4..41ac3df 100644
> --- a/arch/powerpc/sysdev/qe_lib/Kconfig
> +++ b/arch/powerpc/sysdev/qe_lib/Kconfig
> @@ -22,5 +22,6 @@ config UCC
>
> config QE_USB
> bool
> + default y if USB_GADGET_FSL_QE
> help
> - QE USB Host Controller support
> + QE USB Controller support
> --
> 1.5.6.3
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE
2008-12-03 19:33 ` Anton Vorontsov
@ 2008-12-23 17:22 ` Anton Vorontsov
0 siblings, 0 replies; 5+ messages in thread
From: Anton Vorontsov @ 2008-12-23 17:22 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Timur Tabi
On Wed, Dec 03, 2008 at 10:33:27PM +0300, Anton Vorontsov wrote:
> On Sat, Nov 08, 2008 at 08:52:54PM +0300, Anton Vorontsov wrote:
> > Boards should know when QE_USB is used, so that they can configure USB
> > clocks and pins.
> >
> > Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE,
> > but selects are evil since they don't support dependencies.
> >
> > While at it, also remove 'host' from the symbol description, since the
> > QE_USB code is used to support the gadget driver as well.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> > ---
>
> Anything wrong with this one?
Without this patch QE UDC won't work (board file won't configure the
USB clocks and pins).
Thanks,
> > arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
> > index 76ffbc4..41ac3df 100644
> > --- a/arch/powerpc/sysdev/qe_lib/Kconfig
> > +++ b/arch/powerpc/sysdev/qe_lib/Kconfig
> > @@ -22,5 +22,6 @@ config UCC
> >
> > config QE_USB
> > bool
> > + default y if USB_GADGET_FSL_QE
> > help
> > - QE USB Host Controller support
> > + QE USB Controller support
> > --
> > 1.5.6.3
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE
2008-11-08 17:52 [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE Anton Vorontsov
2008-11-10 18:16 ` Scott Wood
2008-12-03 19:33 ` Anton Vorontsov
@ 2008-12-30 18:12 ` Kumar Gala
2 siblings, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2008-12-30 18:12 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linuxppc-dev
On Nov 8, 2008, at 11:52 AM, Anton Vorontsov wrote:
> Boards should know when QE_USB is used, so that they can configure USB
> clocks and pins.
>
> Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE,
> but selects are evil since they don't support dependencies.
>
> While at it, also remove 'host' from the symbol description, since the
> QE_USB code is used to support the gadget driver as well.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
applied to next
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-12-30 18:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-08 17:52 [PATCH] powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE Anton Vorontsov
2008-11-10 18:16 ` Scott Wood
2008-12-03 19:33 ` Anton Vorontsov
2008-12-23 17:22 ` Anton Vorontsov
2008-12-30 18:12 ` Kumar Gala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.