From: Sam Ravnborg <sam@ravnborg.org> To: David Miller <davem@davemloft.net> Cc: akpm@linux-foundation.org, sparclinux@vger.kernel.org, mingo@elte.hu, sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, kenchen@google.com, paulus@samba.org, tglx@linutronix.de, hpa@zytor.com, linux-next@vger.kernel.org Subject: Re: [PATCH] sparc64: use unsigned long long for u64 Date: Sat, 27 Dec 2008 10:24:04 +0100 [thread overview] Message-ID: <20081227092404.GA10375@uranus.ravnborg.org> (raw) In-Reply-To: <20081227.005452.261413194.davem@davemloft.net> On Sat, Dec 27, 2008 at 12:54:52AM -0800, David Miller wrote: > From: Sam Ravnborg <sam@ravnborg.org> > Date: Tue, 23 Dec 2008 14:17:46 +0100 > > > It may take a few days before the drivers gets fixed. > > Christmas is approaching fast by now. > > Even with this and your driver patch applied, the tree > doesn't build successfully: > > cc1: warnings being treated as errors > arch/sparc/kernel/psycho_common.c: In function ‘psycho_check_stc_error’: > arch/sparc/kernel/psycho_common.c:104: warning: format ‘%016lx’ expects type ‘long unsigned int’, but argument 4 has type ‘long long unsigned int’ > > Did you remove sparc's -Werror when doing test builds > of these changes? :-) No - it is worse than that. My gcc does not complain about the above. Just to check that I was not fouled by some preprocessor magic here is the preprocessed code: printk("<3>" "%s: STC_TAG(%d)[PA(%016lx)VA(%08lx)" "V(%d)W(%d)]\n", pbm->name, i, ((tagval & 0x0fffffff00000000UL) >> 19UL), (tagval & 0x00000000ffffe000UL), ((tagval & 0x0000000000000002UL) ? 1 : 0), ((tagval & 0x0000000000000001UL) ? 1 : 0)); tagval is u64. So it looks like my gcc does not promote: ((tagval & 0x0fffffff00000000UL) >> 19UL) to unsigned long long int but your gcc does? My gcc (build with Dan Kegel's crosstool): $ /opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu/bin/sparc64-unknown-linux-gnu-gcc -v Reading specs from /opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu/lib/gcc/sparc64-unknown-linux-gnu/3.4.5/specs Configured with: /home/sam/devel/crosstool-0.43/build/sparc64-unknown-linux-gnu/gcc-3.4.5-glibc-2.3.6/gcc-3.4.5/configure --target=sparc64-unknown-linux-gnu --host=i686-host_pc-linux-gnu --prefix=/opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu --disable-multilib --with-cpu=ultrasparc3 --enable-cxx-flags=-mcpu=ultrasparc3 --with-headers=/opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu/sparc64-unknown-linux-gnu/include --with-local-prefix=/opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu/sparc64-unknown-linux-gnu --disable-nls --enable-threads=posix --enable-symvers=gnu --enable-__cxa_atexit --enable-languages=c --enable-shared --enable-c99 --enable-long-long Thread model: posix gcc version 3.4.5 > > Either way these need some work before they should be > added to any tree. > > Andrew you probably want to toss these from your tree > since at a minimum they will break the sparc64 build. > > Sam will fix them up and resubmit, and I'll apply them, > don't worry. :) Yup - I added Andrew on cc: only as information. Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: David Miller <davem@davemloft.net> Cc: akpm@linux-foundation.org, sparclinux@vger.kernel.org, mingo@elte.hu, sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, kenchen@google.com, paulus@samba.org, tglx@linutronix.de, hpa@zytor.com, linux-next@vger.kernel.org Subject: Re: [PATCH] sparc64: use unsigned long long for u64 Date: Sat, 27 Dec 2008 09:24:04 +0000 [thread overview] Message-ID: <20081227092404.GA10375@uranus.ravnborg.org> (raw) In-Reply-To: <20081227.005452.261413194.davem@davemloft.net> On Sat, Dec 27, 2008 at 12:54:52AM -0800, David Miller wrote: > From: Sam Ravnborg <sam@ravnborg.org> > Date: Tue, 23 Dec 2008 14:17:46 +0100 > > > It may take a few days before the drivers gets fixed. > > Christmas is approaching fast by now. > > Even with this and your driver patch applied, the tree > doesn't build successfully: > > cc1: warnings being treated as errors > arch/sparc/kernel/psycho_common.c: In function ‘psycho_check_stc_error’: > arch/sparc/kernel/psycho_common.c:104: warning: format ‘%016lx’ expects type ‘long unsigned int’, but argument 4 has type ‘long long unsigned int’ > > Did you remove sparc's -Werror when doing test builds > of these changes? :-) No - it is worse than that. My gcc does not complain about the above. Just to check that I was not fouled by some preprocessor magic here is the preprocessed code: printk("<3>" "%s: STC_TAG(%d)[PA(%016lx)VA(%08lx)" "V(%d)W(%d)]\n", pbm->name, i, ((tagval & 0x0fffffff00000000UL) >> 19UL), (tagval & 0x00000000ffffe000UL), ((tagval & 0x0000000000000002UL) ? 1 : 0), ((tagval & 0x0000000000000001UL) ? 1 : 0)); tagval is u64. So it looks like my gcc does not promote: ((tagval & 0x0fffffff00000000UL) >> 19UL) to unsigned long long int but your gcc does? My gcc (build with Dan Kegel's crosstool): $ /opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu/bin/sparc64-unknown-linux-gnu-gcc -v Reading specs from /opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu/lib/gcc/sparc64-unknown-linux-gnu/3.4.5/specs Configured with: /home/sam/devel/crosstool-0.43/build/sparc64-unknown-linux-gnu/gcc-3.4.5-glibc-2.3.6/gcc-3.4.5/configure --target=sparc64-unknown-linux-gnu --host=i686-host_pc-linux-gnu --prefix=/opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu --disable-multilib --with-cpu=ultrasparc3 --enable-cxx-flags=-mcpu=ultrasparc3 --with-headers=/opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu/sparc64-unknown-linux-gnu/include --with-local-prefix=/opt/crosstool/gcc-3.4.5-glibc-2.3.6/sparc64-unknown-linux-gnu/sparc64-unknown-linux-gnu --disable-nls --enable-threads=posix --enable-symvers=gnu --enable-__cxa_atexit --enable-languages=c --enable-shared --enable-c99 --enable-long-long Thread model: posix gcc version 3.4.5 > > Either way these need some work before they should be > added to any tree. > > Andrew you probably want to toss these from your tree > since at a minimum they will break the sparc64 build. > > Sam will fix them up and resubmit, and I'll apply them, > don't worry. :) Yup - I added Andrew on cc: only as information. Sam
next prev parent reply other threads:[~2008-12-27 9:22 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-12-22 4:22 linux-next: sched tree build warning Stephen Rothwell 2008-12-22 6:47 ` Ingo Molnar 2008-12-22 6:49 ` Ken Chen 2008-12-22 7:04 ` Ingo Molnar 2008-12-22 7:19 ` Stephen Rothwell 2008-12-22 8:03 ` [patch] powerpc: change u64/s64 to a long long integer type Ingo Molnar 2008-12-22 22:43 ` Andrew Morton 2008-12-22 23:00 ` Sam Ravnborg 2008-12-22 23:03 ` H. Peter Anvin 2008-12-22 23:13 ` Sam Ravnborg 2008-12-22 23:13 ` Andrew Morton 2008-12-23 13:17 ` [PATCH] sparc64: use unsigned long long for u64 Sam Ravnborg 2008-12-23 13:17 ` Sam Ravnborg 2008-12-23 13:17 ` Sam Ravnborg 2008-12-23 14:42 ` [PATCH] sparc64: fix unsigned long long warnings in drivers Sam Ravnborg 2008-12-23 14:42 ` Sam Ravnborg 2008-12-23 17:05 ` [PATCH] sparc64: use unsigned long long for u64 Ken Chen 2008-12-23 17:05 ` Ken Chen 2008-12-23 17:26 ` Sam Ravnborg 2008-12-23 17:26 ` Sam Ravnborg 2008-12-23 17:29 ` Ken Chen 2008-12-23 17:29 ` Ken Chen 2008-12-23 17:34 ` Sam Ravnborg 2008-12-23 17:34 ` Sam Ravnborg 2008-12-27 8:54 ` David Miller 2008-12-27 8:54 ` David Miller 2008-12-27 8:54 ` David Miller 2008-12-27 9:24 ` Sam Ravnborg [this message] 2008-12-27 9:24 ` Sam Ravnborg 2008-12-27 9:37 ` David Miller 2008-12-27 9:37 ` David Miller 2008-12-27 9:49 ` Sam Ravnborg 2008-12-27 9:49 ` Sam Ravnborg 2008-12-28 4:25 ` David Miller 2008-12-28 4:25 ` David Miller 2008-12-28 12:32 ` Sam Ravnborg 2008-12-28 12:32 ` Sam Ravnborg 2008-12-31 4:40 ` [patch] powerpc: change u64/s64 to a long long integer type Stephen Rothwell 2008-12-31 7:52 ` Ingo Molnar 2008-12-22 8:14 ` linux-next: sched tree build warning Paul Mackerras 2008-12-22 8:18 ` Ingo Molnar 2008-12-22 9:44 ` Paul Mackerras 2008-12-22 10:53 ` Ingo Molnar 2008-12-22 12:03 ` Paul Mackerras
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20081227092404.GA10375@uranus.ravnborg.org \ --to=sam@ravnborg.org \ --cc=akpm@linux-foundation.org \ --cc=davem@davemloft.net \ --cc=hpa@zytor.com \ --cc=kenchen@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=paulus@samba.org \ --cc=sfr@canb.auug.org.au \ --cc=sparclinux@vger.kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.