* [PATCH] dm9601: warn on invalid mac address
@ 2009-01-06 9:10 Wu Fengguang
2009-01-06 9:18 ` Peter Korsgaard
0 siblings, 1 reply; 12+ messages in thread
From: Wu Fengguang @ 2009-01-06 9:10 UTC (permalink / raw)
To: netdev; +Cc: Peter Korsgaard
Add warnings on invalid mac address to help disclose/debug problems.
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
drivers/net/usb/dm9601.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
--- linux-2.6.orig/drivers/net/usb/dm9601.c
+++ linux-2.6/drivers/net/usb/dm9601.c
@@ -401,8 +401,12 @@ static int dm9601_set_mac_address(struct
struct sockaddr *addr = p;
struct usbnet *dev = netdev_priv(net);
- if (!is_valid_ether_addr(addr->sa_data))
+ if (!is_valid_ether_addr(addr->sa_data)) {
+ DECLARE_MAC_BUF(mac_buf);
+ print_mac(mac_buf, addr->sa_data);
+ dev_warn(&net->dev, "not setting invalid mac address %s\n", mac_buf);
return -EINVAL;
+ }
memcpy(net->dev_addr, addr->sa_data, net->addr_len);
dm_write_async(dev, DM_PHY_ADDR, net->addr_len, net->dev_addr);
@@ -449,6 +453,12 @@ static int dm9601_bind(struct usbnet *de
*/
if (is_valid_ether_addr(mac))
memcpy(dev->net->dev_addr, mac, ETH_ALEN);
+ else {
+ DECLARE_MAC_BUF(mac_buf);
+ print_mac(mac_buf, mac);
+ devdbg(dev, "EEPROM reported mac address %s is invalid,"
+ " use the randomly generated one.", mac_buf);
+ }
/* power up phy */
dm_write_reg(dev, DM_GPR_CTRL, 1);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-06 9:10 [PATCH] dm9601: warn on invalid mac address Wu Fengguang
@ 2009-01-06 9:18 ` Peter Korsgaard
2009-01-06 9:47 ` Wu Fengguang
2009-01-06 11:52 ` Ben Hutchings
0 siblings, 2 replies; 12+ messages in thread
From: Peter Korsgaard @ 2009-01-06 9:18 UTC (permalink / raw)
To: Wu Fengguang; +Cc: netdev
>>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
Hi,
Wu> Add warnings on invalid mac address to help disclose/debug problems.
Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Wu> ---
Wu> drivers/net/usb/dm9601.c | 12 +++++++++++-
Wu> 1 file changed, 11 insertions(+), 1 deletion(-)
Wu> --- linux-2.6.orig/drivers/net/usb/dm9601.c
Wu> +++ linux-2.6/drivers/net/usb/dm9601.c
Wu> @@ -401,8 +401,12 @@ static int dm9601_set_mac_address(struct
Wu> struct sockaddr *addr = p;
Wu> struct usbnet *dev = netdev_priv(net);
Wu> - if (!is_valid_ether_addr(addr->sa_data))
Wu> + if (!is_valid_ether_addr(addr->sa_data)) {
Wu> + DECLARE_MAC_BUF(mac_buf);
Wu> + print_mac(mac_buf, addr->sa_data);
Wu> + dev_warn(&net->dev, "not setting invalid mac address %s\n", mac_buf);
This should be an error and not a warning.
Notice that print_mac returns the string, so you can do:
dev_err(&net->dev, "... %s", print_mac(mac_buf, addr->sa_data));
Wu> memcpy(net->dev_addr, addr->sa_data, net->addr_len);
Wu> dm_write_async(dev, DM_PHY_ADDR, net->addr_len, net->dev_addr);
Wu> @@ -449,6 +453,12 @@ static int dm9601_bind(struct usbnet *de
Wu> */
Wu> if (is_valid_ether_addr(mac))
Wu> memcpy(dev->net->dev_addr, mac, ETH_ALEN);
Wu> + else {
Wu> + DECLARE_MAC_BUF(mac_buf);
Wu> + print_mac(mac_buf, mac);
Wu> + devdbg(dev, "EEPROM reported mac address %s is invalid,"
Wu> + " use the randomly generated one.", mac_buf);
And this should be a warning.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-06 9:18 ` Peter Korsgaard
@ 2009-01-06 9:47 ` Wu Fengguang
2009-01-06 11:17 ` Peter Korsgaard
2009-01-06 11:52 ` Ben Hutchings
1 sibling, 1 reply; 12+ messages in thread
From: Wu Fengguang @ 2009-01-06 9:47 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: netdev
On Tue, Jan 06, 2009 at 10:18:17AM +0100, Peter Korsgaard wrote:
> >>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
>
> Hi,
>
> Wu> Add warnings on invalid mac address to help disclose/debug problems.
> Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> Wu> ---
> Wu> drivers/net/usb/dm9601.c | 12 +++++++++++-
> Wu> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> Wu> --- linux-2.6.orig/drivers/net/usb/dm9601.c
> Wu> +++ linux-2.6/drivers/net/usb/dm9601.c
> Wu> @@ -401,8 +401,12 @@ static int dm9601_set_mac_address(struct
> Wu> struct sockaddr *addr = p;
> Wu> struct usbnet *dev = netdev_priv(net);
>
> Wu> - if (!is_valid_ether_addr(addr->sa_data))
> Wu> + if (!is_valid_ether_addr(addr->sa_data)) {
> Wu> + DECLARE_MAC_BUF(mac_buf);
> Wu> + print_mac(mac_buf, addr->sa_data);
> Wu> + dev_warn(&net->dev, "not setting invalid mac address %s\n", mac_buf);
>
> This should be an error and not a warning.
> Notice that print_mac returns the string, so you can do:
>
> dev_err(&net->dev, "... %s", print_mac(mac_buf, addr->sa_data));
OK.
> Wu> memcpy(net->dev_addr, addr->sa_data, net->addr_len);
> Wu> dm_write_async(dev, DM_PHY_ADDR, net->addr_len, net->dev_addr);
> Wu> @@ -449,6 +453,12 @@ static int dm9601_bind(struct usbnet *de
> Wu> */
> Wu> if (is_valid_ether_addr(mac))
> Wu> memcpy(dev->net->dev_addr, mac, ETH_ALEN);
> Wu> + else {
> Wu> + DECLARE_MAC_BUF(mac_buf);
> Wu> + print_mac(mac_buf, mac);
> Wu> + devdbg(dev, "EEPROM reported mac address %s is invalid,"
> Wu> + " use the randomly generated one.", mac_buf);
>
> And this should be a warning.
Then let the warning message appear repeatedly for some devices?
Also dev_warn() won't be able to show the device name at that time,
like this:
[28489.062180] : EEPROM reported mac address ff:ff:ff:ff:ff:ff is invalid, use the randomly generated one.
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-06 9:47 ` Wu Fengguang
@ 2009-01-06 11:17 ` Peter Korsgaard
2009-01-07 4:52 ` Wu Fengguang
0 siblings, 1 reply; 12+ messages in thread
From: Peter Korsgaard @ 2009-01-06 11:17 UTC (permalink / raw)
To: Wu Fengguang; +Cc: netdev
>>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
Hi,
Wu> if (is_valid_ether_addr(mac))
Wu> memcpy(dev->net->dev_addr, mac, ETH_ALEN);
Wu> + else {
Wu> + DECLARE_MAC_BUF(mac_buf);
Wu> + print_mac(mac_buf, mac);
Wu> + devdbg(dev, "EEPROM reported mac address %s is invalid,"
Wu> + " use the randomly generated one.", mac_buf);
>>
>> And this should be a warning.
Wu> Then let the warning message appear repeatedly for some devices?
This is called at probe time - But yes, I think it makes sense to print
it.
We should print the random address instead of the ff's though.
Wu> Also dev_warn() won't be able to show the device name at that time,
Wu> like this:
Ah yes, that's presumably why I used a raw printk just above.
Wu> [28489.062180] : EEPROM reported mac address ff:ff:ff:ff:ff:ff is
Wu> invalid, use the randomly generated one.
I would prefer something like:
printk(KERN_WARNING "dm9601: No valid MAC address in EEPROM, using %s\n",
print_mac(..));
Also, it seems like you're not writing the random address to the
hardware registers, so you won't be able to receive any unicast -
You'll need to add a call to dm9601_set_mac_address() or similar.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-06 9:18 ` Peter Korsgaard
2009-01-06 9:47 ` Wu Fengguang
@ 2009-01-06 11:52 ` Ben Hutchings
2009-01-06 18:52 ` David Miller
1 sibling, 1 reply; 12+ messages in thread
From: Ben Hutchings @ 2009-01-06 11:52 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Wu Fengguang, netdev
On Tue, 2009-01-06 at 10:18 +0100, Peter Korsgaard wrote:
> >>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
>
> Hi,
>
> Wu> Add warnings on invalid mac address to help disclose/debug problems.
> Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> Wu> ---
> Wu> drivers/net/usb/dm9601.c | 12 +++++++++++-
> Wu> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> Wu> --- linux-2.6.orig/drivers/net/usb/dm9601.c
> Wu> +++ linux-2.6/drivers/net/usb/dm9601.c
> Wu> @@ -401,8 +401,12 @@ static int dm9601_set_mac_address(struct
> Wu> struct sockaddr *addr = p;
> Wu> struct usbnet *dev = netdev_priv(net);
>
> Wu> - if (!is_valid_ether_addr(addr->sa_data))
> Wu> + if (!is_valid_ether_addr(addr->sa_data)) {
> Wu> + DECLARE_MAC_BUF(mac_buf);
> Wu> + print_mac(mac_buf, addr->sa_data);
> Wu> + dev_warn(&net->dev, "not setting invalid mac address %s\n", mac_buf);
>
> This should be an error and not a warning.
> Notice that print_mac returns the string, so you can do:
>
> dev_err(&net->dev, "... %s", print_mac(mac_buf, addr->sa_data));
print_mac() is already obsolete; use %pM in the format string instead.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-06 11:52 ` Ben Hutchings
@ 2009-01-06 18:52 ` David Miller
2009-01-07 4:55 ` Wu Fengguang
0 siblings, 1 reply; 12+ messages in thread
From: David Miller @ 2009-01-06 18:52 UTC (permalink / raw)
To: bhutchings; +Cc: jacmet, wfg, netdev
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 06 Jan 2009 11:52:35 +0000
> On Tue, 2009-01-06 at 10:18 +0100, Peter Korsgaard wrote:
> > >>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
> >
> > Hi,
> >
> > Wu> Add warnings on invalid mac address to help disclose/debug problems.
> > Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> > Wu> ---
> > Wu> drivers/net/usb/dm9601.c | 12 +++++++++++-
> > Wu> 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > Wu> --- linux-2.6.orig/drivers/net/usb/dm9601.c
> > Wu> +++ linux-2.6/drivers/net/usb/dm9601.c
> > Wu> @@ -401,8 +401,12 @@ static int dm9601_set_mac_address(struct
> > Wu> struct sockaddr *addr = p;
> > Wu> struct usbnet *dev = netdev_priv(net);
> >
> > Wu> - if (!is_valid_ether_addr(addr->sa_data))
> > Wu> + if (!is_valid_ether_addr(addr->sa_data)) {
> > Wu> + DECLARE_MAC_BUF(mac_buf);
> > Wu> + print_mac(mac_buf, addr->sa_data);
> > Wu> + dev_warn(&net->dev, "not setting invalid mac address %s\n", mac_buf);
> >
> > This should be an error and not a warning.
> > Notice that print_mac returns the string, so you can do:
> >
> > dev_err(&net->dev, "... %s", print_mac(mac_buf, addr->sa_data));
>
> print_mac() is already obsolete; use %pM in the format string instead.
Yep, please fix this.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-06 11:17 ` Peter Korsgaard
@ 2009-01-07 4:52 ` Wu Fengguang
2009-01-07 8:24 ` Peter Korsgaard
0 siblings, 1 reply; 12+ messages in thread
From: Wu Fengguang @ 2009-01-07 4:52 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: netdev
On Tue, Jan 06, 2009 at 12:17:56PM +0100, Peter Korsgaard wrote:
> >>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
>
> Hi,
>
> Wu> if (is_valid_ether_addr(mac))
> Wu> memcpy(dev->net->dev_addr, mac, ETH_ALEN);
> Wu> + else {
> Wu> + DECLARE_MAC_BUF(mac_buf);
> Wu> + print_mac(mac_buf, mac);
> Wu> + devdbg(dev, "EEPROM reported mac address %s is invalid,"
> Wu> + " use the randomly generated one.", mac_buf);
> >>
> >> And this should be a warning.
>
> Wu> Then let the warning message appear repeatedly for some devices?
>
> This is called at probe time - But yes, I think it makes sense to print
> it.
>
> We should print the random address instead of the ff's though.
>
> Wu> Also dev_warn() won't be able to show the device name at that time,
> Wu> like this:
>
> Ah yes, that's presumably why I used a raw printk just above.
>
> Wu> [28489.062180] : EEPROM reported mac address ff:ff:ff:ff:ff:ff is
> Wu> invalid, use the randomly generated one.
>
> I would prefer something like:
>
> printk(KERN_WARNING "dm9601: No valid MAC address in EEPROM, using %s\n",
> print_mac(..));
This looks better :-)
> Also, it seems like you're not writing the random address to the
> hardware registers, so you won't be able to receive any unicast -
> You'll need to add a call to dm9601_set_mac_address() or similar.
Good catch. I had wanted to ask why it only works with promisc mode ;-)
Here is the tested patch.
Thanks,
Fengguang
---
dm9601: tell HW about random generated mac address
Otherwise unicast RX will only work in promisc mode.
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
drivers/net/usb/dm9601.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
--- linux-2.6.orig/drivers/net/usb/dm9601.c
+++ linux-2.6/drivers/net/usb/dm9601.c
@@ -396,6 +396,11 @@ static void dm9601_set_multicast(struct
dm_write_reg_async(dev, DM_RX_CTRL, rx_ctl);
}
+static void __dm9601_set_mac_address(struct usbnet *dev)
+{
+ dm_write_async(dev, DM_PHY_ADDR, ETH_ALEN, dev->net->dev_addr);
+}
+
static int dm9601_set_mac_address(struct net_device *net, void *p)
{
struct sockaddr *addr = p;
@@ -405,7 +410,7 @@ static int dm9601_set_mac_address(struct
return -EINVAL;
memcpy(net->dev_addr, addr->sa_data, net->addr_len);
- dm_write_async(dev, DM_PHY_ADDR, net->addr_len, net->dev_addr);
+ __dm9601_set_mac_address(dev);
return 0;
}
@@ -449,6 +454,8 @@ static int dm9601_bind(struct usbnet *de
*/
if (is_valid_ether_addr(mac))
memcpy(dev->net->dev_addr, mac, ETH_ALEN);
+ else
+ __dm9601_set_mac_address(dev);
/* power up phy */
dm_write_reg(dev, DM_GPR_CTRL, 1);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-06 18:52 ` David Miller
@ 2009-01-07 4:55 ` Wu Fengguang
2009-01-07 8:25 ` Peter Korsgaard
0 siblings, 1 reply; 12+ messages in thread
From: Wu Fengguang @ 2009-01-07 4:55 UTC (permalink / raw)
To: David Miller; +Cc: bhutchings, jacmet, netdev
On Tue, Jan 06, 2009 at 10:52:26AM -0800, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Tue, 06 Jan 2009 11:52:35 +0000
>
> > On Tue, 2009-01-06 at 10:18 +0100, Peter Korsgaard wrote:
> > > >>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
> > >
> > > Hi,
> > >
> > > Wu> Add warnings on invalid mac address to help disclose/debug problems.
> > > Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> > > Wu> ---
> > > Wu> drivers/net/usb/dm9601.c | 12 +++++++++++-
> > > Wu> 1 file changed, 11 insertions(+), 1 deletion(-)
> > >
> > > Wu> --- linux-2.6.orig/drivers/net/usb/dm9601.c
> > > Wu> +++ linux-2.6/drivers/net/usb/dm9601.c
> > > Wu> @@ -401,8 +401,12 @@ static int dm9601_set_mac_address(struct
> > > Wu> struct sockaddr *addr = p;
> > > Wu> struct usbnet *dev = netdev_priv(net);
> > >
> > > Wu> - if (!is_valid_ether_addr(addr->sa_data))
> > > Wu> + if (!is_valid_ether_addr(addr->sa_data)) {
> > > Wu> + DECLARE_MAC_BUF(mac_buf);
> > > Wu> + print_mac(mac_buf, addr->sa_data);
> > > Wu> + dev_warn(&net->dev, "not setting invalid mac address %s\n", mac_buf);
> > >
> > > This should be an error and not a warning.
> > > Notice that print_mac returns the string, so you can do:
> > >
> > > dev_err(&net->dev, "... %s", print_mac(mac_buf, addr->sa_data));
> >
> > print_mac() is already obsolete; use %pM in the format string instead.
>
> Yep, please fix this.
Thanks for the tip. Here is the updated patch.
Thanks,
Fengguang
---
dm9601: warn on invalid mac address
Add warnings on invalid mac address to help disclose/debug problems.
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
drivers/net/usb/dm9601.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
--- linux-2.6.orig/drivers/net/usb/dm9601.c
+++ linux-2.6/drivers/net/usb/dm9601.c
@@ -406,8 +406,11 @@ static int dm9601_set_mac_address(struct
struct sockaddr *addr = p;
struct usbnet *dev = netdev_priv(net);
- if (!is_valid_ether_addr(addr->sa_data))
+ if (!is_valid_ether_addr(addr->sa_data)) {
+ dev_err(&net->dev, "not setting invalid mac address %pM\n",
+ addr->sa_data);
return -EINVAL;
+ }
memcpy(net->dev_addr, addr->sa_data, net->addr_len);
__dm9601_set_mac_address(dev);
@@ -454,8 +457,12 @@ static int dm9601_bind(struct usbnet *de
*/
if (is_valid_ether_addr(mac))
memcpy(dev->net->dev_addr, mac, ETH_ALEN);
- else
+ else {
+ printk(KERN_WARNING
+ "dm9601: No valid MAC address in EEPROM, using %pM\n",
+ dev->net->dev_addr);
__dm9601_set_mac_address(dev);
+ }
/* power up phy */
dm_write_reg(dev, DM_GPR_CTRL, 1);
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-07 4:52 ` Wu Fengguang
@ 2009-01-07 8:24 ` Peter Korsgaard
2009-01-08 18:45 ` David Miller
0 siblings, 1 reply; 12+ messages in thread
From: Peter Korsgaard @ 2009-01-07 8:24 UTC (permalink / raw)
To: Wu Fengguang; +Cc: netdev
>>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
Hi,
>> Also, it seems like you're not writing the random address to the
>> hardware registers, so you won't be able to receive any unicast -
>> You'll need to add a call to dm9601_set_mac_address() or similar.
Wu> Good catch. I had wanted to ask why it only works with promisc
Wu> mode ;-)
;)
Wu> Here is the tested patch.
Wu> Thanks,
Wu> Fengguang
Wu> ---
Wu> dm9601: tell HW about random generated mac address
Wu> Otherwise unicast RX will only work in promisc mode.
Wu> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-07 4:55 ` Wu Fengguang
@ 2009-01-07 8:25 ` Peter Korsgaard
2009-01-08 18:47 ` David Miller
0 siblings, 1 reply; 12+ messages in thread
From: Peter Korsgaard @ 2009-01-07 8:25 UTC (permalink / raw)
To: Wu Fengguang; +Cc: David Miller, bhutchings, netdev
>>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
Wu> Thanks for the tip. Here is the updated patch.
Wu> Thanks,
Wu> Fengguang
Wu> ---
Wu> dm9601: warn on invalid mac address
Wu> Add warnings on invalid mac address to help disclose/debug problems.
Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-07 8:24 ` Peter Korsgaard
@ 2009-01-08 18:45 ` David Miller
0 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2009-01-08 18:45 UTC (permalink / raw)
To: jacmet; +Cc: wfg, netdev
From: Peter Korsgaard <jacmet@sunsite.dk>
Date: Wed, 07 Jan 2009 09:24:43 +0100
> >>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
>
> Wu> dm9601: tell HW about random generated mac address
>
> Wu> Otherwise unicast RX will only work in promisc mode.
>
> Wu> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
>
> Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dm9601: warn on invalid mac address
2009-01-07 8:25 ` Peter Korsgaard
@ 2009-01-08 18:47 ` David Miller
0 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2009-01-08 18:47 UTC (permalink / raw)
To: jacmet; +Cc: wfg, bhutchings, netdev
From: Peter Korsgaard <jacmet@sunsite.dk>
Date: Wed, 07 Jan 2009 09:25:03 +0100
> >>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:
>
> Wu> Thanks for the tip. Here is the updated patch.
>
> Wu> Thanks,
> Wu> Fengguang
> Wu> ---
> Wu> dm9601: warn on invalid mac address
>
> Wu> Add warnings on invalid mac address to help disclose/debug problems.
>
> Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
>
> Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
Also applied, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2009-01-08 18:47 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-06 9:10 [PATCH] dm9601: warn on invalid mac address Wu Fengguang
2009-01-06 9:18 ` Peter Korsgaard
2009-01-06 9:47 ` Wu Fengguang
2009-01-06 11:17 ` Peter Korsgaard
2009-01-07 4:52 ` Wu Fengguang
2009-01-07 8:24 ` Peter Korsgaard
2009-01-08 18:45 ` David Miller
2009-01-06 11:52 ` Ben Hutchings
2009-01-06 18:52 ` David Miller
2009-01-07 4:55 ` Wu Fengguang
2009-01-07 8:25 ` Peter Korsgaard
2009-01-08 18:47 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.