* [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev
@ 2009-01-08 20:50 Inaky Perez-Gonzalez
2009-01-08 20:57 ` David Miller
2009-01-08 20:59 ` [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev [v2] Inaky Perez-Gonzalez
0 siblings, 2 replies; 9+ messages in thread
From: Inaky Perez-Gonzalez @ 2009-01-08 20:50 UTC (permalink / raw)
To: wimax, netdev; +Cc: Inaky Perez-Gonzalez, Randy Dunlapy
Reported by Randy Dunlap from a warning in the v2.6.29 merge window
tree as of 2009/1/8.
Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Cc: Randy Dunlapy <randy.dunlap@intel.com>
---
include/net/wimax.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/net/wimax.h b/include/net/wimax.h
index 1602614..073809c 100644
--- a/include/net/wimax.h
+++ b/include/net/wimax.h
@@ -323,6 +323,9 @@ struct input_dev;
*
* @rf_hw: [private] State of the hardware radio switch (OFF/ON)
*
+ * @debufs_dentry: [private] Used to hook up a debugfs entry. This
+ * shows up in the debugfs root as wimax:DEVICENAME.
+ *
* Description:
* This structure defines a common interface to access all WiMAX
* devices from different vendors and provides a common API as well as
--
1.5.6.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev
2009-01-08 20:50 [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev Inaky Perez-Gonzalez
@ 2009-01-08 20:57 ` David Miller
2009-01-08 21:02 ` Inaky Perez-Gonzalez
2009-01-08 20:59 ` [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev [v2] Inaky Perez-Gonzalez
1 sibling, 1 reply; 9+ messages in thread
From: David Miller @ 2009-01-08 20:57 UTC (permalink / raw)
To: inaky; +Cc: netdev, randy.dunlap, wimax
From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Date: Thu, 8 Jan 2009 12:50:27 -0800
> Reported by Randy Dunlap from a warning in the v2.6.29 merge window
> tree as of 2009/1/8.
>
> Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev [v2]
2009-01-08 20:50 [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev Inaky Perez-Gonzalez
2009-01-08 20:57 ` David Miller
@ 2009-01-08 20:59 ` Inaky Perez-Gonzalez
2009-01-09 5:36 ` Randy Dunlap
1 sibling, 1 reply; 9+ messages in thread
From: Inaky Perez-Gonzalez @ 2009-01-08 20:59 UTC (permalink / raw)
To: wimax, netdev; +Cc: Inaky Perez-Gonzalez, Randy Dunlap
Reported by Randy Dunlap from a warning in the v2.6.29 merge window
tree as of 2009/1/8.
v2 fixes Randy Dunlap's email address.
Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
---
include/net/wimax.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/net/wimax.h b/include/net/wimax.h
index 1602614..073809c 100644
--- a/include/net/wimax.h
+++ b/include/net/wimax.h
@@ -323,6 +323,9 @@ struct input_dev;
*
* @rf_hw: [private] State of the hardware radio switch (OFF/ON)
*
+ * @debufs_dentry: [private] Used to hook up a debugfs entry. This
+ * shows up in the debugfs root as wimax:DEVICENAME.
+ *
* Description:
* This structure defines a common interface to access all WiMAX
* devices from different vendors and provides a common API as well as
--
1.5.6.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev
2009-01-08 20:57 ` David Miller
@ 2009-01-08 21:02 ` Inaky Perez-Gonzalez
0 siblings, 0 replies; 9+ messages in thread
From: Inaky Perez-Gonzalez @ 2009-01-08 21:02 UTC (permalink / raw)
To: David Miller; +Cc: wimax, netdev, randy.dunlap
On Thursday 08 January 2009, David Miller wrote:
> From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
> Date: Thu, 8 Jan 2009 12:50:27 -0800
>
> > Reported by Randy Dunlap from a warning in the v2.6.29 merge window
> > tree as of 2009/1/8.
> >
> > Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
>
> Applied, thanks.
Just sent an update with Randy's email address corrected, but other than
that, it has zero changes (I had mistyped it to intel.com instead of
oracle.com).
Thanks,
--
Inaky
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev [v2]
2009-01-08 20:59 ` [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev [v2] Inaky Perez-Gonzalez
@ 2009-01-09 5:36 ` Randy Dunlap
2009-01-09 7:23 ` Inaky Perez-Gonzalez
2009-01-09 17:34 ` Inaky Perez-Gonzalez
0 siblings, 2 replies; 9+ messages in thread
From: Randy Dunlap @ 2009-01-09 5:36 UTC (permalink / raw)
To: Inaky Perez-Gonzalez; +Cc: wimax, netdev, Randy Dunlap
Inaky Perez-Gonzalez wrote:
> Reported by Randy Dunlap from a warning in the v2.6.29 merge window
> tree as of 2009/1/8.
>
> v2 fixes Randy Dunlap's email address.
>
> Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> include/net/wimax.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/wimax.h b/include/net/wimax.h
> index 1602614..073809c 100644
> --- a/include/net/wimax.h
> +++ b/include/net/wimax.h
> @@ -323,6 +323,9 @@ struct input_dev;
> *
> * @rf_hw: [private] State of the hardware radio switch (OFF/ON)
> *
> + * @debufs_dentry: [private] Used to hook up a debugfs entry. This
> + * shows up in the debugfs root as wimax:DEVICENAME.
Inaky, this was supposed to be @debugfs_dentry. (typo)
> + *
> * Description:
> * This structure defines a common interface to access all WiMAX
> * devices from different vendors and provides a common API as well as
--
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev [v2]
2009-01-09 5:36 ` Randy Dunlap
@ 2009-01-09 7:23 ` Inaky Perez-Gonzalez
2009-01-09 8:41 ` [PATCH] wimax: fix typo in kernel-doc for debugfs_dentry in struct wimax_dev Inaky Perez-Gonzalez
2009-01-09 17:34 ` Inaky Perez-Gonzalez
1 sibling, 1 reply; 9+ messages in thread
From: Inaky Perez-Gonzalez @ 2009-01-09 7:23 UTC (permalink / raw)
To: Randy Dunlap; +Cc: wimax, netdev
On Thursday 08 January 2009, Randy Dunlap wrote:
> Inaky Perez-Gonzalez wrote:
>...
> > diff --git a/include/net/wimax.h b/include/net/wimax.h
> > index 1602614..073809c 100644
> > --- a/include/net/wimax.h
> > +++ b/include/net/wimax.h
> > @@ -323,6 +323,9 @@ struct input_dev;
> > *
> > * @rf_hw: [private] State of the hardware radio switch (OFF/ON)
> > *
> > + * @debufs_dentry: [private] Used to hook up a debugfs entry. This
> > + * shows up in the debugfs root as wimax:DEVICENAME.
>
> Inaky, this was supposed to be @debugfs_dentry. (typo)
Geeze, some days I really really really should not get out of bed and
much less get anywhere near anything with keys, not even a calculator.
Fix available in
git://git.kernel.org/pub/scm/linux/kernel/git/inaky/wimax.git, patch coming.
--
Inaky
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] wimax: fix typo in kernel-doc for debugfs_dentry in struct wimax_dev
2009-01-09 7:23 ` Inaky Perez-Gonzalez
@ 2009-01-09 8:41 ` Inaky Perez-Gonzalez
0 siblings, 0 replies; 9+ messages in thread
From: Inaky Perez-Gonzalez @ 2009-01-09 8:41 UTC (permalink / raw)
To: wimax, netdev; +Cc: Randy Dunlap
The kernel-doc was referring to member @debufs_dentry instead of
@debugfs_dentry.
Reported by Randy Dunlap http://marc.info/?l=linux-netdev&m=123147942302885&w=2
As well, escape the colon in the field's text description, as it is
causing the generated text to be erraticly broken up (with paragraphs
moved down). Could not find a reason why it is happening so, even when
other field descriptions use colons and work as expected.
Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
---
include/net/wimax.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/wimax.h b/include/net/wimax.h
index 073809c..6b3824e 100644
--- a/include/net/wimax.h
+++ b/include/net/wimax.h
@@ -323,8 +323,8 @@ struct input_dev;
*
* @rf_hw: [private] State of the hardware radio switch (OFF/ON)
*
- * @debufs_dentry: [private] Used to hook up a debugfs entry. This
- * shows up in the debugfs root as wimax:DEVICENAME.
+ * @debugfs_dentry: [private] Used to hook up a debugfs entry. This
+ * shows up in the debugfs root as wimax\:DEVICENAME.
*
* Description:
* This structure defines a common interface to access all WiMAX
--
1.5.6.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] wimax: fix typo in kernel-doc for debugfs_dentry in struct wimax_dev
2009-01-09 5:36 ` Randy Dunlap
2009-01-09 7:23 ` Inaky Perez-Gonzalez
@ 2009-01-09 17:34 ` Inaky Perez-Gonzalez
2009-01-10 7:09 ` David Miller
1 sibling, 1 reply; 9+ messages in thread
From: Inaky Perez-Gonzalez @ 2009-01-09 17:34 UTC (permalink / raw)
To: wimax, netdev; +Cc: Randy Dunlap
The kernel-doc was referring to member @debufs_dentry instead of
@debugfs_dentry.
Reported by Randy Dunlap http://marc.info/?l=linux-netdev&m=123147942302885&w=2
As well, escape the colon in the field's text description, as it is
causing the generated text to be erraticly broken up (with paragraphs
moved down). Could not find a reason why it is happening so, even when
other field descriptions use colons and work as expected.
Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
---
include/net/wimax.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/wimax.h b/include/net/wimax.h
index 073809c..6b3824e 100644
--- a/include/net/wimax.h
+++ b/include/net/wimax.h
@@ -323,8 +323,8 @@ struct input_dev;
*
* @rf_hw: [private] State of the hardware radio switch (OFF/ON)
*
- * @debufs_dentry: [private] Used to hook up a debugfs entry. This
- * shows up in the debugfs root as wimax:DEVICENAME.
+ * @debugfs_dentry: [private] Used to hook up a debugfs entry. This
+ * shows up in the debugfs root as wimax\:DEVICENAME.
*
* Description:
* This structure defines a common interface to access all WiMAX
--
1.5.6.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] wimax: fix typo in kernel-doc for debugfs_dentry in struct wimax_dev
2009-01-09 17:34 ` Inaky Perez-Gonzalez
@ 2009-01-10 7:09 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2009-01-10 7:09 UTC (permalink / raw)
To: inaky; +Cc: wimax, netdev, randy.dunlap
From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Date: Fri, 9 Jan 2009 09:34:00 -0800
> The kernel-doc was referring to member @debufs_dentry instead of
> @debugfs_dentry.
>
> Reported by Randy Dunlap http://marc.info/?l=linux-netdev&m=123147942302885&w=2
>
> As well, escape the colon in the field's text description, as it is
> causing the generated text to be erraticly broken up (with paragraphs
> moved down). Could not find a reason why it is happening so, even when
> other field descriptions use colons and work as expected.
>
> Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Applied.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-01-10 7:09 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-08 20:50 [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev Inaky Perez-Gonzalez
2009-01-08 20:57 ` David Miller
2009-01-08 21:02 ` Inaky Perez-Gonzalez
2009-01-08 20:59 ` [PATCH] wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev [v2] Inaky Perez-Gonzalez
2009-01-09 5:36 ` Randy Dunlap
2009-01-09 7:23 ` Inaky Perez-Gonzalez
2009-01-09 8:41 ` [PATCH] wimax: fix typo in kernel-doc for debugfs_dentry in struct wimax_dev Inaky Perez-Gonzalez
2009-01-09 17:34 ` Inaky Perez-Gonzalez
2009-01-10 7:09 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.