* [patch 2/2] net/bridge/netfilter: move a dereference below a NULL test
@ 2009-01-09 20:22 akpm
2009-01-10 7:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2009-01-09 20:22 UTC (permalink / raw)
To: davem; +Cc: netdev, akpm, julia
From: Julia Lawall <julia@diku.dk>
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
net/bridge/netfilter/ebtables.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN net/bridge/netfilter/ebtables.c~net-bridge-netfilter-move-a-dereference-below-a-null-test net/bridge/netfilter/ebtables.c
--- a/net/bridge/netfilter/ebtables.c~net-bridge-netfilter-move-a-dereference-below-a-null-test
+++ a/net/bridge/netfilter/ebtables.c
@@ -85,12 +85,13 @@ static inline int ebt_do_match (struct e
static inline int ebt_dev_check(char *entry, const struct net_device *device)
{
int i = 0;
- const char *devname = device->name;
+ const char *devname;
if (*entry == '\0')
return 0;
if (!device)
return 1;
+ devname = device->name;
/* 1 is the wildcard token */
while (entry[i] != '\0' && entry[i] != 1 && entry[i] == devname[i])
i++;
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2/2] net/bridge/netfilter: move a dereference below a NULL test
2009-01-09 20:22 [patch 2/2] net/bridge/netfilter: move a dereference below a NULL test akpm
@ 2009-01-10 7:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-10 7:09 UTC (permalink / raw)
To: akpm; +Cc: netdev, julia
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-10 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-09 20:22 [patch 2/2] net/bridge/netfilter: move a dereference below a NULL test akpm
2009-01-10 7:09 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.