[Qemu-devel] [PATCH] Fix qemu-img argument handling

[Qemu-devel] [PATCH] Fix qemu-img argument handling

[Hervé Poussineau]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi,

qemu-img doesn't work on MS Windows, when compiled with MinGW Runtime 
package >= 3.15
According to 
http://sourceforge.net/tracker/index.php?func=detail&aid=2222263&group_id=2435&atid=102435 
, qemu-img shouldn't skip the first argument (command name) by doing 
optind++.

Attached patch fixes the problems, and repairs qemu-img parsing with 
MinGW Runtime package >= 3.15

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

Hervé

[-- Attachment #2: qemu-img-optind.diff --]
[-- Type: plain/text, Size: 379 bytes --]

Re: [Qemu-devel] [PATCH] Fix qemu-img argument handling

[Robert Riebisch]

Hervé Poussineau wrote:

> According to 
> http://sourceforge.net/tracker/index.php?func=detail&aid=2222263&group_id=2435&atid=102435 
> , qemu-img shouldn't skip the first argument (command name) by doing 
> optind++.

Oh, that was me in November. ;-)

> Attached patch fixes the problems, and repairs qemu-img parsing with 
> MinGW Runtime package >= 3.15

Thanks for this patch! :-)

Robert Riebisch
-- 
BTTR Software
http://www.bttr-software.de/

Re: [Qemu-devel] [PATCH] Fix qemu-img argument handling

[Aurelien Jarno]

On Sat, Feb 07, 2009 at 05:29:11PM +0100, Hervé Poussineau wrote:
> Hi,
>
> qemu-img doesn't work on MS Windows, when compiled with MinGW Runtime  
> package >= 3.15
> According to  
> http://sourceforge.net/tracker/index.php?func=detail&aid=2222263&group_id=2435&atid=102435 
> , qemu-img shouldn't skip the first argument (command name) by doing  
> optind++.
>
> Attached patch fixes the problems, and repairs qemu-img parsing with  
> MinGW Runtime package >= 3.15
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

Thanks, applied.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] [PATCH] Fix qemu-img argument handling

[Robert Riebisch]

Hervé Poussineau wrote:

> qemu-img doesn't work on MS Windows, when compiled with MinGW Runtime 
> package >= 3.15

Keith Marshall of MinGW submitted a patch to getopt() behaviour:
https://sourceforge.net/tracker/?func=detail&atid=352435&aid=2222263&group_id=2435

Robert Riebisch
-- 
BTTR Software
http://www.bttr-software.de/

Re: [Qemu-devel] [PATCH] Fix qemu-img argument handling

[Anthony Liguori]

Hervé Poussineau wrote:
> Hi,
>
> qemu-img doesn't work on MS Windows, when compiled with MinGW Runtime 
> package >= 3.15
> According to 
> http://sourceforge.net/tracker/index.php?func=detail&aid=2222263&group_id=2435&atid=102435 
> , qemu-img shouldn't skip the first argument (command name) by doing 
> optind++.
>
> Attached patch fixes the problems, and repairs qemu-img parsing with 
> MinGW Runtime package >= 3.15
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

This resend either inlining the patch or attaching it with text/plan.

Regards,

Anthony Liguori

> Hervé