* [PATCH] Fix compile error in usb-musb.c
@ 2009-01-15 18:48 Gadiyar, Anand
2009-01-16 7:29 ` Tony Lindgren
0 siblings, 1 reply; 17+ messages in thread
From: Gadiyar, Anand @ 2009-01-15 18:48 UTC (permalink / raw)
To: linux-omap; +Cc: Tony Lindgren, David Brownell
From: Anand Gadiyar <gadiyar@ti.com>
Fix this compile error
CC arch/arm/mach-omap2/usb-musb.o
arch/arm/mach-omap2/usb-musb.c:47: error: 'INT_243X_HS_USB_MC' undeclared here (not in a function)
arch/arm/mach-omap2/usb-musb.c:51: error: 'INT_243X_HS_USB_DMA' undeclared here (not in a function)
make[1]: *** [arch/arm/mach-omap2/usb-musb.o] Error 1
Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
Reported-by: David Brownell <david-b@pacbell.net>
---
diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
index 61c5709..5d79f89 100644
--- a/arch/arm/mach-omap2/usb-musb.c
+++ b/arch/arm/mach-omap2/usb-musb.c
@@ -28,6 +28,7 @@
#include <linux/usb/musb.h>
#include <mach/hardware.h>
+#include <mach/irqs.h>
#include <mach/pm.h>
#include <mach/mux.h>
#include <mach/usb.h>
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-15 18:48 [PATCH] Fix compile error in usb-musb.c Gadiyar, Anand
@ 2009-01-16 7:29 ` Tony Lindgren
2009-01-16 7:37 ` Tony Lindgren
0 siblings, 1 reply; 17+ messages in thread
From: Tony Lindgren @ 2009-01-16 7:29 UTC (permalink / raw)
To: Gadiyar, Anand; +Cc: linux-omap, David Brownell
* Gadiyar, Anand <gadiyar@ti.com> [090115 20:48]:
> From: Anand Gadiyar <gadiyar@ti.com>
>
> Fix this compile error
This one should go via the usb list too.
Acked-by: Tony Lindgren <tony@atomide.com>
> CC arch/arm/mach-omap2/usb-musb.o
> arch/arm/mach-omap2/usb-musb.c:47: error: 'INT_243X_HS_USB_MC' undeclared here (not in a function)
> arch/arm/mach-omap2/usb-musb.c:51: error: 'INT_243X_HS_USB_DMA' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/usb-musb.o] Error 1
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Reported-by: David Brownell <david-b@pacbell.net>
> ---
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index 61c5709..5d79f89 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -28,6 +28,7 @@
> #include <linux/usb/musb.h>
>
> #include <mach/hardware.h>
> +#include <mach/irqs.h>
> #include <mach/pm.h>
> #include <mach/mux.h>
> #include <mach/usb.h>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-16 7:29 ` Tony Lindgren
@ 2009-01-16 7:37 ` Tony Lindgren
2009-01-16 15:35 ` Felipe Balbi
0 siblings, 1 reply; 17+ messages in thread
From: Tony Lindgren @ 2009-01-16 7:37 UTC (permalink / raw)
To: Gadiyar, Anand; +Cc: linux-omap, David Brownell
* Tony Lindgren <tony@atomide.com> [090116 09:29]:
> * Gadiyar, Anand <gadiyar@ti.com> [090115 20:48]:
> > From: Anand Gadiyar <gadiyar@ti.com>
> >
> > Fix this compile error
>
> This one should go via the usb list too.
Uh, looks like my usb filter is set too sensitive :)
This is the platform code part, I'll apply this and queue it up
in omap-fixes.
Thanks,
Tony
> Acked-by: Tony Lindgren <tony@atomide.com>
>
>
> > CC arch/arm/mach-omap2/usb-musb.o
> > arch/arm/mach-omap2/usb-musb.c:47: error: 'INT_243X_HS_USB_MC' undeclared here (not in a function)
> > arch/arm/mach-omap2/usb-musb.c:51: error: 'INT_243X_HS_USB_DMA' undeclared here (not in a function)
> > make[1]: *** [arch/arm/mach-omap2/usb-musb.o] Error 1
> >
> > Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> > Reported-by: David Brownell <david-b@pacbell.net>
> > ---
> > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> > index 61c5709..5d79f89 100644
> > --- a/arch/arm/mach-omap2/usb-musb.c
> > +++ b/arch/arm/mach-omap2/usb-musb.c
> > @@ -28,6 +28,7 @@
> > #include <linux/usb/musb.h>
> >
> > #include <mach/hardware.h>
> > +#include <mach/irqs.h>
> > #include <mach/pm.h>
> > #include <mach/mux.h>
> > #include <mach/usb.h>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-16 7:37 ` Tony Lindgren
@ 2009-01-16 15:35 ` Felipe Balbi
2009-01-16 15:38 ` Gadiyar, Anand
2009-01-16 21:27 ` David Brownell
0 siblings, 2 replies; 17+ messages in thread
From: Felipe Balbi @ 2009-01-16 15:35 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Gadiyar, Anand, linux-omap, David Brownell
On Fri, Jan 16, 2009 at 09:37:38AM +0200, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [090116 09:29]:
> > * Gadiyar, Anand <gadiyar@ti.com> [090115 20:48]:
> > > From: Anand Gadiyar <gadiyar@ti.com>
> > >
> > > Fix this compile error
> >
> > This one should go via the usb list too.
>
> Uh, looks like my usb filter is set too sensitive :)
>
> This is the platform code part, I'll apply this and queue it up
> in omap-fixes.
>
I think it's time to send this via greg so we can get musb working on
beagle. No otg though due to missing CONFIG_PM for omap3. Any plans to
get that upstream ??
Maybe it's better to get PM there first and avoid compile issues without
CONFIG_PM=y
--
balbi
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH] Fix compile error in usb-musb.c
2009-01-16 15:35 ` Felipe Balbi
@ 2009-01-16 15:38 ` Gadiyar, Anand
2009-01-16 15:49 ` Felipe Balbi
2009-01-16 21:27 ` David Brownell
1 sibling, 1 reply; 17+ messages in thread
From: Gadiyar, Anand @ 2009-01-16 15:38 UTC (permalink / raw)
To: me, Tony Lindgren; +Cc: linux-omap, David Brownell
> On Fri, Jan 16, 2009 at 09:37:38AM +0200, Tony Lindgren wrote:
> > * Tony Lindgren <tony@atomide.com> [090116 09:29]:
> > > * Gadiyar, Anand <gadiyar@ti.com> [090115 20:48]:
> > > > From: Anand Gadiyar <gadiyar@ti.com>
> > > >
> > > > Fix this compile error
> > >
> > > This one should go via the usb list too.
> >
> > Uh, looks like my usb filter is set too sensitive :)
> >
> > This is the platform code part, I'll apply this and queue it up
> > in omap-fixes.
> >
>
> I think it's time to send this via greg so we can get musb working on
> beagle. No otg though due to missing CONFIG_PM for omap3. Any plans to
> get that upstream ??
>
> Maybe it's better to get PM there first and avoid compile issues without
> CONFIG_PM=y
I still don't get it. Why Greg?
It's a one-line compile fix for God's sake - nothing even remotely related
to a change in USB - it's platform code that got broken for some reason.
And Tony's already going to queue it up.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-16 15:38 ` Gadiyar, Anand
@ 2009-01-16 15:49 ` Felipe Balbi
2009-01-16 15:54 ` Gadiyar, Anand
0 siblings, 1 reply; 17+ messages in thread
From: Felipe Balbi @ 2009-01-16 15:49 UTC (permalink / raw)
To: Gadiyar, Anand; +Cc: me, Tony Lindgren, linux-omap, David Brownell
On Fri, Jan 16, 2009 at 09:08:57PM +0530, Gadiyar, Anand wrote:
> I still don't get it. Why Greg?
>
> It's a one-line compile fix for God's sake - nothing even remotely related
> to a change in USB - it's platform code that got broken for some reason.
>
> And Tony's already going to queue it up.
I'm talking about pushing the whole file via musb patches ;-)
--
balbi
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH] Fix compile error in usb-musb.c
2009-01-16 15:49 ` Felipe Balbi
@ 2009-01-16 15:54 ` Gadiyar, Anand
0 siblings, 0 replies; 17+ messages in thread
From: Gadiyar, Anand @ 2009-01-16 15:54 UTC (permalink / raw)
To: me; +Cc: Tony Lindgren, linux-omap, David Brownell
> On Fri, Jan 16, 2009 at 09:08:57PM +0530, Gadiyar, Anand wrote:
> > I still don't get it. Why Greg?
> >
> > It's a one-line compile fix for God's sake - nothing even remotely related
> > to a change in USB - it's platform code that got broken for some reason.
> >
> > And Tony's already going to queue it up.
>
> I'm talking about pushing the whole file via musb patches ;-)
>
Oh, ok. Sorry.
- Anand
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-16 15:35 ` Felipe Balbi
2009-01-16 15:38 ` Gadiyar, Anand
@ 2009-01-16 21:27 ` David Brownell
2009-01-16 22:19 ` Felipe Balbi
1 sibling, 1 reply; 17+ messages in thread
From: David Brownell @ 2009-01-16 21:27 UTC (permalink / raw)
To: me; +Cc: Tony Lindgren, Gadiyar, Anand, linux-omap
On Friday 16 January 2009, Felipe Balbi wrote:
>
> I think it's time to send this via greg so we can get musb working on
> beagle. No otg though due to missing CONFIG_PM for omap3. Any plans to
> get that upstream ??
So why not just enable PM=y in the configuration? It's not
actually required to do much, beyond not being broken.
- Dave
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-16 21:27 ` David Brownell
@ 2009-01-16 22:19 ` Felipe Balbi
2009-01-16 22:31 ` David Brownell
0 siblings, 1 reply; 17+ messages in thread
From: Felipe Balbi @ 2009-01-16 22:19 UTC (permalink / raw)
To: David Brownell; +Cc: me, Tony Lindgren, Gadiyar, Anand, linux-omap
On Fri, Jan 16, 2009 at 01:27:52PM -0800, David Brownell wrote:
> So why not just enable PM=y in the configuration? It's not
> actually required to do much, beyond not being broken.
That patch would have to go through tony
arch/arch/plat-omap/include/mach/pm.h:
#if !defined(CONFIG_ARCH_OMAP730) && \
!defined(CONFIG_ARCH_OMAP15XX) && \
!defined(CONFIG_ARCH_OMAP16XX) && \
!defined(CONFIG_ARCH_OMAP24XX) && \
!defined(CONFIG_ARCH_OMAP34XX)
#error "Power management for this processor not implemented yet"
#endif
--
balbi
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-16 22:19 ` Felipe Balbi
@ 2009-01-16 22:31 ` David Brownell
2009-01-16 22:41 ` Felipe Balbi
2009-01-18 11:33 ` Tony Lindgren
0 siblings, 2 replies; 17+ messages in thread
From: David Brownell @ 2009-01-16 22:31 UTC (permalink / raw)
To: me; +Cc: Tony Lindgren, Gadiyar, Anand, linux-omap
On Friday 16 January 2009, Felipe Balbi wrote:
> On Fri, Jan 16, 2009 at 01:27:52PM -0800, David Brownell wrote:
> > So why not just enable PM=y in the configuration? It's not
> > actually required to do much, beyond not being broken.
>
> That patch would have to go through tony
>
> arch/arm/plat-omap/include/mach/pm.h:
>
> #if !defined(CONFIG_ARCH_OMAP730) && \
> !defined(CONFIG_ARCH_OMAP15XX) && \
> !defined(CONFIG_ARCH_OMAP16XX) && \
> !defined(CONFIG_ARCH_OMAP24XX) && \
> !defined(CONFIG_ARCH_OMAP34XX)
> #error "Power management for this processor not implemented yet"
> #endif
I didn't realize anyone outside of TI had their hands
on OMAP4 chips yet. :)
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-16 22:31 ` David Brownell
@ 2009-01-16 22:41 ` Felipe Balbi
2009-01-18 11:33 ` Tony Lindgren
1 sibling, 0 replies; 17+ messages in thread
From: Felipe Balbi @ 2009-01-16 22:41 UTC (permalink / raw)
To: David Brownell; +Cc: me, Tony Lindgren, Gadiyar, Anand, linux-omap
On Fri, Jan 16, 2009 at 02:31:00PM -0800, David Brownell wrote:
> On Friday 16 January 2009, Felipe Balbi wrote:
> > On Fri, Jan 16, 2009 at 01:27:52PM -0800, David Brownell wrote:
> > > So why not just enable PM=y in the configuration? It's not
> > > actually required to do much, beyond not being broken.
> >
> > That patch would have to go through tony
> >
> > arch/arm/plat-omap/include/mach/pm.h:
> >
> > #if !defined(CONFIG_ARCH_OMAP730) && \
> > !defined(CONFIG_ARCH_OMAP15XX) && \
> > !defined(CONFIG_ARCH_OMAP16XX) && \
> > !defined(CONFIG_ARCH_OMAP24XX) && \
> > !defined(CONFIG_ARCH_OMAP34XX)
> > #error "Power management for this processor not implemented yet"
> > #endif
>
> I didn't realize anyone outside of TI had their hands
> on OMAP4 chips yet. :)
hehe, the last line isn't in mainline ;-)
--
balbi
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-16 22:31 ` David Brownell
2009-01-16 22:41 ` Felipe Balbi
@ 2009-01-18 11:33 ` Tony Lindgren
2009-01-26 23:23 ` David Brownell
1 sibling, 1 reply; 17+ messages in thread
From: Tony Lindgren @ 2009-01-18 11:33 UTC (permalink / raw)
To: David Brownell; +Cc: me, Gadiyar, Anand, linux-omap
* David Brownell <david-b@pacbell.net> [090117 00:31]:
> On Friday 16 January 2009, Felipe Balbi wrote:
> > On Fri, Jan 16, 2009 at 01:27:52PM -0800, David Brownell wrote:
> > > So why not just enable PM=y in the configuration? It's not
> > > actually required to do much, beyond not being broken.
> >
> > That patch would have to go through tony
> >
> > arch/arm/plat-omap/include/mach/pm.h:
> >
> > #if !defined(CONFIG_ARCH_OMAP730) && \
> > !defined(CONFIG_ARCH_OMAP15XX) && \
> > !defined(CONFIG_ARCH_OMAP16XX) && \
> > !defined(CONFIG_ARCH_OMAP24XX) && \
> > !defined(CONFIG_ARCH_OMAP34XX)
> > #error "Power management for this processor not implemented yet"
> > #endif
>
> I didn't realize anyone outside of TI had their hands
> on OMAP4 chips yet. :)
Might be worth looking what it would take to make dummy CONFIG_PM
compile in mainline for mach-omap2.
Tony
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-18 11:33 ` Tony Lindgren
@ 2009-01-26 23:23 ` David Brownell
2009-01-26 23:26 ` Felipe Balbi
2009-02-12 1:24 ` Tony Lindgren
0 siblings, 2 replies; 17+ messages in thread
From: David Brownell @ 2009-01-26 23:23 UTC (permalink / raw)
To: Tony Lindgren; +Cc: me, Gadiyar, Anand, linux-omap
On Sunday 18 January 2009, Tony Lindgren wrote:
>
> > > #if !defined(CONFIG_ARCH_OMAP730) && \
> > > !defined(CONFIG_ARCH_OMAP15XX) && \
> > > !defined(CONFIG_ARCH_OMAP16XX) && \
> > > !defined(CONFIG_ARCH_OMAP24XX) && \
> > > !defined(CONFIG_ARCH_OMAP34XX)
> > > #error "Power management for this processor not implemented yet"
> > > #endif
> >
> > I didn't realize anyone outside of TI had their hands
> > on OMAP4 chips yet. :)
>
> Might be worth looking what it would take to make dummy CONFIG_PM
> compile in mainline for mach-omap2.
This (against mainline) makes build+link work ...
---
arch/arm/plat-omap/include/mach/pm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/arm/plat-omap/include/mach/pm.h
+++ b/arch/arm/plat-omap/include/mach/pm.h
@@ -108,7 +108,7 @@
!defined(CONFIG_ARCH_OMAP15XX) && \
!defined(CONFIG_ARCH_OMAP16XX) && \
!defined(CONFIG_ARCH_OMAP24XX)
-#error "Power management for this processor not implemented yet"
+#warning "Power management for this processor not implemented yet"
#endif
#ifndef __ASSEMBLER__
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-26 23:23 ` David Brownell
@ 2009-01-26 23:26 ` Felipe Balbi
2009-02-12 1:24 ` Tony Lindgren
1 sibling, 0 replies; 17+ messages in thread
From: Felipe Balbi @ 2009-01-26 23:26 UTC (permalink / raw)
To: David Brownell; +Cc: Tony Lindgren, me, Gadiyar, Anand, linux-omap
On Mon, Jan 26, 2009 at 03:23:42PM -0800, David Brownell wrote:
> --- a/arch/arm/plat-omap/include/mach/pm.h
> +++ b/arch/arm/plat-omap/include/mach/pm.h
> @@ -108,7 +108,7 @@
> !defined(CONFIG_ARCH_OMAP15XX) && \
> !defined(CONFIG_ARCH_OMAP16XX) && \
> !defined(CONFIG_ARCH_OMAP24XX)
> -#error "Power management for this processor not implemented yet"
> +#warning "Power management for this processor not implemented yet"
> #endif
>
> #ifndef __ASSEMBLER__
this is great as we can push usb-musb.c to mainline.
--
balbi
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-01-26 23:23 ` David Brownell
2009-01-26 23:26 ` Felipe Balbi
@ 2009-02-12 1:24 ` Tony Lindgren
2009-02-12 1:55 ` David Brownell
1 sibling, 1 reply; 17+ messages in thread
From: Tony Lindgren @ 2009-02-12 1:24 UTC (permalink / raw)
To: David Brownell; +Cc: me, Gadiyar, Anand, linux-omap
* David Brownell <david-b@pacbell.net> [090126 15:23]:
> On Sunday 18 January 2009, Tony Lindgren wrote:
> >
> > > > #if !defined(CONFIG_ARCH_OMAP730) && \
> > > > !defined(CONFIG_ARCH_OMAP15XX) && \
> > > > !defined(CONFIG_ARCH_OMAP16XX) && \
> > > > !defined(CONFIG_ARCH_OMAP24XX) && \
> > > > !defined(CONFIG_ARCH_OMAP34XX)
> > > > #error "Power management for this processor not implemented yet"
> > > > #endif
> > >
> > > I didn't realize anyone outside of TI had their hands
> > > on OMAP4 chips yet. :)
> >
> > Might be worth looking what it would take to make dummy CONFIG_PM
> > compile in mainline for mach-omap2.
>
> This (against mainline) makes build+link work ...
I'll add it to omap-fixes. Dave, can you please reply with your SOB?
Thanks,
Tony
> ---
> arch/arm/plat-omap/include/mach/pm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/arm/plat-omap/include/mach/pm.h
> +++ b/arch/arm/plat-omap/include/mach/pm.h
> @@ -108,7 +108,7 @@
> !defined(CONFIG_ARCH_OMAP15XX) && \
> !defined(CONFIG_ARCH_OMAP16XX) && \
> !defined(CONFIG_ARCH_OMAP24XX)
> -#error "Power management for this processor not implemented yet"
> +#warning "Power management for this processor not implemented yet"
> #endif
>
> #ifndef __ASSEMBLER__
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-02-12 1:24 ` Tony Lindgren
@ 2009-02-12 1:55 ` David Brownell
2009-02-12 21:35 ` Tony Lindgren
0 siblings, 1 reply; 17+ messages in thread
From: David Brownell @ 2009-02-12 1:55 UTC (permalink / raw)
To: Tony Lindgren; +Cc: me, Gadiyar, Anand, linux-omap
On Wednesday 11 February 2009, Tony Lindgren wrote:
> * David Brownell <david-b@pacbell.net> [090126 15:23]:
> > On Sunday 18 January 2009, Tony Lindgren wrote:
> > >
> > > > > #if !defined(CONFIG_ARCH_OMAP730) && \
> > > > > !defined(CONFIG_ARCH_OMAP15XX) && \
> > > > > !defined(CONFIG_ARCH_OMAP16XX) && \
> > > > > !defined(CONFIG_ARCH_OMAP24XX) && \
> > > > > !defined(CONFIG_ARCH_OMAP34XX)
> > > > > #error "Power management for this processor not implemented yet"
> > > > > #endif
> > > >
> > > > I didn't realize anyone outside of TI had their hands
> > > > on OMAP4 chips yet. :)
> > >
> > > Might be worth looking what it would take to make dummy CONFIG_PM
> > > compile in mainline for mach-omap2.
> >
> > This (against mainline) makes build+link work ...
>
> I'll add it to omap-fixes. Dave, can you please reply with your SOB?
Special offer, today only ... take your pick:
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Sonofabitch: David Brownell <dbrownell@users.sourceforge.net>
:)
>
> Thanks,
>
> Tony
>
>
> > ---
> > arch/arm/plat-omap/include/mach/pm.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/arch/arm/plat-omap/include/mach/pm.h
> > +++ b/arch/arm/plat-omap/include/mach/pm.h
> > @@ -108,7 +108,7 @@
> > !defined(CONFIG_ARCH_OMAP15XX) && \
> > !defined(CONFIG_ARCH_OMAP16XX) && \
> > !defined(CONFIG_ARCH_OMAP24XX)
> > -#error "Power management for this processor not implemented yet"
> > +#warning "Power management for this processor not implemented yet"
> > #endif
> >
> > #ifndef __ASSEMBLER__
> >
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] Fix compile error in usb-musb.c
2009-02-12 1:55 ` David Brownell
@ 2009-02-12 21:35 ` Tony Lindgren
0 siblings, 0 replies; 17+ messages in thread
From: Tony Lindgren @ 2009-02-12 21:35 UTC (permalink / raw)
To: dbrownell; +Cc: me, Gadiyar, Anand, linux-omap
* David Brownell <david-b@pacbell.net> [090211 17:55]:
> On Wednesday 11 February 2009, Tony Lindgren wrote:
> > * David Brownell <david-b@pacbell.net> [090126 15:23]:
> > > On Sunday 18 January 2009, Tony Lindgren wrote:
> > > >
> > > > > > #if !defined(CONFIG_ARCH_OMAP730) && \
> > > > > > !defined(CONFIG_ARCH_OMAP15XX) && \
> > > > > > !defined(CONFIG_ARCH_OMAP16XX) && \
> > > > > > !defined(CONFIG_ARCH_OMAP24XX) && \
> > > > > > !defined(CONFIG_ARCH_OMAP34XX)
> > > > > > #error "Power management for this processor not implemented yet"
> > > > > > #endif
> > > > >
> > > > > I didn't realize anyone outside of TI had their hands
> > > > > on OMAP4 chips yet. :)
> > > >
> > > > Might be worth looking what it would take to make dummy CONFIG_PM
> > > > compile in mainline for mach-omap2.
> > >
> > > This (against mainline) makes build+link work ...
> >
> > I'll add it to omap-fixes. Dave, can you please reply with your SOB?
>
> Special offer, today only ... take your pick:
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> Sonofabitch: David Brownell <dbrownell@users.sourceforge.net>
>
> :)
Thanks, I'll stick with the first one :)
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2009-02-12 21:36 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-15 18:48 [PATCH] Fix compile error in usb-musb.c Gadiyar, Anand
2009-01-16 7:29 ` Tony Lindgren
2009-01-16 7:37 ` Tony Lindgren
2009-01-16 15:35 ` Felipe Balbi
2009-01-16 15:38 ` Gadiyar, Anand
2009-01-16 15:49 ` Felipe Balbi
2009-01-16 15:54 ` Gadiyar, Anand
2009-01-16 21:27 ` David Brownell
2009-01-16 22:19 ` Felipe Balbi
2009-01-16 22:31 ` David Brownell
2009-01-16 22:41 ` Felipe Balbi
2009-01-18 11:33 ` Tony Lindgren
2009-01-26 23:23 ` David Brownell
2009-01-26 23:26 ` Felipe Balbi
2009-02-12 1:24 ` Tony Lindgren
2009-02-12 1:55 ` David Brownell
2009-02-12 21:35 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.