* [PATCH] security/smack/smack_lsm.c: cleanup kernel-doc
@ 2009-02-09 10:58 Qinghuang Feng
2009-02-15 20:41 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Qinghuang Feng @ 2009-02-09 10:58 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Casey Schaufler, linux-kernel
Remove comments which refer to nonexistent arguments.
Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
---
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 0278bc0..02c48ea 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -538,7 +538,6 @@ static int smack_inode_rename(struct inode *old_inode,
* smack_inode_permission - Smack version of permission()
* @inode: the inode in question
* @mask: the access requested
- * @nd: unused
*
* This is the important Smack hook.
*
@@ -701,8 +700,7 @@ static int smack_inode_removexattr(struct dentry *dentry, const char *name)
* @inode: the object
* @name: attribute name
* @buffer: where to put the result
- * @size: size of the buffer
- * @err: unused
+ * @alloc: unused
*
* Returns the size of the attribute or an error code
*/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] security/smack/smack_lsm.c: cleanup kernel-doc
2009-02-09 10:58 [PATCH] security/smack/smack_lsm.c: cleanup kernel-doc Qinghuang Feng
@ 2009-02-15 20:41 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2009-02-15 20:41 UTC (permalink / raw)
To: Qinghuang Feng; +Cc: Casey Schaufler, linux-kernel
On Mon, 9 Feb 2009 18:58:25 +0800 Qinghuang Feng wrote:
> Remove comments which refer to nonexistent arguments.
>
> Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
> ---
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 0278bc0..02c48ea 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -538,7 +538,6 @@ static int smack_inode_rename(struct inode *old_inode,
> * smack_inode_permission - Smack version of permission()
> * @inode: the inode in question
> * @mask: the access requested
> - * @nd: unused
> *
> * This is the important Smack hook.
> *
> @@ -701,8 +700,7 @@ static int smack_inode_removexattr(struct dentry *dentry, const char *name)
> * @inode: the object
> * @name: attribute name
> * @buffer: where to put the result
> - * @size: size of the buffer
> - * @err: unused
> + * @alloc: unused
> *
> * Returns the size of the attribute or an error code
> */
>
> --
ACK, but there are lots of other kernel-doc problems in security/smack/
that could stand to be fixed...
Thanks,
---
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-15 20:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-09 10:58 [PATCH] security/smack/smack_lsm.c: cleanup kernel-doc Qinghuang Feng
2009-02-15 20:41 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.