tarballs generated by Makepkgs

tarballs generated by Makepkgs

[Christoph Hellwig]

currently Makepkgs generats the source tarball as
package-version.src.tar.gz, which is not what we used for recent
releases and not what most other open source packages do.  I'd like to
change it to package-version.tar.gz, but that currently collides with
the binary tar packages.

Does anyone still need those binary tar packages?  If yes we should
rename them, too or otherwise just remove them.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: tarballs generated by Makepkgs

[Christoph Hellwig]

On Sun, Feb 15, 2009 at 03:21:25PM -0500, Christoph Hellwig wrote:
> currently Makepkgs generats the source tarball as
> package-version.src.tar.gz, which is not what we used for recent
> releases and not what most other open source packages do.  I'd like to
> change it to package-version.tar.gz, but that currently collides with
> the binary tar packages.
> 
> Does anyone still need those binary tar packages?  If yes we should
> rename them, too or otherwise just remove them.

This would be the easiest way, renaming the binary packages to
xfsprogs-$ver.bin.tar.gz and the source to the expected
xfsprogs-$ver.tar.gz.  Same patch would also go into xfsdump and dmapi.


Index: xfsprogs-dev/build/Makefile
===================================================================
--- xfsprogs-dev.orig/build/Makefile	2009-02-24 19:39:37.259153164 +0100
+++ xfsprogs-dev/build/Makefile	2009-02-24 19:39:58.817035065 +0100
@@ -6,7 +6,7 @@ TOPDIR = ..
 include $(TOPDIR)/include/builddefs
 
 MANIFEST=src-manifest
-SRCTAR=$(PKG_NAME)-$(PKG_VERSION).src.tar.gz
+SRCTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
 
 LDIRT = *-manifest *.gz $(TOPDIR)/$(PKG_NAME)-*
 
Index: xfsprogs-dev/build/tar/Makefile
===================================================================
--- xfsprogs-dev.orig/build/tar/Makefile	2009-02-24 19:40:08.459152818 +0100
+++ xfsprogs-dev/build/tar/Makefile	2009-02-24 19:40:13.721029934 +0100
@@ -5,7 +5,7 @@
 TOPDIR = ../..
 include $(TOPDIR)/include/builddefs
 
-BINTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
+BINTAR=$(PKG_NAME)-$(PKG_VERSION).bin.tar.gz
 LDIRT = *.gz
 
 default install install-dev install-lib:

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: tarballs generated by Makepkgs

[Christoph Hellwig]

ping?

On Tue, Feb 24, 2009 at 01:42:52PM -0500, Christoph Hellwig wrote:
> On Sun, Feb 15, 2009 at 03:21:25PM -0500, Christoph Hellwig wrote:
> > currently Makepkgs generats the source tarball as
> > package-version.src.tar.gz, which is not what we used for recent
> > releases and not what most other open source packages do.  I'd like to
> > change it to package-version.tar.gz, but that currently collides with
> > the binary tar packages.
> > 
> > Does anyone still need those binary tar packages?  If yes we should
> > rename them, too or otherwise just remove them.
> 
> This would be the easiest way, renaming the binary packages to
> xfsprogs-$ver.bin.tar.gz and the source to the expected
> xfsprogs-$ver.tar.gz.  Same patch would also go into xfsdump and dmapi.
> 
> 
> Index: xfsprogs-dev/build/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/build/Makefile	2009-02-24 19:39:37.259153164 +0100
> +++ xfsprogs-dev/build/Makefile	2009-02-24 19:39:58.817035065 +0100
> @@ -6,7 +6,7 @@ TOPDIR = ..
>  include $(TOPDIR)/include/builddefs
>  
>  MANIFEST=src-manifest
> -SRCTAR=$(PKG_NAME)-$(PKG_VERSION).src.tar.gz
> +SRCTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
>  
>  LDIRT = *-manifest *.gz $(TOPDIR)/$(PKG_NAME)-*
>  
> Index: xfsprogs-dev/build/tar/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/build/tar/Makefile	2009-02-24 19:40:08.459152818 +0100
> +++ xfsprogs-dev/build/tar/Makefile	2009-02-24 19:40:13.721029934 +0100
> @@ -5,7 +5,7 @@
>  TOPDIR = ../..
>  include $(TOPDIR)/include/builddefs
>  
> -BINTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
> +BINTAR=$(PKG_NAME)-$(PKG_VERSION).bin.tar.gz
>  LDIRT = *.gz
>  
>  default install install-dev install-lib:
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: tarballs generated by Makepkgs

[Eric Sandeen]

Christoph Hellwig wrote:
> On Sun, Feb 15, 2009 at 03:21:25PM -0500, Christoph Hellwig wrote:
>> currently Makepkgs generats the source tarball as
>> package-version.src.tar.gz, which is not what we used for recent
>> releases and not what most other open source packages do.  I'd like to
>> change it to package-version.tar.gz, but that currently collides with
>> the binary tar packages.
>>
>> Does anyone still need those binary tar packages?  If yes we should
>> rename them, too or otherwise just remove them.
> 
> This would be the easiest way, renaming the binary packages to
> xfsprogs-$ver.bin.tar.gz and the source to the expected
> xfsprogs-$ver.tar.gz.  Same patch would also go into xfsdump and dmapi.
> 

Yes, this looks good.  it always bugged me the way it was ;)

Missed this for review based on no [PATCH] ;)

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

(same for the other packages as well)

> Index: xfsprogs-dev/build/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/build/Makefile	2009-02-24 19:39:37.259153164 +0100
> +++ xfsprogs-dev/build/Makefile	2009-02-24 19:39:58.817035065 +0100
> @@ -6,7 +6,7 @@ TOPDIR = ..
>  include $(TOPDIR)/include/builddefs
>  
>  MANIFEST=src-manifest
> -SRCTAR=$(PKG_NAME)-$(PKG_VERSION).src.tar.gz
> +SRCTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
>  
>  LDIRT = *-manifest *.gz $(TOPDIR)/$(PKG_NAME)-*
>  
> Index: xfsprogs-dev/build/tar/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/build/tar/Makefile	2009-02-24 19:40:08.459152818 +0100
> +++ xfsprogs-dev/build/tar/Makefile	2009-02-24 19:40:13.721029934 +0100
> @@ -5,7 +5,7 @@
>  TOPDIR = ../..
>  include $(TOPDIR)/include/builddefs
>  
> -BINTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
> +BINTAR=$(PKG_NAME)-$(PKG_VERSION).bin.tar.gz
>  LDIRT = *.gz
>  
>  default install install-dev install-lib:
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: tarballs generated by Makepkgs

[Christoph Hellwig]

On Sun, Mar 22, 2009 at 02:22:08PM -0500, Eric Sandeen wrote:
> Yes, this looks good.  it always bugged me the way it was ;)
> 
> Missed this for review based on no [PATCH] ;)
> 
> Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> 
> (same for the other packages as well)

Thanks, I've pushed this and the equivalent changes for xfsdump and
dmapi out to the kernel.org trees.

Now the only outstanding userspace patches for the 3.0.1 releases is
the whole autoconf/libtool magic from Andreas.  Although we might
consider this reviewed enough given that it comes from the acl/attr
build system.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs