All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] fix missing brace in macaddr changes in u-boot.git/next in smc911x.c
@ 2009-02-22 22:15 Mike Frysinger
  2009-02-22 22:41 ` Wolfgang Denk
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2009-02-22 22:15 UTC (permalink / raw)
  To: u-boot

i was going through the macaddr patchset to see if there was something else i 
missed and noticed that the changes to smc911x are missing a brace.

you'll probably want to squash this into the changeset:
	lan91c96/smc91111/smc911x: get mac address from environment
-mike

--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -437,7 +437,7 @@ static int smx911x_handle_mac_address(bd_t *bd)
 	uchar m[6];
 
 	/* if the environment has a valid mac address then use it */
-	if (!eth_getenv_enetaddr("ethaddr", m))
+	if (!eth_getenv_enetaddr("ethaddr", m)) {
 		/* if not, try to get one from the eeprom */
 		addrh = smc911x_get_mac_csr(ADDRH);
 		addrl = smc911x_get_mac_csr(ADDRL);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090222/8187aa49/attachment-0001.pgp 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] fix missing brace in macaddr changes in u-boot.git/next in smc911x.c
  2009-02-22 22:15 [U-Boot] [PATCH] fix missing brace in macaddr changes in u-boot.git/next in smc911x.c Mike Frysinger
@ 2009-02-22 22:41 ` Wolfgang Denk
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2009-02-22 22:41 UTC (permalink / raw)
  To: u-boot

Dear Mike Frysinger,

In message <200902221715.52440.vapier@gentoo.org> you wrote:
>
> i was going through the macaddr patchset to see if there was something else i 
> missed and noticed that the changes to smc911x are missing a brace.

Ah. thanks for pointing out.

> you'll probably want to squash this into the changeset:
> 	lan91c96/smc91111/smc911x: get mac address from environment

Will do exactly that.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something  done:  do  it  yourself,  hire
someone, or forbid your kids to do it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-22 22:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-22 22:15 [U-Boot] [PATCH] fix missing brace in macaddr changes in u-boot.git/next in smc911x.c Mike Frysinger
2009-02-22 22:41 ` Wolfgang Denk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.