All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] mm: k8_northbridges[] build fix
@ 2009-02-25 21:45 wli
  0 siblings, 0 replies; only message in thread
From: wli @ 2009-02-25 21:45 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mark Langsdorf, Ingo Molnar, Thomas Gleixner, H. Peter Anvin,
	Rusty Russell, Eric Lammerts, Andrew Morton

k8_northbridges[] isn't a defined symbol unless arch/x86/kernel/k8.c
is compiled, which is conditional on CONFIG_K8_NB. This patch resolves
the link error by making the sysfs access to the k8 northbridge
conditional on CONFIG_K8_NB in like fashion to the k8_northbridges[]
array itself. The issue was encountered on a 32-bit build with the
processor family specified as CONFIG_MCORE2=y.

The link error was introduced in
	x86-conform-l3-cache-index-disable-to-linux-standards.patch

Signed-off-by: William Irwin <wli@movementarian.org>


Index: mmotm-2.6.29-rc6/arch/x86/kernel/cpu/intel_cacheinfo.c
===================================================================
--- mmotm-2.6.29-rc6.orig/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ mmotm-2.6.29-rc6/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -613,7 +613,7 @@ static int __cpuinit detect_cache_attrib
 	return retval;
 }
 
-#ifdef CONFIG_SYSFS
+#if defined(CONFIG_SYSFS) && defined(CONFIG_K8_NB)
 
 #include <linux/kobject.h>
 #include <linux/sysfs.h>
@@ -986,4 +986,4 @@ static int __cpuinit cache_sysfs_init(vo
 
 device_initcall(cache_sysfs_init);
 
-#endif
+#endif /* defined(CONFIG_SYSFS) && defined(CONFIG_K8_NB) */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-02-25 21:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-25 21:45 [patch] mm: k8_northbridges[] build fix wli

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.