All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [tip:core/header-fixes] compiler-gcc4: conditionalize #error on __KERNEL__
       [not found] <tip-442405f292c9f9e043afc2243a5b4128f2704c49@kernel.org>
@ 2009-02-26  0:21 ` Arnd Bergmann
  0 siblings, 0 replies; only message in thread
From: Arnd Bergmann @ 2009-02-26  0:21 UTC (permalink / raw)
  To: hpa, mingo, tglx, hpa, linux-kernel

On Thursday 26 February 2009, H. Peter Anvin wrote:
> compiler-gcc4: conditionalize #error on __KERNEL__
> 
> Impact: Fix for exported headers
> 
> We only want to error out on specific gcc versions if we are actually
> building the kernel, so conditionalize the #if...#error on __KERNEL__.
> 
> Based on a patchset by Arnd Bergmann <arnd@arndb.de>.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>

No kidding. It never occurred to me that this hunk from my patch was
any good. It just happened that I was cross compiling for powerpc
and only had a ppc64-gcc-4.1.0 installed on my laptop, so I commented
out that line with the intention of reverting that change after a
successful build...

Good catch!

	Arnd <><

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-02-26  0:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <tip-442405f292c9f9e043afc2243a5b4128f2704c49@kernel.org>
2009-02-26  0:21 ` [tip:core/header-fixes] compiler-gcc4: conditionalize #error on __KERNEL__ Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.