All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [patch 1/2] mm: page_mkwrite change prototype to match fault
Date: Tue, 3 Mar 2009 10:58:35 -0500	[thread overview]
Message-ID: <20090303155835.GA28851@infradead.org> (raw)
In-Reply-To: <20090303103838.GC17042@wotan.suse.de>

On Tue, Mar 03, 2009 at 11:38:38AM +0100, Nick Piggin wrote:
> 
> Change the page_mkwrite prototype to take a struct vm_fault, and return
> VM_FAULT_xxx flags. Same as ->fault handler. Should be no change in
> behaviour.

How about just merging it into ->fault?

> This is required for a subsequent fix. And will also make it easier to
> merge page_mkwrite() with fault() in future.

Ah, I should read until the end :)  Any reason not to do the merge just
yet?


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [patch 1/2] mm: page_mkwrite change prototype to match fault
Date: Tue, 3 Mar 2009 10:58:35 -0500	[thread overview]
Message-ID: <20090303155835.GA28851@infradead.org> (raw)
In-Reply-To: <20090303103838.GC17042@wotan.suse.de>

On Tue, Mar 03, 2009 at 11:38:38AM +0100, Nick Piggin wrote:
> 
> Change the page_mkwrite prototype to take a struct vm_fault, and return
> VM_FAULT_xxx flags. Same as ->fault handler. Should be no change in
> behaviour.

How about just merging it into ->fault?

> This is required for a subsequent fix. And will also make it easier to
> merge page_mkwrite() with fault() in future.

Ah, I should read until the end :)  Any reason not to do the merge just
yet?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-03-03 15:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03 10:38 [patch 1/2] mm: page_mkwrite change prototype to match fault Nick Piggin
2009-03-03 10:38 ` Nick Piggin
2009-03-03 10:41 ` [rfc][patch 2/2] buffer, btrfs: fix page_mkwrite error cases Nick Piggin
2009-03-03 10:41   ` Nick Piggin
2009-03-03 14:26   ` Chris Mason
2009-03-03 14:26     ` Chris Mason
2009-03-03 14:41     ` Nick Piggin
2009-03-03 14:41       ` Nick Piggin
2009-03-03 14:47       ` Chris Mason
2009-03-03 12:39 ` [patch 1/2] mm: page_mkwrite change prototype to match fault steve
2009-03-03 12:39   ` steve
2009-03-03 15:58 ` Christoph Hellwig [this message]
2009-03-03 15:58   ` Christoph Hellwig
2009-03-04 10:21   ` Nick Piggin
2009-03-04 10:21     ` Nick Piggin
2009-03-11  3:53 Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090303155835.GA28851@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.