All of lore.kernel.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: bharata@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com,
	dhaval@linux.vnet.ibm.com, kamezawa.hiroyu@jp.fujitsu.com,
	lizf@cn.fujitsu.com, menage@google.com
Subject: + cgroup-css-id-support-remove-rcu_read_lock-from-css_get_next.patch added to -mm tree
Date: Wed, 04 Mar 2009 13:47:05 -0800	[thread overview]
Message-ID: <200903042147.n24Ll5Xi006321@imap1.linux-foundation.org> (raw)


The patch titled
     cgroup: remove rcu_read_lock() from css_get_next()
has been added to the -mm tree.  Its filename is
     cgroup-css-id-support-remove-rcu_read_lock-from-css_get_next.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: cgroup: remove rcu_read_lock() from css_get_next()
From: Bharata B Rao <bharata@linux.vnet.ibm.com>

Callers of css_get_next() are already calling css_get_next() under
rcu_read_lock() and hence there there is no need for css_get_next() to
re-acquire rcu_read_lock().  As per the comments in css_get_next(), let
the callers accquire the rcu_read_lock().

Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Cc: Paul Menage <menage@google.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/cgroup.c |    3 ---
 1 file changed, 3 deletions(-)

diff -puN kernel/cgroup.c~cgroup-css-id-support-remove-rcu_read_lock-from-css_get_next kernel/cgroup.c
--- a/kernel/cgroup.c~cgroup-css-id-support-remove-rcu_read_lock-from-css_get_next
+++ a/kernel/cgroup.c
@@ -3500,7 +3500,6 @@ css_get_next(struct cgroup_subsys *ss, i
 		return NULL;
 
 	BUG_ON(!ss->use_id);
-	rcu_read_lock();
 	/* fill start point for scan */
 	tmpid = id;
 	while (1) {
@@ -3524,8 +3523,6 @@ css_get_next(struct cgroup_subsys *ss, i
 		/* continue to scan from next id */
 		tmpid = tmpid + 1;
 	}

                 reply	other threads:[~2009-03-04 21:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903042147.n24Ll5Xi006321@imap1.linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.