* + cgroup-css-id-support-remove-rcu_read_lock-from-css_get_next.patch added to -mm tree
@ 2009-03-04 21:47 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2009-03-04 21:47 UTC (permalink / raw)
To: mm-commits; +Cc: bharata, balbir, dhaval, kamezawa.hiroyu, lizf, menage
The patch titled
cgroup: remove rcu_read_lock() from css_get_next()
has been added to the -mm tree. Its filename is
cgroup-css-id-support-remove-rcu_read_lock-from-css_get_next.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: cgroup: remove rcu_read_lock() from css_get_next()
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Callers of css_get_next() are already calling css_get_next() under
rcu_read_lock() and hence there there is no need for css_get_next() to
re-acquire rcu_read_lock(). As per the comments in css_get_next(), let
the callers accquire the rcu_read_lock().
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Cc: Paul Menage <menage@google.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
kernel/cgroup.c | 3 ---
1 file changed, 3 deletions(-)
diff -puN kernel/cgroup.c~cgroup-css-id-support-remove-rcu_read_lock-from-css_get_next kernel/cgroup.c
--- a/kernel/cgroup.c~cgroup-css-id-support-remove-rcu_read_lock-from-css_get_next
+++ a/kernel/cgroup.c
@@ -3500,7 +3500,6 @@ css_get_next(struct cgroup_subsys *ss, i
return NULL;
BUG_ON(!ss->use_id);
- rcu_read_lock();
/* fill start point for scan */
tmpid = id;
while (1) {
@@ -3524,8 +3523,6 @@ css_get_next(struct cgroup_subsys *ss, i
/* continue to scan from next id */
tmpid = tmpid + 1;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-03-04 21:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-04 21:47 + cgroup-css-id-support-remove-rcu_read_lock-from-css_get_next.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.