All of lore.kernel.org
 help / color / mirror / Atom feed
* [BUG?] iproute2/skbedit bug?
@ 2009-03-04 19:46 Denys Fedoryschenko
  2009-03-04 21:36 ` Duyck, Alexander H
  0 siblings, 1 reply; 6+ messages in thread
From: Denys Fedoryschenko @ 2009-03-04 19:46 UTC (permalink / raw)
  To: netdev, alexander.h.duyck, shemminger

Hi

trying to do test case:

defaulthost ~ # tc qdisc del dev eth0 root handle 1: htb
defaulthost ~ # tc qdisc add dev eth0 root handle 1: htb
defaulthost ~ # tc class add dev eth0 parent 1:0 classid 1:1 htb rate 100Mbit 
ceil 100Mbit
defaulthost ~ #
defaulthost ~ # tc class add dev eth0 parent 1:1 classid 1:2 htb rate 100Mbit 
ceil 100Mbit
defaulthost ~ # tc qdisc add dev eth0 parent 1:2 handle 2: pfifo limit 1000
defaulthost ~ #
defaulthost ~ #
defaulthost ~ # tc filter add dev eth0 pref 200 parent 1: protocol ip u32 
match ip src 1.1.1.1/32 flowid 1:1 action skbedit priority 10
defaulthost ~ # tc filter add dev eth0 pref 201 parent 1: protocol ip u32 
match ip src 1.1.1.2/32 flowid 1:2 action skbedit priority 11
RTNETLINK answers: File exists
We have an error talking to the kernel

As soon as skbedit involved, i am getting this strange result "File exists".
If i change(remove) flowid, classes - seems doesn't matter

Result looks like this:
defaulthost ~ # tc -s filter show dev eth0
filter parent 1: protocol ip pref 200 u32
filter parent 1: protocol ip pref 200 u32 fh 800: ht divisor 1
filter parent 1: protocol ip pref 200 u32 fh 800::800 order 2048 key ht 800 
bkt 0 flowid 1:1  (rule hit 460 success 0)
  match 01010101/ffffffff at 12 (success 0 )
        action order 1:  skbedit priority :10 installed 82 sec used 82 sec      
Action statistics:
        Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
        rate 0bit 0pps backlog 0b 0p requeues 0

filter parent 1: protocol ip pref 201 u32
filter parent 1: protocol ip pref 201 u32 fh 801: ht divisor 1

If i remove skbedit:
defaulthost ~ # tc filter add dev eth0 pref 200 parent 1: protocol ip u32 
match ip src 1.1.1.1/32 flowid 1:1
defaulthost ~ #                                                                                                                            


^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [BUG?] iproute2/skbedit bug?
  2009-03-04 19:46 [BUG?] iproute2/skbedit bug? Denys Fedoryschenko
@ 2009-03-04 21:36 ` Duyck, Alexander H
  2009-03-04 21:42   ` Denys Fedoryschenko
  0 siblings, 1 reply; 6+ messages in thread
From: Duyck, Alexander H @ 2009-03-04 21:36 UTC (permalink / raw)
  To: Denys Fedoryschenko, netdev, shemminger

Denys Fedoryschenko wrote:
> Hi
>
> trying to do test case:
>
> defaulthost ~ # tc qdisc del dev eth0 root handle 1: htb
> defaulthost ~ # tc qdisc add dev eth0 root handle 1: htb
> defaulthost ~ # tc class add dev eth0 parent 1:0 classid 1:1 htb rate
> 100Mbit ceil 100Mbit
> defaulthost ~ #
> defaulthost ~ # tc class add dev eth0 parent 1:1 classid 1:2 htb rate
> 100Mbit ceil 100Mbit
> defaulthost ~ # tc qdisc add dev eth0 parent 1:2 handle 2: pfifo
> limit 1000 defaulthost ~ #
> defaulthost ~ #
> defaulthost ~ # tc filter add dev eth0 pref 200 parent 1: protocol ip
> u32 match ip src 1.1.1.1/32 flowid 1:1 action skbedit priority 10
> defaulthost ~ # tc filter add dev eth0 pref 201 parent 1: protocol ip
> u32 match ip src 1.1.1.2/32 flowid 1:2 action skbedit priority 11
> RTNETLINK answers: File exists
> We have an error talking to the kernel
>
> As soon as skbedit involved, i am getting this strange result "File
> exists". If i change(remove) flowid, classes - seems doesn't matter
>
> Result looks like this:
> defaulthost ~ # tc -s filter show dev eth0
> filter parent 1: protocol ip pref 200 u32
> filter parent 1: protocol ip pref 200 u32 fh 800: ht divisor 1
> filter parent 1: protocol ip pref 200 u32 fh 800::800 order 2048 key
> ht 800 bkt 0 flowid 1:1  (rule hit 460 success 0)
>   match 01010101/ffffffff at 12 (success 0 )
>         action order 1:  skbedit priority :10 installed 82 sec used
> 82 sec Action statistics:
>         Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>         rate 0bit 0pps backlog 0b 0p requeues 0
>
> filter parent 1: protocol ip pref 201 u32
> filter parent 1: protocol ip pref 201 u32 fh 801: ht divisor 1
>
> If i remove skbedit:
> defaulthost ~ # tc filter add dev eth0 pref 200 parent 1: protocol ip
> u32 match ip src 1.1.1.1/32 flowid 1:1
> defaulthost ~ #

Are you using the latest version off of the git tree or the version tagged v2.6.28?  There was a fix applied 13 days ago to the git tree version which resolves an issue with uninitialized memory being used in configuring the skbedit action.  This was causing "File Exists" errors similar to what you are seeing now.

Thanks,

Alex

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [BUG?] iproute2/skbedit bug?
  2009-03-04 21:36 ` Duyck, Alexander H
@ 2009-03-04 21:42   ` Denys Fedoryschenko
  2009-03-04 21:46     ` Duyck, Alexander H
  0 siblings, 1 reply; 6+ messages in thread
From: Denys Fedoryschenko @ 2009-03-04 21:42 UTC (permalink / raw)
  To: Duyck, Alexander H; +Cc: netdev, shemminger

On Wednesday 04 March 2009 23:36:07 Duyck, Alexander H wrote:
>
> Are you using the latest version off of the git tree or the version tagged
> v2.6.28?  There was a fix applied 13 days ago to the git tree version which
> resolves an issue with uninitialized memory being used in configuring the
> skbedit action.  This was causing "File Exists" errors similar to what you
> are seeing now.
>
2.6.29-rc6-git7
I will try rc7 now

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [BUG?] iproute2/skbedit bug?
  2009-03-04 21:42   ` Denys Fedoryschenko
@ 2009-03-04 21:46     ` Duyck, Alexander H
  2009-03-04 21:48       ` Denys Fedoryschenko
  2009-03-04 21:54       ` Denys Fedoryschenko
  0 siblings, 2 replies; 6+ messages in thread
From: Duyck, Alexander H @ 2009-03-04 21:46 UTC (permalink / raw)
  To: Denys Fedoryschenko; +Cc: netdev, shemminger

Denys Fedoryschenko wrote:
> On Wednesday 04 March 2009 23:36:07 Duyck, Alexander H wrote:
>>
>> Are you using the latest version off of the git tree or the version
>> tagged v2.6.28?  There was a fix applied 13 days ago to the git tree
>> version which resolves an issue with uninitialized memory being used
>> in configuring the skbedit action.  This was causing "File Exists"
>> errors similar to what you are seeing now.
>>
> 2.6.29-rc6-git7
> I will try rc7 now

Are you talking about the kernel or the iproute package?  The git tree I was referring to was the iproute tools package.

http://www.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git

Thanks,

Alex

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [BUG?] iproute2/skbedit bug?
  2009-03-04 21:46     ` Duyck, Alexander H
@ 2009-03-04 21:48       ` Denys Fedoryschenko
  2009-03-04 21:54       ` Denys Fedoryschenko
  1 sibling, 0 replies; 6+ messages in thread
From: Denys Fedoryschenko @ 2009-03-04 21:48 UTC (permalink / raw)
  To: Duyck, Alexander H; +Cc: netdev, shemminger

Ok, sorry, i will try latest git

On Wednesday 04 March 2009 23:46:47 Duyck, Alexander H wrote:
> Denys Fedoryschenko wrote:
> > On Wednesday 04 March 2009 23:36:07 Duyck, Alexander H wrote:
> >> Are you using the latest version off of the git tree or the version
> >> tagged v2.6.28?  There was a fix applied 13 days ago to the git tree
> >> version which resolves an issue with uninitialized memory being used
> >> in configuring the skbedit action.  This was causing "File Exists"
> >> errors similar to what you are seeing now.
> >
> > 2.6.29-rc6-git7
> > I will try rc7 now
>
> Are you talking about the kernel or the iproute package?  The git tree I
> was referring to was the iproute tools package.
>
> http://www.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git
>
> Thanks,
>
> Alex
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [BUG?] iproute2/skbedit bug?
  2009-03-04 21:46     ` Duyck, Alexander H
  2009-03-04 21:48       ` Denys Fedoryschenko
@ 2009-03-04 21:54       ` Denys Fedoryschenko
  1 sibling, 0 replies; 6+ messages in thread
From: Denys Fedoryschenko @ 2009-03-04 21:54 UTC (permalink / raw)
  To: Duyck, Alexander H; +Cc: netdev, shemminger

On Wednesday 04 March 2009 23:46:47 Duyck, Alexander H wrote:
> Denys Fedoryschenko wrote:
> > On Wednesday 04 March 2009 23:36:07 Duyck, Alexander H wrote:
> >> Are you using the latest version off of the git tree or the version
> >> tagged v2.6.28?  There was a fix applied 13 days ago to the git tree
> >> version which resolves an issue with uninitialized memory being used
> >> in configuring the skbedit action.  This was causing "File Exists"
> >> errors similar to what you are seeing now.
> >
> > 2.6.29-rc6-git7
> > I will try rc7 now
>
> Are you talking about the kernel or the iproute package?  The git tree I
> was referring to was the iproute tools package.
>
> http://www.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git
>
> Thanks,
>
> Alex
Latest iproute2 git is fine, thank you!


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-03-04 21:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-04 19:46 [BUG?] iproute2/skbedit bug? Denys Fedoryschenko
2009-03-04 21:36 ` Duyck, Alexander H
2009-03-04 21:42   ` Denys Fedoryschenko
2009-03-04 21:46     ` Duyck, Alexander H
2009-03-04 21:48       ` Denys Fedoryschenko
2009-03-04 21:54       ` Denys Fedoryschenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.