All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Eder <hannes@hanneseder.net>
To: trivial@kernel.org
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH v3 09/15] NULL noise: drivers/scsi/FlashPoint.c
Date: Thu, 05 Mar 2009 22:55:04 +0100	[thread overview]
Message-ID: <20090305215455.23866.57598.stgit@f10box.hanneseder.net> (raw)
In-Reply-To: <154e089b0903051215q1216aa53icd41556e2af8b234@mail.gmail.com>

Fix this sparse warnings:
  drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer
  drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer
  drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
v2: fix checkpatch.pl issue.
v2.1: other subject, as suggested by Al Viro
v3: no need to explicitly initialize the variables, as they are in the
    .bss section anyway (pointed out by James Bottomley)

 drivers/scsi/FlashPoint.c |   16 +++++++---------
 1 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
index b898d38..ac67307 100644
--- a/drivers/scsi/FlashPoint.c
+++ b/drivers/scsi/FlashPoint.c
@@ -902,13 +902,12 @@ static unsigned char FPT_scmachid(unsigned char p_card,
 static void FPT_autoCmdCmplt(unsigned long p_port, unsigned char p_card);
 static void FPT_autoLoadDefaultMap(unsigned long p_port);
 
-static struct sccb_mgr_tar_info FPT_sccbMgrTbl[MAX_CARDS][MAX_SCSI_TAR] =
-    { {{0}} };
-static struct sccb_card FPT_BL_Card[MAX_CARDS] = { {0} };
-static SCCBSCAM_INFO FPT_scamInfo[MAX_SCSI_TAR] = { {{0}} };
-static struct nvram_info FPT_nvRamInfo[MAX_MB_CARDS] = { {0} };
+static struct sccb_mgr_tar_info FPT_sccbMgrTbl[MAX_CARDS][MAX_SCSI_TAR];
+static struct sccb_card FPT_BL_Card[MAX_CARDS];
+static SCCBSCAM_INFO FPT_scamInfo[MAX_SCSI_TAR];
+static struct nvram_info FPT_nvRamInfo[MAX_MB_CARDS];
 
-static unsigned char FPT_mbCards = 0;
+static unsigned char FPT_mbCards;
 static unsigned char FPT_scamHAString[] =
     { 0x63, 0x07, 'B', 'U', 'S', 'L', 'O', 'G', 'I', 'C',
 	' ', 'B', 'T', '-', '9', '3', '0',
@@ -916,10 +915,9 @@ static unsigned char FPT_scamHAString[] =
 	0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20
 };
 
-static unsigned short FPT_default_intena = 0;
+static unsigned short FPT_default_intena;
 
-static void (*FPT_s_PhaseTbl[8]) (unsigned long, unsigned char) = {
-0};
+static void (*FPT_s_PhaseTbl[8]) (unsigned long, unsigned char);
 
 /*---------------------------------------------------------------------
  *


WARNING: multiple messages have this Message-ID (diff)
From: Hannes Eder <hannes@hanneseder.net>
To: trivial@kernel.org
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH v3 09/15] NULL noise: drivers/scsi/FlashPoint.c
Date: Thu, 05 Mar 2009 21:55:04 +0000	[thread overview]
Message-ID: <20090305215455.23866.57598.stgit@f10box.hanneseder.net> (raw)
In-Reply-To: <154e089b0903051215q1216aa53icd41556e2af8b234@mail.gmail.com>

Fix this sparse warnings:
  drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer
  drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer
  drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
v2: fix checkpatch.pl issue.
v2.1: other subject, as suggested by Al Viro
v3: no need to explicitly initialize the variables, as they are in the
    .bss section anyway (pointed out by James Bottomley)

 drivers/scsi/FlashPoint.c |   16 +++++++---------
 1 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
index b898d38..ac67307 100644
--- a/drivers/scsi/FlashPoint.c
+++ b/drivers/scsi/FlashPoint.c
@@ -902,13 +902,12 @@ static unsigned char FPT_scmachid(unsigned char p_card,
 static void FPT_autoCmdCmplt(unsigned long p_port, unsigned char p_card);
 static void FPT_autoLoadDefaultMap(unsigned long p_port);
 
-static struct sccb_mgr_tar_info FPT_sccbMgrTbl[MAX_CARDS][MAX_SCSI_TAR] -    { {{0}} };
-static struct sccb_card FPT_BL_Card[MAX_CARDS] = { {0} };
-static SCCBSCAM_INFO FPT_scamInfo[MAX_SCSI_TAR] = { {{0}} };
-static struct nvram_info FPT_nvRamInfo[MAX_MB_CARDS] = { {0} };
+static struct sccb_mgr_tar_info FPT_sccbMgrTbl[MAX_CARDS][MAX_SCSI_TAR];
+static struct sccb_card FPT_BL_Card[MAX_CARDS];
+static SCCBSCAM_INFO FPT_scamInfo[MAX_SCSI_TAR];
+static struct nvram_info FPT_nvRamInfo[MAX_MB_CARDS];
 
-static unsigned char FPT_mbCards = 0;
+static unsigned char FPT_mbCards;
 static unsigned char FPT_scamHAString[]      { 0x63, 0x07, 'B', 'U', 'S', 'L', 'O', 'G', 'I', 'C',
 	' ', 'B', 'T', '-', '9', '3', '0',
@@ -916,10 +915,9 @@ static unsigned char FPT_scamHAString[]  	0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20
 };
 
-static unsigned short FPT_default_intena = 0;
+static unsigned short FPT_default_intena;
 
-static void (*FPT_s_PhaseTbl[8]) (unsigned long, unsigned char) = {
-0};
+static void (*FPT_s_PhaseTbl[8]) (unsigned long, unsigned char);
 
 /*---------------------------------------------------------------------
  *


WARNING: multiple messages have this Message-ID (diff)
From: Hannes Eder <hannes@hanneseder.net>
To: trivial@kernel.org
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH v3 09/15] NULL noise: drivers/scsi/FlashPoint.c
Date: Thu, 05 Mar 2009 22:55:04 +0100	[thread overview]
Message-ID: <20090305215455.23866.57598.stgit@f10box.hanneseder.net> (raw)
In-Reply-To: <154e089b0903051215q1216aa53icd41556e2af8b234@mail.gmail.com>

Fix this sparse warnings:
  drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer
  drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer
  drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
v2: fix checkpatch.pl issue.
v2.1: other subject, as suggested by Al Viro
v3: no need to explicitly initialize the variables, as they are in the
    .bss section anyway (pointed out by James Bottomley)

 drivers/scsi/FlashPoint.c |   16 +++++++---------
 1 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
index b898d38..ac67307 100644
--- a/drivers/scsi/FlashPoint.c
+++ b/drivers/scsi/FlashPoint.c
@@ -902,13 +902,12 @@ static unsigned char FPT_scmachid(unsigned char p_card,
 static void FPT_autoCmdCmplt(unsigned long p_port, unsigned char p_card);
 static void FPT_autoLoadDefaultMap(unsigned long p_port);
 
-static struct sccb_mgr_tar_info FPT_sccbMgrTbl[MAX_CARDS][MAX_SCSI_TAR] =
-    { {{0}} };
-static struct sccb_card FPT_BL_Card[MAX_CARDS] = { {0} };
-static SCCBSCAM_INFO FPT_scamInfo[MAX_SCSI_TAR] = { {{0}} };
-static struct nvram_info FPT_nvRamInfo[MAX_MB_CARDS] = { {0} };
+static struct sccb_mgr_tar_info FPT_sccbMgrTbl[MAX_CARDS][MAX_SCSI_TAR];
+static struct sccb_card FPT_BL_Card[MAX_CARDS];
+static SCCBSCAM_INFO FPT_scamInfo[MAX_SCSI_TAR];
+static struct nvram_info FPT_nvRamInfo[MAX_MB_CARDS];
 
-static unsigned char FPT_mbCards = 0;
+static unsigned char FPT_mbCards;
 static unsigned char FPT_scamHAString[] =
     { 0x63, 0x07, 'B', 'U', 'S', 'L', 'O', 'G', 'I', 'C',
 	' ', 'B', 'T', '-', '9', '3', '0',
@@ -916,10 +915,9 @@ static unsigned char FPT_scamHAString[] =
 	0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20
 };
 
-static unsigned short FPT_default_intena = 0;
+static unsigned short FPT_default_intena;
 
-static void (*FPT_s_PhaseTbl[8]) (unsigned long, unsigned char) = {
-0};
+static void (*FPT_s_PhaseTbl[8]) (unsigned long, unsigned char);
 
 /*---------------------------------------------------------------------
  *


  reply	other threads:[~2009-03-05 21:56 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-05 19:10 [PATCH v2 00/15] NULL noise fix: allmodconfig (x86_64), entire tree Hannes Eder
2009-03-05 19:10 ` Hannes Eder
2009-03-05 19:12 ` [PATCH v2 01/15] NULL noise: arch/x86/kernel Hannes Eder
2009-03-05 19:12   ` Hannes Eder
2009-03-05 19:13 ` [PATCH v2 02/15] NULL noise: arch/x86/kernel/amd_iommu*.c Hannes Eder
2009-03-05 19:13   ` Hannes Eder
2009-03-05 19:53   ` [PATCH v3 " Hannes Eder
2009-03-05 19:53     ` Hannes Eder
2009-03-05 19:13 ` [PATCH v2 03/15] NULL noise: arch/x86/xen/smp.c Hannes Eder
2009-03-05 19:13   ` Hannes Eder
2009-03-05 19:13   ` Hannes Eder
2009-03-05 20:15   ` Jeremy Fitzhardinge
2009-03-05 20:15     ` Jeremy Fitzhardinge
2009-03-05 20:15     ` Jeremy Fitzhardinge
2009-03-17 13:17     ` Jiri Kosina
2009-03-17 13:17       ` Jiri Kosina
2009-03-18  0:27       ` Jeremy Fitzhardinge
2009-03-18  0:27         ` Jeremy Fitzhardinge
2009-03-18 10:28         ` Jiri Kosina
2009-03-18 10:28           ` Jiri Kosina
2009-03-05 19:14 ` [PATCH v2 04/15] NULL noise: drivers/gpu/drm/radeon/radeon_*.c Hannes Eder
2009-03-05 19:14   ` Hannes Eder
2009-03-05 19:14 ` [PATCH v2 05/15] NULL noise: drivers/media/dvb/frontends/drx397xD_fw.h Hannes Eder
2009-03-05 19:14   ` Hannes Eder
2009-03-09 10:58   ` Mauro Carvalho Chehab
2009-03-09 10:58     ` [PATCH v2 05/15] NULL noise: Mauro Carvalho Chehab
2009-03-17 13:20     ` [PATCH v2 05/15] NULL noise: drivers/media/dvb/frontends/drx397xD_fw.h Jiri Kosina
2009-03-17 13:20       ` [PATCH v2 05/15] NULL noise: Jiri Kosina
2009-03-05 19:15 ` [PATCH v2 06/15] NULL noise: drivers/mtd/tests/mtd_*test.c Hannes Eder
2009-03-05 19:15   ` Hannes Eder
2009-03-06  6:09   ` Artem Bityutskiy
2009-03-06  6:09     ` Artem Bityutskiy
2009-03-17 13:21     ` Jiri Kosina
2009-03-17 13:21       ` Jiri Kosina
2009-03-17 14:27       ` Artem Bityutskiy
2009-03-17 14:27         ` Artem Bityutskiy
2009-03-17 14:27         ` Artem Bityutskiy
2009-03-05 19:15 ` [PATCH v2 07/15] NULL noise: drivers/pci/dmar.c Hannes Eder
2009-03-05 19:15   ` Hannes Eder
2009-03-05 19:15 ` [PATCH v2 08/15] NULL noise: drivers/platform/x86/panasonic-laptop.c Hannes Eder
2009-03-05 19:15   ` Hannes Eder
2009-04-07  5:56   ` Len Brown
2009-04-07  5:56     ` [PATCH v2 08/15] NULL noise: Len Brown
2009-03-05 19:16 ` [PATCH v2 09/15] NULL noise: drivers/scsi/FlashPoint.c Hannes Eder
2009-03-05 19:16   ` Hannes Eder
2009-03-05 20:05   ` James Bottomley
2009-03-05 20:05     ` James Bottomley
2009-03-05 20:15     ` Hannes Eder
2009-03-05 20:15       ` Hannes Eder
2009-03-05 20:15       ` Hannes Eder
2009-03-05 21:55       ` Hannes Eder [this message]
2009-03-05 21:55         ` [PATCH v3 " Hannes Eder
2009-03-05 21:55         ` Hannes Eder
2009-03-05 21:58       ` [PATCH v2 " James Bottomley
2009-03-05 21:58         ` James Bottomley
2009-03-05 19:16 ` [PATCH v2 10/15] NULL noise: drivers/usb/host/oxu210hp-hcd.c Hannes Eder
2009-03-05 19:16   ` Hannes Eder
2009-03-05 19:16 ` [PATCH v2 11/15] NULL noise: drivers/video/via/hw.c Hannes Eder
2009-03-05 19:16   ` Hannes Eder
2009-03-05 19:16   ` Hannes Eder
2009-03-05 19:17 ` [PATCH v2 12/15] NULL noise: fs/super.c Hannes Eder
2009-03-05 19:17   ` Hannes Eder
2009-03-05 19:18 ` [PATCH v2 13/15] NULL noise: fs/reiserfs/inode.c Hannes Eder
2009-03-05 19:18   ` Hannes Eder
2009-03-05 19:18   ` Hannes Eder
2009-03-05 19:18 ` [PATCH v2 14/15] NULL noise: kernel/test_kprobes.c Hannes Eder
2009-03-05 19:18   ` Hannes Eder
2009-03-05 19:18 ` [PATCH v2 15/15] NULL noise: mm/memcontrol.c Hannes Eder
2009-03-05 19:18   ` Hannes Eder
2009-03-05 22:42   ` Andrew Morton
2009-03-05 22:42     ` Andrew Morton
2009-03-05 23:04     ` Hannes Eder
2009-03-05 23:04       ` Hannes Eder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090305215455.23866.57598.stgit@f10box.hanneseder.net \
    --to=hannes@hanneseder.net \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.