From: Mark Brown <broonie@sirena.org.uk>
To: Bryan Wu <cooloney@kernel.org>
Cc: Cliff Cai <cliff.cai@analog.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/5] ASoC: ssm2602 codec: fix bug - kernel will crash when record and play in bf527-ezkit
Date: Fri, 6 Mar 2009 12:35:20 +0000 [thread overview]
Message-ID: <20090306123515.GG6493@sirena.org.uk> (raw)
In-Reply-To: <1236326010-683-3-git-send-email-cooloney@kernel.org>
On Fri, Mar 06, 2009 at 03:53:27PM +0800, Bryan Wu wrote:
> set constraint only if the value is not 0, change the configuring way for sport
This changelog doesn't appear to apply to this patch - it looks like
was copied from the previous one? This patch appears to suffer from a
similar issue where only the first format set by an application can ever
be used, though since this changes the constraints that are set by the
driver there's no possibility that applications will end up trying to
use a sample format that the hardware is not configured for.
Do we really need such a heavy handed fix here - what is the issue
that's being fixed?
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@sirena.org.uk>
To: Bryan Wu <cooloney@kernel.org>
Cc: Cliff Cai <cliff.cai@analog.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ASoC: ssm2602 codec: fix bug - kernel will crash when record and play in bf527-ezkit
Date: Fri, 6 Mar 2009 12:35:20 +0000 [thread overview]
Message-ID: <20090306123515.GG6493@sirena.org.uk> (raw)
In-Reply-To: <1236326010-683-3-git-send-email-cooloney@kernel.org>
On Fri, Mar 06, 2009 at 03:53:27PM +0800, Bryan Wu wrote:
> set constraint only if the value is not 0, change the configuring way for sport
This changelog doesn't appear to apply to this patch - it looks like
was copied from the previous one? This patch appears to suffer from a
similar issue where only the first format set by an application can ever
be used, though since this changes the constraints that are set by the
driver there's no possibility that applications will end up trying to
use a sample format that the hardware is not configured for.
Do we really need such a heavy handed fix here - what is the issue
that's being fixed?
next prev parent reply other threads:[~2009-03-06 12:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 7:53 [PATCH 0/5] Blackfin ASoC fixing and updates Bryan Wu
2009-03-06 7:53 ` [PATCH 1/5] ASoC: Blackfin: fix bug - kernel will crash when record and play in bf527-ezkit Bryan Wu
2009-03-06 7:53 ` Bryan Wu
2009-03-06 12:01 ` [alsa-devel] " Mark Brown
2009-03-06 12:01 ` Mark Brown
2009-03-09 10:58 ` [alsa-devel] [PATCH 1/5] ASoC: Blackfin: fix bug - kernel willcrash " Cai, Cliff
2009-03-09 10:58 ` Cai, Cliff
2009-03-09 11:21 ` [alsa-devel] " Mark Brown
2009-03-09 11:21 ` Mark Brown
2009-03-10 9:45 ` [alsa-devel] [PATCH 1/5] ASoC: Blackfin: fix bug - kernelwillcrash " Cai, Cliff
2009-03-10 9:45 ` Cai, Cliff
2009-03-06 7:53 ` [PATCH 2/5] ASoC: ssm2602 codec: fix bug - kernel will crash " Bryan Wu
2009-03-06 7:53 ` Bryan Wu
2009-03-06 9:50 ` [alsa-devel] " Karl Beldan
2009-03-06 9:50 ` Karl Beldan
2009-03-06 12:35 ` Mark Brown [this message]
2009-03-06 12:35 ` Mark Brown
2009-03-09 11:07 ` [alsa-devel] [PATCH 2/5] ASoC: ssm2602 codec: fix bug - kernelwill " Cai, Cliff
2009-03-09 11:07 ` Cai, Cliff
2009-03-09 11:55 ` Mark Brown
2009-03-09 11:55 ` Mark Brown
2009-03-06 7:53 ` [PATCH 3/5] ASoC: Blackfin: move gpio_err behind the define that is only user of it Bryan Wu
2009-03-06 11:13 ` [alsa-devel] " Mark Brown
2009-03-06 11:13 ` Mark Brown
2009-03-06 7:53 ` [PATCH 4/5] ASoC: Blackfin: drop pointless casts due to dma updates Bryan Wu
2009-03-06 11:10 ` [alsa-devel] " Mark Brown
2009-03-06 11:10 ` Mark Brown
2009-03-08 4:28 ` [alsa-devel] " Bryan Wu
2009-03-08 4:28 ` Bryan Wu
2009-03-06 7:53 ` [PATCH 5/5] ASoC: Blackfin: fix typo in MUTE definition Bryan Wu
2009-03-06 11:15 ` [alsa-devel] " Mark Brown
2009-03-06 11:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306123515.GG6493@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=cliff.cai@analog.com \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.