* /sys/hypervisor missing with pv_ops dom0?
@ 2009-03-07 19:39 Pasi Kärkkäinen
2009-03-08 5:24 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 9+ messages in thread
From: Pasi Kärkkäinen @ 2009-03-07 19:39 UTC (permalink / raw)
To: xen-devel
Hello!
/sys/hypervisor seems to be missing when using pv_ops dom0..
More specificly this file would be needed for rhel/fedora virt-install tool:
/sys/hypervisor/properties/capabilities
Am I missing some mounts or is this still not implemented feature? Or is it
deprecated?
Thanks!
-- Pasi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /sys/hypervisor missing with pv_ops dom0?
2009-03-07 19:39 /sys/hypervisor missing with pv_ops dom0? Pasi Kärkkäinen
@ 2009-03-08 5:24 ` Jeremy Fitzhardinge
2009-03-08 11:55 ` Pasi Kärkkäinen
0 siblings, 1 reply; 9+ messages in thread
From: Jeremy Fitzhardinge @ 2009-03-08 5:24 UTC (permalink / raw)
To: Pasi Kärkkäinen; +Cc: xen-devel
Pasi Kärkkäinen wrote:
> Hello!
>
> /sys/hypervisor seems to be missing when using pv_ops dom0..
>
> More specificly this file would be needed for rhel/fedora virt-install tool:
>
> /sys/hypervisor/properties/capabilities
>
> Am I missing some mounts or is this still not implemented feature? Or is it
> deprecated?
Just not implemented. There's probably a patch for it floating around
in the old RH dom0 git tree. I'll see if I can dig it up.
J
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /sys/hypervisor missing with pv_ops dom0?
2009-03-08 5:24 ` Jeremy Fitzhardinge
@ 2009-03-08 11:55 ` Pasi Kärkkäinen
2009-03-09 12:21 ` Pasi Kärkkäinen
0 siblings, 1 reply; 9+ messages in thread
From: Pasi Kärkkäinen @ 2009-03-08 11:55 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: xen-devel
On Sat, Mar 07, 2009 at 09:24:50PM -0800, Jeremy Fitzhardinge wrote:
> Pasi Kärkkäinen wrote:
> >Hello!
> >
> >/sys/hypervisor seems to be missing when using pv_ops dom0..
> >
> >More specificly this file would be needed for rhel/fedora virt-install
> >tool:
> >
> >/sys/hypervisor/properties/capabilities
> >
> >Am I missing some mounts or is this still not implemented feature? Or is it
> >deprecated?
>
> Just not implemented. There's probably a patch for it floating around
> in the old RH dom0 git tree. I'll see if I can dig it up.
>
Ok. Thanks for looking into that.
-- Pasi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /sys/hypervisor missing with pv_ops dom0?
2009-03-08 11:55 ` Pasi Kärkkäinen
@ 2009-03-09 12:21 ` Pasi Kärkkäinen
2009-03-09 16:56 ` Jeremy Fitzhardinge
2009-03-11 1:10 ` Jeremy Fitzhardinge
0 siblings, 2 replies; 9+ messages in thread
From: Pasi Kärkkäinen @ 2009-03-09 12:21 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: xen-devel
On Sun, Mar 08, 2009 at 01:55:04PM +0200, Pasi Kärkkäinen wrote:
> On Sat, Mar 07, 2009 at 09:24:50PM -0800, Jeremy Fitzhardinge wrote:
> > Pasi Kärkkäinen wrote:
> > >Hello!
> > >
> > >/sys/hypervisor seems to be missing when using pv_ops dom0..
> > >
> > >More specificly this file would be needed for rhel/fedora virt-install
> > >tool:
> > >
> > >/sys/hypervisor/properties/capabilities
> > >
> > >Am I missing some mounts or is this still not implemented feature? Or is it
> > >deprecated?
> >
> > Just not implemented. There's probably a patch for it floating around
> > in the old RH dom0 git tree. I'll see if I can dig it up.
> >
>
> Ok. Thanks for looking into that.
>
I searched for it myself, and found this commit:
http://git.et.redhat.com/?p=linux-2.6-dom0-pvops.git;a=commit;h=7aa79a5603bb604e8bf4fe7c31cc9c8b3d3b7ea2
Which looks to be the correct thing..
Could you commit that to current pv_ops dom0 tree?
-- Pasi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /sys/hypervisor missing with pv_ops dom0?
2009-03-09 12:21 ` Pasi Kärkkäinen
@ 2009-03-09 16:56 ` Jeremy Fitzhardinge
2009-03-11 1:10 ` Jeremy Fitzhardinge
1 sibling, 0 replies; 9+ messages in thread
From: Jeremy Fitzhardinge @ 2009-03-09 16:56 UTC (permalink / raw)
To: Pasi Kärkkäinen; +Cc: xen-devel
Pasi Kärkkäinen wrote:
> I searched for it myself, and found this commit:
>
> http://git.et.redhat.com/?p=linux-2.6-dom0-pvops.git;a=commit;h=7aa79a5603bb604e8bf4fe7c31cc9c8b3d3b7ea2
>
> Which looks to be the correct thing..
>
> Could you commit that to current pv_ops dom0 tree?
>
Thanks for pointing it out. That commit won't fit in very well as-is,
but I can steal the guts of it.
J
> -- Pasi
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /sys/hypervisor missing with pv_ops dom0?
2009-03-09 12:21 ` Pasi Kärkkäinen
2009-03-09 16:56 ` Jeremy Fitzhardinge
@ 2009-03-11 1:10 ` Jeremy Fitzhardinge
2009-03-11 8:12 ` Pasi Kärkkäinen
1 sibling, 1 reply; 9+ messages in thread
From: Jeremy Fitzhardinge @ 2009-03-11 1:10 UTC (permalink / raw)
To: Pasi Kärkkäinen; +Cc: xen-devel
Pasi Kärkkäinen wrote:
> I searched for it myself, and found this commit:
>
> http://git.et.redhat.com/?p=linux-2.6-dom0-pvops.git;a=commit;h=7aa79a5603bb604e8bf4fe7c31cc9c8b3d3b7ea2
>
> Which looks to be the correct thing..
>
> Could you commit that to current pv_ops dom0 tree?
>
OK, check out what's there now.
J
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /sys/hypervisor missing with pv_ops dom0?
2009-03-11 1:10 ` Jeremy Fitzhardinge
@ 2009-03-11 8:12 ` Pasi Kärkkäinen
2009-03-11 10:19 ` Ian Campbell
0 siblings, 1 reply; 9+ messages in thread
From: Pasi Kärkkäinen @ 2009-03-11 8:12 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: xen-devel
On Tue, Mar 10, 2009 at 06:10:39PM -0700, Jeremy Fitzhardinge wrote:
> Pasi Kärkkäinen wrote:
> >I searched for it myself, and found this commit:
> >
> >http://git.et.redhat.com/?p=linux-2.6-dom0-pvops.git;a=commit;h=7aa79a5603bb604e8bf4fe7c31cc9c8b3d3b7ea2
> >
> >Which looks to be the correct thing..
> >
> >Could you commit that to current pv_ops dom0 tree?
> >
>
> OK, check out what's there now.
>
Thanks, will try later today!
-- Pasi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: /sys/hypervisor missing with pv_ops dom0?
2009-03-11 8:12 ` Pasi Kärkkäinen
@ 2009-03-11 10:19 ` Ian Campbell
2009-03-11 17:49 ` Pasi Kärkkäinen
0 siblings, 1 reply; 9+ messages in thread
From: Ian Campbell @ 2009-03-11 10:19 UTC (permalink / raw)
To: Pasi Kärkkäinen; +Cc: Jeremy Fitzhardinge, xen-devel
On Wed, 2009-03-11 at 04:12 -0400, Pasi Kärkkäinen wrote:
> On Tue, Mar 10, 2009 at 06:10:39PM -0700, Jeremy Fitzhardinge wrote:
> > Pasi Kärkkäinen wrote:
> > >I searched for it myself, and found this commit:
> > >
> > >http://git.et.redhat.com/?p=linux-2.6-dom0-pvops.git;a=commit;h=7aa79a5603bb604e8bf4fe7c31cc9c8b3d3b7ea2
> > >
> > >Which looks to be the correct thing..
> > >
> > >Could you commit that to current pv_ops dom0 tree?
> > >
> >
> > OK, check out what's there now.
> >
>
>
> Thanks, will try later today!
>
I needed this to compile since there is no kexec yet in pvops kernel
CC drivers/xen/sys-hypervisor.o
drivers/xen/sys-hypervisor.c: In function 'hyper_sysfs_init':
drivers/xen/sys-hypervisor.c:405: error: 'vmcoreinfo_size_xen' undeclared (first use in this function)
drivers/xen/sys-hypervisor.c:405: error: (Each undeclared identifier is reported only once
drivers/xen/sys-hypervisor.c:405: error: for each function it appears in.)
drivers/xen/sys-hypervisor.c:406: error: implicit declaration of function 'xen_sysfs_vmcoreinfo_init'
drivers/xen/sys-hypervisor.c: In function 'hyper_sysfs_exit':
drivers/xen/sys-hypervisor.c:433: error: 'vmcoreinfo_size_xen' undeclared (first use in this function)
drivers/xen/sys-hypervisor.c:434: error: implicit declaration of function 'xen_sysfs_vmcoreinfo_destroy'
>From 10b22abd8f978fceaf9829253c6f883c5439c1f0 Mon Sep 17 00:00:00 2001
From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Wed, 11 Mar 2009 10:18:42 +0000
Subject: [PATCH] xen: drop kexec bits from /sys/hypervisor since kexec
isn't implemented yet
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
drivers/xen/sys-hypervisor.c | 41
-----------------------------------------
1 files changed, 0 insertions(+), 41 deletions(-)
diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
index 1267d6f..88a60e0 100644
--- a/drivers/xen/sys-hypervisor.c
+++ b/drivers/xen/sys-hypervisor.c
@@ -353,32 +353,6 @@ static void xen_properties_destroy(void)
sysfs_remove_group(hypervisor_kobj, &xen_properties_group);
}
-#ifdef CONFIG_KEXEC
-
-extern size_t vmcoreinfo_size_xen;
-extern unsigned long paddr_vmcoreinfo_xen;
-
-static ssize_t vmcoreinfo_show(struct hyp_sysfs_attr *attr, char *page)
-{
- return sprintf(page, "%lx %zx\n",
- paddr_vmcoreinfo_xen, vmcoreinfo_size_xen);
-}
-
-HYPERVISOR_ATTR_RO(vmcoreinfo);
-
-static int __init xen_sysfs_vmcoreinfo_init(void)
-{
- return sysfs_create_file(hypervisor_kobj,
- &vmcoreinfo_attr.attr);
-}
-
-static void xen_sysfs_vmcoreinfo_destroy(void)
-{
- sysfs_remove_file(hypervisor_kobj, &vmcoreinfo_attr.attr);
-}
-
-#endif
-
static int __init hyper_sysfs_init(void)
{
int ret;
@@ -401,20 +375,9 @@ static int __init hyper_sysfs_init(void)
ret = xen_properties_init();
if (ret)
goto prop_out;
-#ifdef CONFIG_KEXEC
- if (vmcoreinfo_size_xen != 0) {
- ret = xen_sysfs_vmcoreinfo_init();
- if (ret)
- goto vmcoreinfo_out;
- }
-#endif
goto out;
-#ifdef CONFIG_KEXEC
-vmcoreinfo_out:
-#endif
- xen_properties_destroy();
prop_out:
xen_sysfs_uuid_destroy();
uuid_out:
@@ -429,10 +392,6 @@ out:
static void __exit hyper_sysfs_exit(void)
{
-#ifdef CONFIG_KEXEC
- if (vmcoreinfo_size_xen != 0)
- xen_sysfs_vmcoreinfo_destroy();
-#endif
xen_properties_destroy();
xen_compilation_destroy();
xen_sysfs_uuid_destroy();
--
1.5.6.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: /sys/hypervisor missing with pv_ops dom0?
2009-03-11 10:19 ` Ian Campbell
@ 2009-03-11 17:49 ` Pasi Kärkkäinen
0 siblings, 0 replies; 9+ messages in thread
From: Pasi Kärkkäinen @ 2009-03-11 17:49 UTC (permalink / raw)
To: Ian Campbell; +Cc: Jeremy Fitzhardinge, xen-devel
On Wed, Mar 11, 2009 at 10:19:54AM +0000, Ian Campbell wrote:
> On Wed, 2009-03-11 at 04:12 -0400, Pasi Kärkkäinen wrote:
> > On Tue, Mar 10, 2009 at 06:10:39PM -0700, Jeremy Fitzhardinge wrote:
> > > Pasi Kärkkäinen wrote:
> > > >I searched for it myself, and found this commit:
> > > >
> > > >http://git.et.redhat.com/?p=linux-2.6-dom0-pvops.git;a=commit;h=7aa79a5603bb604e8bf4fe7c31cc9c8b3d3b7ea2
> > > >
> > > >Which looks to be the correct thing..
> > > >
> > > >Could you commit that to current pv_ops dom0 tree?
> > > >
> > >
> > > OK, check out what's there now.
> > >
> >
> >
> > Thanks, will try later today!
> >
>
> I needed this to compile since there is no kexec yet in pvops kernel
With Ian's patch it compiles for me, and looks like it works:
# cat /sys/hypervisor/properties/capabilities
xen-3.0-x86_32p
Thanks!
-- Pasi
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-03-11 17:49 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-07 19:39 /sys/hypervisor missing with pv_ops dom0? Pasi Kärkkäinen
2009-03-08 5:24 ` Jeremy Fitzhardinge
2009-03-08 11:55 ` Pasi Kärkkäinen
2009-03-09 12:21 ` Pasi Kärkkäinen
2009-03-09 16:56 ` Jeremy Fitzhardinge
2009-03-11 1:10 ` Jeremy Fitzhardinge
2009-03-11 8:12 ` Pasi Kärkkäinen
2009-03-11 10:19 ` Ian Campbell
2009-03-11 17:49 ` Pasi Kärkkäinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.