All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Daniel Lowengrub <lowdanie@gmail.com>
Cc: linux-mm@kvack.org, Ingo Molnar <mingo@elte.hu>,
	a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: use list.h for vma list
Date: Wed, 11 Mar 2009 13:40:18 +0300	[thread overview]
Message-ID: <20090311104018.GA2376@x200.localdomain> (raw)
In-Reply-To: <8c5a844a0903110255q45b7cdf4u1453ce40d495ee2c@mail.gmail.com>

On Wed, Mar 11, 2009 at 11:55:48AM +0200, Daniel Lowengrub wrote:
> Use the linked list defined list.h for the list of vmas that's stored
> in the mm_struct structure.  Wrapper functions "vma_next" and
> "vma_prev" are also implemented.  Functions that operate on more than
> one vma are now given a list of vmas as input.

> Signed-off-by: Daniel Lowengrub

That's not how S-o-b line should look like.

> --- linux-2.6.28.7.vanilla/arch/alpha/kernel/osf_sys.c
> +++ linux-2.6.28.7/arch/alpha/kernel/osf_sys.c
> @@ -1197,7 +1197,7 @@
>  		if (!vma || addr + len <= vma->vm_start)
>  			return addr;
>  		addr = vma->vm_end;
> -		vma = vma->vm_next;
> +		vma = vma_next(vma);

Well, this bloats both mm_struct and vm_area_struct.

WARNING: multiple messages have this Message-ID (diff)
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Daniel Lowengrub <lowdanie@gmail.com>
Cc: linux-mm@kvack.org, Ingo Molnar <mingo@elte.hu>,
	a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: use list.h for vma list
Date: Wed, 11 Mar 2009 13:40:18 +0300	[thread overview]
Message-ID: <20090311104018.GA2376@x200.localdomain> (raw)
In-Reply-To: <8c5a844a0903110255q45b7cdf4u1453ce40d495ee2c@mail.gmail.com>

On Wed, Mar 11, 2009 at 11:55:48AM +0200, Daniel Lowengrub wrote:
> Use the linked list defined list.h for the list of vmas that's stored
> in the mm_struct structure.  Wrapper functions "vma_next" and
> "vma_prev" are also implemented.  Functions that operate on more than
> one vma are now given a list of vmas as input.

> Signed-off-by: Daniel Lowengrub

That's not how S-o-b line should look like.

> --- linux-2.6.28.7.vanilla/arch/alpha/kernel/osf_sys.c
> +++ linux-2.6.28.7/arch/alpha/kernel/osf_sys.c
> @@ -1197,7 +1197,7 @@
>  		if (!vma || addr + len <= vma->vm_start)
>  			return addr;
>  		addr = vma->vm_end;
> -		vma = vma->vm_next;
> +		vma = vma_next(vma);

Well, this bloats both mm_struct and vm_area_struct.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-03-11 10:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11  9:55 [PATCH 1/2] mm: use list.h for vma list Daniel Lowengrub
2009-03-11  9:55 ` Daniel Lowengrub
2009-03-11 10:40 ` Alexey Dobriyan [this message]
2009-03-11 10:40   ` Alexey Dobriyan
2009-03-11 10:52   ` Ingo Molnar
2009-03-11 10:52     ` Ingo Molnar
2009-03-11 11:54 ` Nick Piggin
2009-03-11 11:54   ` Nick Piggin
2009-03-11 13:25   ` Daniel Lowengrub
2009-03-11 13:25     ` Daniel Lowengrub
2009-03-12  3:00     ` Nick Piggin
2009-03-12  3:00       ` Nick Piggin
2009-03-12  8:32   ` KOSAKI Motohiro
2009-03-12  8:32     ` KOSAKI Motohiro
2009-03-12  9:58 ` Peter Zijlstra
2009-03-12  9:58   ` Peter Zijlstra
2009-04-02  9:56   ` Daniel Lowengrub
2009-04-02  9:56     ` Daniel Lowengrub

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090311104018.GA2376@x200.localdomain \
    --to=adobriyan@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lowdanie@gmail.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.