* [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device
@ 2009-03-13 14:50 Daniel Mack
2009-03-13 15:32 ` Ben Dooks
2009-03-13 18:53 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: Daniel Mack @ 2009-03-13 14:50 UTC (permalink / raw)
To: linux-net; +Cc: linux-kernel, Daniel Mack, Ben Dooks
This patch adds support to the ax88796 ethernet driver to take IRQ flags
given by the platform_device definition.
The patch depends on the platform_get_irq_flags() function which I added
in a patch posted here:
http://lkml.org/lkml/2009/3/13/267
Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Ben Dooks <ben@simtec.co.uk>
---
drivers/net/ax88796.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
index a4eb6c4..728e17c 100644
--- a/drivers/net/ax88796.c
+++ b/drivers/net/ax88796.c
@@ -93,6 +93,7 @@ struct ax_device {
unsigned char running;
unsigned char resume_open;
+ unsigned int irqflags;
u32 reg_offsets[0x20];
};
@@ -474,7 +475,8 @@ static int ax_open(struct net_device *dev)
dev_dbg(&ax->dev->dev, "%s: open\n", dev->name);
- ret = request_irq(dev->irq, ax_ei_interrupt, 0, dev->name, dev);
+ ret = request_irq(dev->irq, ax_ei_interrupt, ax->irqflags,
+ dev->name, dev);
if (ret)
return ret;
@@ -856,6 +858,7 @@ static int ax_probe(struct platform_device *pdev)
goto exit_mem;
}
dev->irq = ret;
+ ax->irqflags = platform_get_irq_flags(pdev, 0);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (res == NULL) {
--
1.6.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device
2009-03-13 14:50 [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device Daniel Mack
@ 2009-03-13 15:32 ` Ben Dooks
2009-03-13 18:53 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: Ben Dooks @ 2009-03-13 15:32 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-net, linux-kernel, Ben Dooks
On Fri, Mar 13, 2009 at 03:50:51PM +0100, Daniel Mack wrote:
> This patch adds support to the ax88796 ethernet driver to take IRQ flags
> given by the platform_device definition.
>
> The patch depends on the platform_get_irq_flags() function which I added
> in a patch posted here:
>
> http://lkml.org/lkml/2009/3/13/267
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Ben Dooks <ben@simtec.co.uk>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
> drivers/net/ax88796.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
> index a4eb6c4..728e17c 100644
> --- a/drivers/net/ax88796.c
> +++ b/drivers/net/ax88796.c
> @@ -93,6 +93,7 @@ struct ax_device {
>
> unsigned char running;
> unsigned char resume_open;
> + unsigned int irqflags;
>
> u32 reg_offsets[0x20];
> };
> @@ -474,7 +475,8 @@ static int ax_open(struct net_device *dev)
>
> dev_dbg(&ax->dev->dev, "%s: open\n", dev->name);
>
> - ret = request_irq(dev->irq, ax_ei_interrupt, 0, dev->name, dev);
> + ret = request_irq(dev->irq, ax_ei_interrupt, ax->irqflags,
> + dev->name, dev);
> if (ret)
> return ret;
>
> @@ -856,6 +858,7 @@ static int ax_probe(struct platform_device *pdev)
> goto exit_mem;
> }
> dev->irq = ret;
> + ax->irqflags = platform_get_irq_flags(pdev, 0);
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (res == NULL) {
> --
> 1.6.2
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device
2009-03-13 14:50 [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device Daniel Mack
2009-03-13 15:32 ` Ben Dooks
@ 2009-03-13 18:53 ` David Miller
2009-03-13 19:02 ` David Miller
2009-03-15 11:27 ` Daniel Mack
1 sibling, 2 replies; 6+ messages in thread
From: David Miller @ 2009-03-13 18:53 UTC (permalink / raw)
To: daniel; +Cc: linux-net, linux-kernel, ben
From: Daniel Mack <daniel@caiaq.de>
Date: Fri, 13 Mar 2009 15:50:51 +0100
> This patch adds support to the ax88796 ethernet driver to take IRQ flags
> given by the platform_device definition.
>
> The patch depends on the platform_get_irq_flags() function which I added
> in a patch posted here:
>
> http://lkml.org/lkml/2009/3/13/267
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
Few things:
1) Send networking patches to netdev@vger.kernel.org, not linux-net
which is for user questions.
2) That platform_get_irq_flags() does not exist in any of the networking
trees so I cannot apply this.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device
2009-03-13 18:53 ` David Miller
@ 2009-03-13 19:02 ` David Miller
2009-03-13 19:10 ` Matti Aarnio
2009-03-15 11:27 ` Daniel Mack
1 sibling, 1 reply; 6+ messages in thread
From: David Miller @ 2009-03-13 19:02 UTC (permalink / raw)
To: daniel; +Cc: linux-net, linux-kernel, ben
Can someone forward my reply to daniel@caiaq.de? His site
doesn't accept emails from me because I lack reverse DNS.
Also let him know that he should get that resolved if he
wants to submit any other networking patches :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device
2009-03-13 19:02 ` David Miller
@ 2009-03-13 19:10 ` Matti Aarnio
0 siblings, 0 replies; 6+ messages in thread
From: Matti Aarnio @ 2009-03-13 19:10 UTC (permalink / raw)
To: David Miller; +Cc: linux-net, linux-kernel, ben
On Fri, Mar 13, 2009 at 12:02:14PM -0700, David Miller wrote:
>
> Can someone forward my reply to daniel@caiaq.de? His site
> doesn't accept emails from me because I lack reverse DNS.
>
> Also let him know that he should get that resolved if he
> wants to submit any other networking patches :-)
Done that, Dave.
You could use your privileges as VGER's user to send email
from there...
/Matti
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device
2009-03-13 18:53 ` David Miller
2009-03-13 19:02 ` David Miller
@ 2009-03-15 11:27 ` Daniel Mack
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Mack @ 2009-03-15 11:27 UTC (permalink / raw)
To: David Miller; +Cc: linux-net, linux-kernel, ben
Hi,
(the reverse-DNS check is disabled now, sorry for the trouble)
On Fri, Mar 13, 2009 at 11:53:42AM -0700, David Miller wrote:
> > This patch adds support to the ax88796 ethernet driver to take IRQ flags
> > given by the platform_device definition.
> >
> > The patch depends on the platform_get_irq_flags() function which I added
> > in a patch posted here:
> >
> > http://lkml.org/lkml/2009/3/13/267
> >
> > Signed-off-by: Daniel Mack <daniel@caiaq.de>
>
> Few things:
>
> 1) Send networking patches to netdev@vger.kernel.org, not linux-net
> which is for user questions.
Ok, wasn't aware of that, sorry.
> 2) That platform_get_irq_flags() does not exist in any of the networking
> trees so I cannot apply this.
Jep, the other one would need to me merged first. Could you ack on the
patch[*] in case you're fine with it?
Thanks,
Daniel
[*] http://lkml.org/lkml/2009/3/13/267
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-03-15 11:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-13 14:50 [PATCH] drivers/net/ax88796.c: take IRQ flags from platform_device Daniel Mack
2009-03-13 15:32 ` Ben Dooks
2009-03-13 18:53 ` David Miller
2009-03-13 19:02 ` David Miller
2009-03-13 19:10 ` Matti Aarnio
2009-03-15 11:27 ` Daniel Mack
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.