All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: roel.kluin@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] kfree(napi->skb) => kfree_skb
Date: Wed, 18 Mar 2009 23:16:05 -0700 (PDT)	[thread overview]
Message-ID: <20090318.231605.246064232.davem@davemloft.net> (raw)
In-Reply-To: <20090318.231043.56741082.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Wed, 18 Mar 2009 23:10:43 -0700 (PDT)

> From: Roel Kluin <roel.kluin@gmail.com>
> Date: Tue, 17 Mar 2009 11:38:25 +0100
> 
> > struct sk_buff pointers should be freed with kfree_skb.
> > 
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > ---
> > @@ -2669,11 +2669,11 @@ EXPORT_SYMBOL(netif_napi_add);
> >  void netif_napi_del(struct napi_struct *napi)
> >  {
> 
> Roel, what did you use to generate this patch? :-/
> 
> If you hand-edited the patch, please check your work before sending it
> out.

Don't bother resending Roel, I took care of it by hand.

Nobody is doing anything reasonably today, so I am just going
to start doing everything myself like I always seem to end
up doing :-/

Today sucks... so... much...


      reply	other threads:[~2009-03-19  6:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-17 10:38 [PATCH] kfree(napi->skb) => kfree_skb Roel Kluin
2009-03-19  6:10 ` David Miller
2009-03-19  6:16   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090318.231605.246064232.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.