* [PATCH] kfree(napi->skb) => kfree_skb
@ 2009-03-17 10:38 Roel Kluin
2009-03-19 6:10 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-03-17 10:38 UTC (permalink / raw)
To: netdev, David S. Miller
struct sk_buff pointers should be freed with kfree_skb.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
@@ -2669,11 +2669,11 @@ EXPORT_SYMBOL(netif_napi_add);
void netif_napi_del(struct napi_struct *napi)
{
struct sk_buff *skb, *next;
list_del_init(&napi->dev_list);
- kfree(napi->skb);
+ kfree_skb(napi->skb);
for (skb = napi->gro_list; skb; skb = next) {
next = skb->next;
skb->next = NULL;
kfree_skb(skb);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kfree(napi->skb) => kfree_skb
2009-03-17 10:38 [PATCH] kfree(napi->skb) => kfree_skb Roel Kluin
@ 2009-03-19 6:10 ` David Miller
2009-03-19 6:16 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-03-19 6:10 UTC (permalink / raw)
To: roel.kluin; +Cc: netdev
From: Roel Kluin <roel.kluin@gmail.com>
Date: Tue, 17 Mar 2009 11:38:25 +0100
> struct sk_buff pointers should be freed with kfree_skb.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> @@ -2669,11 +2669,11 @@ EXPORT_SYMBOL(netif_napi_add);
> void netif_napi_del(struct napi_struct *napi)
> {
Roel, what did you use to generate this patch? :-/
If you hand-edited the patch, please check your work before sending it
out.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kfree(napi->skb) => kfree_skb
2009-03-19 6:10 ` David Miller
@ 2009-03-19 6:16 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-03-19 6:16 UTC (permalink / raw)
To: roel.kluin; +Cc: netdev
From: David Miller <davem@davemloft.net>
Date: Wed, 18 Mar 2009 23:10:43 -0700 (PDT)
> From: Roel Kluin <roel.kluin@gmail.com>
> Date: Tue, 17 Mar 2009 11:38:25 +0100
>
> > struct sk_buff pointers should be freed with kfree_skb.
> >
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > ---
> > @@ -2669,11 +2669,11 @@ EXPORT_SYMBOL(netif_napi_add);
> > void netif_napi_del(struct napi_struct *napi)
> > {
>
> Roel, what did you use to generate this patch? :-/
>
> If you hand-edited the patch, please check your work before sending it
> out.
Don't bother resending Roel, I took care of it by hand.
Nobody is doing anything reasonably today, so I am just going
to start doing everything myself like I always seem to end
up doing :-/
Today sucks... so... much...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-19 6:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-17 10:38 [PATCH] kfree(napi->skb) => kfree_skb Roel Kluin
2009-03-19 6:10 ` David Miller
2009-03-19 6:16 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.