* [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.
@ 2009-03-18 21:08 Tao Ma
2009-03-19 6:28 ` Wengang Wang
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Tao Ma @ 2009-03-18 21:08 UTC (permalink / raw)
To: ocfs2-devel
fs/ocfs2/dir.c: In function ?ocfs2_extend_dir?:
fs/ocfs2/dir.c:2700: warning: ?ret? may be used uninitialized in this function
fs/ocfs2/suballoc.c: In function ?ocfs2_get_suballoc_slot_bit?:
fs/ocfs2/suballoc.c:2216: warning: comparison is always true due to limited range of data type
Signed-off-by: Tao Ma <tao.ma@oracle.com>
---
fs/ocfs2/dir.c | 2 +-
fs/ocfs2/suballoc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
index e71160c..eeac241 100644
--- a/fs/ocfs2/dir.c
+++ b/fs/ocfs2/dir.c
@@ -2697,7 +2697,7 @@ static int ocfs2_dx_dir_index_block(struct inode *dir,
u32 *num_dx_entries,
struct buffer_head *dirent_bh)
{
- int ret, namelen, i;
+ int ret = 0, namelen, i;
char *de_buf, *limit;
struct ocfs2_dir_entry *de;
struct buffer_head *dx_leaf_bh;
diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
index b4ca591..eb21dbb 100644
--- a/fs/ocfs2/suballoc.c
+++ b/fs/ocfs2/suballoc.c
@@ -2213,7 +2213,7 @@ static int ocfs2_get_suballoc_slot_bit(struct ocfs2_super *osb, u64 blkno,
goto bail;
}
- if (le16_to_cpu(inode_fe->i_suballoc_slot) != OCFS2_INVALID_SLOT &&
+ if (le16_to_cpu(inode_fe->i_suballoc_slot) != (u16)OCFS2_INVALID_SLOT &&
(u32)le16_to_cpu(inode_fe->i_suballoc_slot) > osb->max_slots - 1) {
mlog(ML_ERROR, "inode %llu has invalid suballoc slot %u\n",
blkno, (u32)le16_to_cpu(inode_fe->i_suballoc_slot));
--
1.6.2.rc2.16.gf474c
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.
2009-03-18 21:08 [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make Tao Ma
@ 2009-03-19 6:28 ` Wengang Wang
2009-03-19 6:31 ` Wengang Wang
2009-03-19 6:42 ` Tao Ma
2009-03-19 22:07 ` Joel Becker
2009-03-20 0:38 ` Mark Fasheh
2 siblings, 2 replies; 9+ messages in thread
From: Wengang Wang @ 2009-03-19 6:28 UTC (permalink / raw)
To: ocfs2-devel
Hi Tao,
I think for the OCFS2_INVALID_SLOT problem,
define OCFS2_INVALID_SLOT as (u16)-1 is better. so that we needn't
force convert type wherever it's used.
--- fs/ocfs2/ocfs2_fs.h 2009-02-18 19:58:02.000000000 +0800
+++ fs/ocfs2/ocfs2_fs.h.1 2009-03-19 14:24:18.000000000 +0800
@@ -303,7 +303,7 @@ struct ocfs2_new_group_input {
#define OCFS2_MAX_SLOTS 255
/* Slot map indicator for an empty slot */
-#define OCFS2_INVALID_SLOT -1
+#define OCFS2_INVALID_SLOT (u16)-1
#define OCFS2_VOL_UUID_LEN 16
#define OCFS2_MAX_VOL_LABEL_LEN 64
I didn't paste the part for removing force type converting.
thanks,
wengang.
Tao Ma wrote:
> fs/ocfs2/dir.c: In function ?ocfs2_extend_dir?:
> fs/ocfs2/dir.c:2700: warning: ?ret? may be used uninitialized in this function
>
> fs/ocfs2/suballoc.c: In function ?ocfs2_get_suballoc_slot_bit?:
> fs/ocfs2/suballoc.c:2216: warning: comparison is always true due to limited range of data type
>
> Signed-off-by: Tao Ma <tao.ma@oracle.com>
> ---
> fs/ocfs2/dir.c | 2 +-
> fs/ocfs2/suballoc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
> index e71160c..eeac241 100644
> --- a/fs/ocfs2/dir.c
> +++ b/fs/ocfs2/dir.c
> @@ -2697,7 +2697,7 @@ static int ocfs2_dx_dir_index_block(struct inode *dir,
> u32 *num_dx_entries,
> struct buffer_head *dirent_bh)
> {
> - int ret, namelen, i;
> + int ret = 0, namelen, i;
> char *de_buf, *limit;
> struct ocfs2_dir_entry *de;
> struct buffer_head *dx_leaf_bh;
> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
> index b4ca591..eb21dbb 100644
> --- a/fs/ocfs2/suballoc.c
> +++ b/fs/ocfs2/suballoc.c
> @@ -2213,7 +2213,7 @@ static int ocfs2_get_suballoc_slot_bit(struct ocfs2_super *osb, u64 blkno,
> goto bail;
> }
>
> - if (le16_to_cpu(inode_fe->i_suballoc_slot) != OCFS2_INVALID_SLOT &&
> + if (le16_to_cpu(inode_fe->i_suballoc_slot) != (u16)OCFS2_INVALID_SLOT &&
> (u32)le16_to_cpu(inode_fe->i_suballoc_slot) > osb->max_slots - 1) {
> mlog(ML_ERROR, "inode %llu has invalid suballoc slot %u\n",
> blkno, (u32)le16_to_cpu(inode_fe->i_suballoc_slot));
^ permalink raw reply [flat|nested] 9+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.
2009-03-19 6:28 ` Wengang Wang
@ 2009-03-19 6:31 ` Wengang Wang
2009-03-19 6:42 ` Tao Ma
1 sibling, 0 replies; 9+ messages in thread
From: Wengang Wang @ 2009-03-19 6:31 UTC (permalink / raw)
To: ocfs2-devel
while, the slot is type of u32 in for functions...
Wengang Wang wrote:
> Hi Tao,
>
> I think for the OCFS2_INVALID_SLOT problem,
> define OCFS2_INVALID_SLOT as (u16)-1 is better. so that we needn't
> force convert type wherever it's used.
>
>
> --- fs/ocfs2/ocfs2_fs.h 2009-02-18 19:58:02.000000000 +0800
> +++ fs/ocfs2/ocfs2_fs.h.1 2009-03-19 14:24:18.000000000 +0800
> @@ -303,7 +303,7 @@ struct ocfs2_new_group_input {
> #define OCFS2_MAX_SLOTS 255
>
> /* Slot map indicator for an empty slot */
> -#define OCFS2_INVALID_SLOT -1
> +#define OCFS2_INVALID_SLOT (u16)-1
>
> #define OCFS2_VOL_UUID_LEN 16
> #define OCFS2_MAX_VOL_LABEL_LEN 64
>
> I didn't paste the part for removing force type converting.
>
> thanks,
> wengang.
>
> Tao Ma wrote:
>> fs/ocfs2/dir.c: In function ?ocfs2_extend_dir?:
>> fs/ocfs2/dir.c:2700: warning: ?ret? may be used uninitialized in this function
>>
>> fs/ocfs2/suballoc.c: In function ?ocfs2_get_suballoc_slot_bit?:
>> fs/ocfs2/suballoc.c:2216: warning: comparison is always true due to limited range of data type
>>
>> Signed-off-by: Tao Ma <tao.ma@oracle.com>
>> ---
>> fs/ocfs2/dir.c | 2 +-
>> fs/ocfs2/suballoc.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
>> index e71160c..eeac241 100644
>> --- a/fs/ocfs2/dir.c
>> +++ b/fs/ocfs2/dir.c
>> @@ -2697,7 +2697,7 @@ static int ocfs2_dx_dir_index_block(struct inode *dir,
>> u32 *num_dx_entries,
>> struct buffer_head *dirent_bh)
>> {
>> - int ret, namelen, i;
>> + int ret = 0, namelen, i;
>> char *de_buf, *limit;
>> struct ocfs2_dir_entry *de;
>> struct buffer_head *dx_leaf_bh;
>> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
>> index b4ca591..eb21dbb 100644
>> --- a/fs/ocfs2/suballoc.c
>> +++ b/fs/ocfs2/suballoc.c
>> @@ -2213,7 +2213,7 @@ static int ocfs2_get_suballoc_slot_bit(struct ocfs2_super *osb, u64 blkno,
>> goto bail;
>> }
>>
>> - if (le16_to_cpu(inode_fe->i_suballoc_slot) != OCFS2_INVALID_SLOT &&
>> + if (le16_to_cpu(inode_fe->i_suballoc_slot) != (u16)OCFS2_INVALID_SLOT &&
>> (u32)le16_to_cpu(inode_fe->i_suballoc_slot) > osb->max_slots - 1) {
>> mlog(ML_ERROR, "inode %llu has invalid suballoc slot %u\n",
>> blkno, (u32)le16_to_cpu(inode_fe->i_suballoc_slot));
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
^ permalink raw reply [flat|nested] 9+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.
2009-03-19 6:28 ` Wengang Wang
2009-03-19 6:31 ` Wengang Wang
@ 2009-03-19 6:42 ` Tao Ma
2009-03-19 6:47 ` Wengang Wang
1 sibling, 1 reply; 9+ messages in thread
From: Tao Ma @ 2009-03-19 6:42 UTC (permalink / raw)
To: ocfs2-devel
Hi wengang,
Wengang Wang wrote:
> Hi Tao,
>
> I think for the OCFS2_INVALID_SLOT problem,
> define OCFS2_INVALID_SLOT as (u16)-1 is better. so that we needn't
> force convert type wherever it's used.
I just copy/paste and do like others. See
fs/ocfs2/slot_map.c: if (le16_to_cpu(sm->sm_slots[i]) ==
(u16)OCFS2_INVALID_SLOT)
And after I searched again, I guess we can't do that. look at
fs/ocfs2/super.c.
osb->slot_num = OCFS2_INVALID_SLOT;
slot_num is defined as int. So your definition will break the rule. and
make slot_num=65535.
Regards,
Tao
>
>
> --- fs/ocfs2/ocfs2_fs.h 2009-02-18 19:58:02.000000000 +0800
> +++ fs/ocfs2/ocfs2_fs.h.1 2009-03-19 14:24:18.000000000 +0800
> @@ -303,7 +303,7 @@ struct ocfs2_new_group_input {
> #define OCFS2_MAX_SLOTS 255
>
> /* Slot map indicator for an empty slot */
> -#define OCFS2_INVALID_SLOT -1
> +#define OCFS2_INVALID_SLOT (u16)-1
>
> #define OCFS2_VOL_UUID_LEN 16
> #define OCFS2_MAX_VOL_LABEL_LEN 64
>
> I didn't paste the part for removing force type converting.
>
> thanks,
> wengang.
>
> Tao Ma wrote:
>> fs/ocfs2/dir.c: In function ?ocfs2_extend_dir?:
>> fs/ocfs2/dir.c:2700: warning: ?ret? may be used uninitialized in this
>> function
>>
>> fs/ocfs2/suballoc.c: In function ?ocfs2_get_suballoc_slot_bit?:
>> fs/ocfs2/suballoc.c:2216: warning: comparison is always true due to
>> limited range of data type
>>
>> Signed-off-by: Tao Ma <tao.ma@oracle.com>
>> ---
>> fs/ocfs2/dir.c | 2 +-
>> fs/ocfs2/suballoc.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
>> index e71160c..eeac241 100644
>> --- a/fs/ocfs2/dir.c
>> +++ b/fs/ocfs2/dir.c
>> @@ -2697,7 +2697,7 @@ static int ocfs2_dx_dir_index_block(struct inode
>> *dir,
>> u32 *num_dx_entries,
>> struct buffer_head *dirent_bh)
>> {
>> - int ret, namelen, i;
>> + int ret = 0, namelen, i;
>> char *de_buf, *limit;
>> struct ocfs2_dir_entry *de;
>> struct buffer_head *dx_leaf_bh;
>> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
>> index b4ca591..eb21dbb 100644
>> --- a/fs/ocfs2/suballoc.c
>> +++ b/fs/ocfs2/suballoc.c
>> @@ -2213,7 +2213,7 @@ static int ocfs2_get_suballoc_slot_bit(struct
>> ocfs2_super *osb, u64 blkno,
>> goto bail;
>> }
>>
>> - if (le16_to_cpu(inode_fe->i_suballoc_slot) != OCFS2_INVALID_SLOT &&
>> + if (le16_to_cpu(inode_fe->i_suballoc_slot) !=
>> (u16)OCFS2_INVALID_SLOT &&
>> (u32)le16_to_cpu(inode_fe->i_suballoc_slot) > osb->max_slots
>> - 1) {
>> mlog(ML_ERROR, "inode %llu has invalid suballoc slot %u\n",
>> blkno, (u32)le16_to_cpu(inode_fe->i_suballoc_slot));
^ permalink raw reply [flat|nested] 9+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.
2009-03-19 6:42 ` Tao Ma
@ 2009-03-19 6:47 ` Wengang Wang
2009-03-19 22:06 ` Joel Becker
0 siblings, 1 reply; 9+ messages in thread
From: Wengang Wang @ 2009-03-19 6:47 UTC (permalink / raw)
To: ocfs2-devel
yes, that's the problem.
we'd better unify the different types(but could be another patch).
since the on disk is u16, modifying other types to u16 is fine :)
thanks,
wengang.
Tao Ma wrote:
> Hi wengang,
>
> Wengang Wang wrote:
>> Hi Tao,
>>
>> I think for the OCFS2_INVALID_SLOT problem,
>> define OCFS2_INVALID_SLOT as (u16)-1 is better. so that we needn't
>> force convert type wherever it's used.
> I just copy/paste and do like others. See
> fs/ocfs2/slot_map.c: if (le16_to_cpu(sm->sm_slots[i]) ==
> (u16)OCFS2_INVALID_SLOT)
>
> And after I searched again, I guess we can't do that. look at
> fs/ocfs2/super.c.
> osb->slot_num = OCFS2_INVALID_SLOT;
> slot_num is defined as int. So your definition will break the rule. and
> make slot_num=65535.
>
> Regards,
> Tao
>>
>>
>> --- fs/ocfs2/ocfs2_fs.h 2009-02-18 19:58:02.000000000 +0800
>> +++ fs/ocfs2/ocfs2_fs.h.1 2009-03-19 14:24:18.000000000 +0800
>> @@ -303,7 +303,7 @@ struct ocfs2_new_group_input {
>> #define OCFS2_MAX_SLOTS 255
>>
>> /* Slot map indicator for an empty slot */
>> -#define OCFS2_INVALID_SLOT -1
>> +#define OCFS2_INVALID_SLOT (u16)-1
>>
>> #define OCFS2_VOL_UUID_LEN 16
>> #define OCFS2_MAX_VOL_LABEL_LEN 64
>>
>> I didn't paste the part for removing force type converting.
>>
>> thanks,
>> wengang.
>>
>> Tao Ma wrote:
>>> fs/ocfs2/dir.c: In function ?ocfs2_extend_dir?:
>>> fs/ocfs2/dir.c:2700: warning: ?ret? may be used uninitialized in this
>>> function
>>>
>>> fs/ocfs2/suballoc.c: In function ?ocfs2_get_suballoc_slot_bit?:
>>> fs/ocfs2/suballoc.c:2216: warning: comparison is always true due to
>>> limited range of data type
>>>
>>> Signed-off-by: Tao Ma <tao.ma@oracle.com>
>>> ---
>>> fs/ocfs2/dir.c | 2 +-
>>> fs/ocfs2/suballoc.c | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
>>> index e71160c..eeac241 100644
>>> --- a/fs/ocfs2/dir.c
>>> +++ b/fs/ocfs2/dir.c
>>> @@ -2697,7 +2697,7 @@ static int ocfs2_dx_dir_index_block(struct
>>> inode *dir,
>>> u32 *num_dx_entries,
>>> struct buffer_head *dirent_bh)
>>> {
>>> - int ret, namelen, i;
>>> + int ret = 0, namelen, i;
>>> char *de_buf, *limit;
>>> struct ocfs2_dir_entry *de;
>>> struct buffer_head *dx_leaf_bh;
>>> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
>>> index b4ca591..eb21dbb 100644
>>> --- a/fs/ocfs2/suballoc.c
>>> +++ b/fs/ocfs2/suballoc.c
>>> @@ -2213,7 +2213,7 @@ static int ocfs2_get_suballoc_slot_bit(struct
>>> ocfs2_super *osb, u64 blkno,
>>> goto bail;
>>> }
>>>
>>> - if (le16_to_cpu(inode_fe->i_suballoc_slot) != OCFS2_INVALID_SLOT &&
>>> + if (le16_to_cpu(inode_fe->i_suballoc_slot) !=
>>> (u16)OCFS2_INVALID_SLOT &&
>>> (u32)le16_to_cpu(inode_fe->i_suballoc_slot) > osb->max_slots
>>> - 1) {
>>> mlog(ML_ERROR, "inode %llu has invalid suballoc slot %u\n",
>>> blkno, (u32)le16_to_cpu(inode_fe->i_suballoc_slot));
^ permalink raw reply [flat|nested] 9+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.
2009-03-19 6:47 ` Wengang Wang
@ 2009-03-19 22:06 ` Joel Becker
0 siblings, 0 replies; 9+ messages in thread
From: Joel Becker @ 2009-03-19 22:06 UTC (permalink / raw)
To: ocfs2-devel
On Thu, Mar 19, 2009 at 02:47:44PM +0800, Wengang Wang wrote:
> yes, that's the problem.
> we'd better unify the different types(but could be another patch).
> since the on disk is u16, modifying other types to u16 is fine :)
The -1 is a special value, and it isn't always a u16 we're
talking about. This is both historical code and on-disk values.
INVALID_SLOT isn't 65535, it's -1. You have to have the comparisons as
they currently stand, with the casts.
Joel
--
"Any man who is under 30, and is not a liberal, has not heart;
and any man who is over 30, and is not a conservative, has no brains."
- Sir Winston Churchill
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.
2009-03-18 21:08 [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make Tao Ma
2009-03-19 6:28 ` Wengang Wang
@ 2009-03-19 22:07 ` Joel Becker
2009-03-20 0:38 ` Mark Fasheh
2 siblings, 0 replies; 9+ messages in thread
From: Joel Becker @ 2009-03-19 22:07 UTC (permalink / raw)
To: ocfs2-devel
On Thu, Mar 19, 2009 at 05:08:43AM +0800, Tao Ma wrote:
> fs/ocfs2/dir.c: In function ?ocfs2_extend_dir?:
> fs/ocfs2/dir.c:2700: warning: ?ret? may be used uninitialized in this function
>
> fs/ocfs2/suballoc.c: In function ?ocfs2_get_suballoc_slot_bit?:
> fs/ocfs2/suballoc.c:2216: warning: comparison is always true due to limited range of data type
>
> Signed-off-by: Tao Ma <tao.ma@oracle.com>
Good catch. Both are bugs, and both are correctly fixed.
Acked-by: Joel Becker <joel.becker@oracle.com>
> ---
> fs/ocfs2/dir.c | 2 +-
> fs/ocfs2/suballoc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
> index e71160c..eeac241 100644
> --- a/fs/ocfs2/dir.c
> +++ b/fs/ocfs2/dir.c
> @@ -2697,7 +2697,7 @@ static int ocfs2_dx_dir_index_block(struct inode *dir,
> u32 *num_dx_entries,
> struct buffer_head *dirent_bh)
> {
> - int ret, namelen, i;
> + int ret = 0, namelen, i;
> char *de_buf, *limit;
> struct ocfs2_dir_entry *de;
> struct buffer_head *dx_leaf_bh;
> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
> index b4ca591..eb21dbb 100644
> --- a/fs/ocfs2/suballoc.c
> +++ b/fs/ocfs2/suballoc.c
> @@ -2213,7 +2213,7 @@ static int ocfs2_get_suballoc_slot_bit(struct ocfs2_super *osb, u64 blkno,
> goto bail;
> }
>
> - if (le16_to_cpu(inode_fe->i_suballoc_slot) != OCFS2_INVALID_SLOT &&
> + if (le16_to_cpu(inode_fe->i_suballoc_slot) != (u16)OCFS2_INVALID_SLOT &&
> (u32)le16_to_cpu(inode_fe->i_suballoc_slot) > osb->max_slots - 1) {
> mlog(ML_ERROR, "inode %llu has invalid suballoc slot %u\n",
> blkno, (u32)le16_to_cpu(inode_fe->i_suballoc_slot));
> --
> 1.6.2.rc2.16.gf474c
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
--
Pitchers and catchers report.
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 9+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.
2009-03-18 21:08 [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make Tao Ma
2009-03-19 6:28 ` Wengang Wang
2009-03-19 22:07 ` Joel Becker
@ 2009-03-20 0:38 ` Mark Fasheh
2009-03-20 0:45 ` Tao Ma
2 siblings, 1 reply; 9+ messages in thread
From: Mark Fasheh @ 2009-03-20 0:38 UTC (permalink / raw)
To: ocfs2-devel
On Thu, Mar 19, 2009 at 05:08:43AM +0800, Tao Ma wrote:
> fs/ocfs2/dir.c: In function ?ocfs2_extend_dir?:
> fs/ocfs2/dir.c:2700: warning: ?ret? may be used uninitialized in this function
>
> fs/ocfs2/suballoc.c: In function ?ocfs2_get_suballoc_slot_bit?:
> fs/ocfs2/suballoc.c:2216: warning: comparison is always true due to limited range of data type
Does the 2nd bug still exist in merge_window? I didn't see it, so I just
merged the 1st one into merge_window.
--Mark
--
Mark Fasheh
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.
2009-03-20 0:38 ` Mark Fasheh
@ 2009-03-20 0:45 ` Tao Ma
0 siblings, 0 replies; 9+ messages in thread
From: Tao Ma @ 2009-03-20 0:45 UTC (permalink / raw)
To: ocfs2-devel
Hi Mark,
I saw this in your upstream-merge_window. And I compared it with your
merge_window, the upstream one has more patches than the other, it looks
like the branch you mentioned in "Ocfs2 updates for 2.6.30". The bug is
found there.
Regards,
Tao
Mark Fasheh wrote:
> On Thu, Mar 19, 2009 at 05:08:43AM +0800, Tao Ma wrote:
>> fs/ocfs2/dir.c: In function ?ocfs2_extend_dir?:
>> fs/ocfs2/dir.c:2700: warning: ?ret? may be used uninitialized in this function
>>
>> fs/ocfs2/suballoc.c: In function ?ocfs2_get_suballoc_slot_bit?:
>> fs/ocfs2/suballoc.c:2216: warning: comparison is always true due to limited range of data type
>
> Does the 2nd bug still exist in merge_window? I didn't see it, so I just
> merged the 1st one into merge_window.
> --Mark
>
>
> --
> Mark Fasheh
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-03-20 0:45 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-18 21:08 [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make Tao Ma
2009-03-19 6:28 ` Wengang Wang
2009-03-19 6:31 ` Wengang Wang
2009-03-19 6:42 ` Tao Ma
2009-03-19 6:47 ` Wengang Wang
2009-03-19 22:06 ` Joel Becker
2009-03-19 22:07 ` Joel Becker
2009-03-20 0:38 ` Mark Fasheh
2009-03-20 0:45 ` Tao Ma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.