* [PATCH] Documentation/git-filter-branch.txt: Remove unnecessary URL quoting
@ 2009-03-19 23:12 Johan Herland
2009-03-20 15:19 ` Thomas Rast
0 siblings, 1 reply; 3+ messages in thread
From: Johan Herland @ 2009-03-19 23:12 UTC (permalink / raw)
To: Junio C Hamano, git; +Cc: Thomas Rast
Embedding the URL in '+++' causes AsciiDoc (v8.4.1) to generate invalid XML.
None of the other URLs in Git's documentation are quoted in this manner.
There's no reason to treat this URL differently.
Signed-off-by: Johan Herland <johan@herland.net>
---
Documentation/git-filter-branch.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
index 237f85e..64b99d7 100644
--- a/Documentation/git-filter-branch.txt
+++ b/Documentation/git-filter-branch.txt
@@ -361,7 +361,7 @@ objects until you tell it to. First make sure that:
Then there are two ways to get a smaller repository. A safer way is
to clone, that keeps your original intact.
-* Clone it with `git clone +++file:///path/to/repo+++`. The clone
+* Clone it with `git clone file:///path/to/repo`. The clone
will not have the removed objects. See linkgit:git-clone[1]. (Note
that cloning with a plain path just hardlinks everything!)
--
1.6.2.1.352.gae594.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation/git-filter-branch.txt: Remove unnecessary URL quoting
2009-03-19 23:12 [PATCH] Documentation/git-filter-branch.txt: Remove unnecessary URL quoting Johan Herland
@ 2009-03-20 15:19 ` Thomas Rast
2009-03-22 23:20 ` Johan Herland
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Rast @ 2009-03-20 15:19 UTC (permalink / raw)
To: Johan Herland; +Cc: Junio C Hamano, git
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
Johan Herland wrote:
> Embedding the URL in '+++' causes AsciiDoc (v8.4.1) to generate invalid XML.
> None of the other URLs in Git's documentation are quoted in this manner.
> There's no reason to treat this URL differently.
>
> Signed-off-by: Johan Herland <johan@herland.net>
[...]
> -* Clone it with `git clone +++file:///path/to/repo+++`. The clone
> +* Clone it with `git clone file:///path/to/repo`. The clone
I deliberately wrote it that way because *not* quoting it, at least on
my box, formats the entire paragraph in monospace. Apparently it
treats the ` as part of an autodetected URL or some such. This is
independent of my choice of ASCIIDOC8 or DOCBOOK_XSL_172 settings. Am
I missing another flag that avoids this problem?
I have these packages installed from opensuse:
asciidoc-8.2.7-29.10
docbook_4-4.5-111.8
docbook-xsl-stylesheets-1.74.0-1.35
--
Thomas Rast
trast@{inf,student}.ethz.ch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation/git-filter-branch.txt: Remove unnecessary URL quoting
2009-03-20 15:19 ` Thomas Rast
@ 2009-03-22 23:20 ` Johan Herland
0 siblings, 0 replies; 3+ messages in thread
From: Johan Herland @ 2009-03-22 23:20 UTC (permalink / raw)
To: Thomas Rast; +Cc: Junio C Hamano, git
On Friday 20 March 2009, Thomas Rast wrote:
> Johan Herland wrote:
> > Embedding the URL in '+++' causes AsciiDoc (v8.4.1) to generate invalid
> > XML. None of the other URLs in Git's documentation are quoted in this
> > manner. There's no reason to treat this URL differently.
>
> [...]
>
> > -* Clone it with `git clone +++file:///path/to/repo+++`. The clone
> > +* Clone it with `git clone file:///path/to/repo`. The clone
>
> I deliberately wrote it that way because *not* quoting it, at least on
> my box, formats the entire paragraph in monospace. Apparently it
> treats the ` as part of an autodetected URL or some such. This is
> independent of my choice of ASCIIDOC8 or DOCBOOK_XSL_172 settings. Am
> I missing another flag that avoids this problem?
No, I think this is due to version differences in AsciiDoc.
> I have these packages installed from opensuse:
> asciidoc-8.2.7-29.10
I use AsciiDoc v8.4.1 (from Arch Linux), and according to
http://www.methods.co.nz/asciidoc/CHANGELOG.html there are some regression
issues regarding backtick quoting and "inline literal passthrough"s when
upgrading to v8.4.1. According to the changelog I should be able to revert
AsciiDoc to the old behaviour by putting
[attributes]
no-inline-literal=
in my Documentation/asciidoc.conf. However, with this in place, I _still_
get invalid XML generated for git-filter-branch.txt... :(
So, it seems to be an AsciiDoc versioning issue. I'm not sure which of these
AsciiDoc versions are preferable, of if it is possible to format the text in
such a manner that it'll work in both versions.
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-22 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-19 23:12 [PATCH] Documentation/git-filter-branch.txt: Remove unnecessary URL quoting Johan Herland
2009-03-20 15:19 ` Thomas Rast
2009-03-22 23:20 ` Johan Herland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.