* [Patch 1/1] Fix compiler warning.
@ 2009-04-01 19:05 Robin Holt
2009-04-01 19:15 ` Sam Ravnborg
0 siblings, 1 reply; 4+ messages in thread
From: Robin Holt @ 2009-04-01 19:05 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Fix a minor compile warning when building on ia64.
Signed-off-by: Robin Holt <holt@sgi.com>
---
drivers/misc/sgi-xp/xpc_sn2.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Index: 20090401-ia64-xpc-no-gru/drivers/misc/sgi-xp/xpc_sn2.c
===================================================================
--- 20090401-ia64-xpc-no-gru.orig/drivers/misc/sgi-xp/xpc_sn2.c 2009-04-01 10:50:19.000000000 -0500
+++ 20090401-ia64-xpc-no-gru/drivers/misc/sgi-xp/xpc_sn2.c 2009-04-01 11:27:42.005011690 -0500
@@ -1737,20 +1737,20 @@ xpc_clear_remote_msgqueue_flags_sn2(stru
{
struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
struct xpc_msg_sn2 *msg;
- s64 put;
+ s64 put, remote_nentries = ch->remote_nentries;
/* flags are zeroed when the buffer is allocated */
- if (ch_sn2->remote_GP.put < ch->remote_nentries)
+ if (ch_sn2->remote_GP.put < remote_nentries)
return;
- put = max(ch_sn2->w_remote_GP.put, ch->remote_nentries);
+ put = max(ch_sn2->w_remote_GP.put, remote_nentries);
do {
msg = (struct xpc_msg_sn2 *)((u64)ch_sn2->remote_msgqueue +
- (put % ch->remote_nentries) *
+ (put % remote_nentries) *
ch->entry_size);
DBUG_ON(!(msg->flags & XPC_M_SN2_READY));
DBUG_ON(!(msg->flags & XPC_M_SN2_DONE));
- DBUG_ON(msg->number != put - ch->remote_nentries);
+ DBUG_ON(msg->number != put - remote_nentries);
msg->flags = 0;
} while (++put < ch_sn2->remote_GP.put);
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Patch 1/1] Fix compiler warning.
2009-04-01 19:05 [Patch 1/1] Fix compiler warning Robin Holt
@ 2009-04-01 19:15 ` Sam Ravnborg
2009-04-01 19:19 ` Andrew Morton
2009-04-01 19:20 ` [Patch 1/1] xpc_sn2: fix max() warning about pointers of different types Robin Holt
0 siblings, 2 replies; 4+ messages in thread
From: Sam Ravnborg @ 2009-04-01 19:15 UTC (permalink / raw)
To: Robin Holt; +Cc: Andrew Morton, linux-kernel
On Wed, Apr 01, 2009 at 02:05:56PM -0500, Robin Holt wrote:
> Fix a minor compile warning when building on ia64.
>
> Signed-off-by: Robin Holt <holt@sgi.com>
Can you please include the warning in the changelog.
And a more descriptive subject would be nice.
Something like:
xpc_sn2: fix warning
You usual do so - so I assume this was just an oversight.
Sam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch 1/1] Fix compiler warning.
2009-04-01 19:15 ` Sam Ravnborg
@ 2009-04-01 19:19 ` Andrew Morton
2009-04-01 19:20 ` [Patch 1/1] xpc_sn2: fix max() warning about pointers of different types Robin Holt
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2009-04-01 19:19 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: holt, linux-kernel
On Wed, 1 Apr 2009 21:15:37 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> On Wed, Apr 01, 2009 at 02:05:56PM -0500, Robin Holt wrote:
> > Fix a minor compile warning when building on ia64.
> >
> > Signed-off-by: Robin Holt <holt@sgi.com>
>
> Can you please include the warning in the changelog.
yup.
> And a more descriptive subject would be nice.
> Something like:
>
> xpc_sn2: fix warning
I routinely rewrite titles in that form. Probably about a third of the
time.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Patch 1/1] xpc_sn2: fix max() warning about pointers of different types.
2009-04-01 19:15 ` Sam Ravnborg
2009-04-01 19:19 ` Andrew Morton
@ 2009-04-01 19:20 ` Robin Holt
1 sibling, 0 replies; 4+ messages in thread
From: Robin Holt @ 2009-04-01 19:20 UTC (permalink / raw)
To: Andrew Morton; +Cc: Sam Ravnborg, linux-kernel
Fix a minor compile warning when building on ia64.
drivers/misc/sgi-xp/xpc_sn2.c: In function ‘xpc_clear_remote_msgqueue_flags_sn2’:
drivers/misc/sgi-xp/xpc_sn2.c:1746: warning: comparison of distinct pointer types lacks a cast
Signed-off-by: Robin Holt <holt@sgi.com>
---
drivers/misc/sgi-xp/xpc_sn2.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Index: 20090401-ia64-xpc-no-gru/drivers/misc/sgi-xp/xpc_sn2.c
===================================================================
--- 20090401-ia64-xpc-no-gru.orig/drivers/misc/sgi-xp/xpc_sn2.c 2009-04-01 10:50:19.000000000 -0500
+++ 20090401-ia64-xpc-no-gru/drivers/misc/sgi-xp/xpc_sn2.c 2009-04-01 11:27:42.005011690 -0500
@@ -1737,20 +1737,20 @@ xpc_clear_remote_msgqueue_flags_sn2(stru
{
struct xpc_channel_sn2 *ch_sn2 = &ch->sn.sn2;
struct xpc_msg_sn2 *msg;
- s64 put;
+ s64 put, remote_nentries = ch->remote_nentries;
/* flags are zeroed when the buffer is allocated */
- if (ch_sn2->remote_GP.put < ch->remote_nentries)
+ if (ch_sn2->remote_GP.put < remote_nentries)
return;
- put = max(ch_sn2->w_remote_GP.put, ch->remote_nentries);
+ put = max(ch_sn2->w_remote_GP.put, remote_nentries);
do {
msg = (struct xpc_msg_sn2 *)((u64)ch_sn2->remote_msgqueue +
- (put % ch->remote_nentries) *
+ (put % remote_nentries) *
ch->entry_size);
DBUG_ON(!(msg->flags & XPC_M_SN2_READY));
DBUG_ON(!(msg->flags & XPC_M_SN2_DONE));
- DBUG_ON(msg->number != put - ch->remote_nentries);
+ DBUG_ON(msg->number != put - remote_nentries);
msg->flags = 0;
} while (++put < ch_sn2->remote_GP.put);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-01 19:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-01 19:05 [Patch 1/1] Fix compiler warning Robin Holt
2009-04-01 19:15 ` Sam Ravnborg
2009-04-01 19:19 ` Andrew Morton
2009-04-01 19:20 ` [Patch 1/1] xpc_sn2: fix max() warning about pointers of different types Robin Holt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.