* [PATCH 0/3] Fix rt28{6,7}0sta to use firmware loader @ 2009-04-13 2:33 Ben Hutchings 2009-04-13 2:44 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Ben Hutchings @ 2009-04-13 2:33 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: linux-kernel, David Woodhouse, Darren Salt [-- Attachment #1: Type: text/plain, Size: 1696 bytes --] Greg, The Ralink drivers rt2860sta, rt2870sta and rt3070sta contain non-free firmware which should be distributed separately. Darren Salt wrote a patch for Debian for rt2860sta which I've cleaned up slightly. At my suggestion he also extended the ITU-T CRC code to support this, allowing the copy in rt2860sta to be removed. I have duplicated and adapted the rt2860sta for rt2870sta, but this last patch is untested. rt3070sta remains unfixed. So far as I can see, rt3070sta is a later version of rt2870sta and should be merged with it rather than requiring people to apply the same fixes twice. Since Debian has never enabled this driver in its kernel packages I have simply removed the firmware and marked it as broken in our kernel source. Ben. Ben Hutchings (2): rt2860sta: use the firmware loader interface and library CRC code rt2870sta: use the firmware loader interface and library CRC code Darren Salt (1): crc-itu-t: add bit-reversed calculation drivers/staging/rt2860/Kconfig | 2 + drivers/staging/rt2860/common/firmware.h | 558 ----------------------------- drivers/staging/rt2860/common/rtmp_init.c | 309 ++++------------- drivers/staging/rt2870/Kconfig | 2 + drivers/staging/rt2870/common/firmware.h | 558 ----------------------------- drivers/staging/rt2870/common/rtmp_init.c | 385 ++++---------------- include/linux/crc-itu-t.h | 10 + lib/crc-itu-t.c | 18 + 8 files changed, 168 insertions(+), 1674 deletions(-) delete mode 100644 drivers/staging/rt2860/common/firmware.h delete mode 100644 drivers/staging/rt2870/common/firmware.h [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] Fix rt28{6,7}0sta to use firmware loader 2009-04-13 2:33 [PATCH 0/3] Fix rt28{6,7}0sta to use firmware loader Ben Hutchings @ 2009-04-13 2:44 ` Greg KH 2009-04-14 0:12 ` Ben Hutchings 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2009-04-13 2:44 UTC (permalink / raw) To: Ben Hutchings; +Cc: linux-kernel, David Woodhouse, Darren Salt On Mon, Apr 13, 2009 at 03:33:12AM +0100, Ben Hutchings wrote: > Greg, > > The Ralink drivers rt2860sta, rt2870sta and rt3070sta contain non-free > firmware which should be distributed separately. Where is it now distributed? I don't want to break people's machines that were working before this patch is applied. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] Fix rt28{6,7}0sta to use firmware loader 2009-04-13 2:44 ` Greg KH @ 2009-04-14 0:12 ` Ben Hutchings 2009-04-14 2:24 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Ben Hutchings @ 2009-04-14 0:12 UTC (permalink / raw) To: Greg KH; +Cc: linux-kernel, David Woodhouse, Darren Salt [-- Attachment #1: Type: text/plain, Size: 746 bytes --] On Sun, 2009-04-12 at 19:44 -0700, Greg KH wrote: > On Mon, Apr 13, 2009 at 03:33:12AM +0100, Ben Hutchings wrote: > > Greg, > > > > The Ralink drivers rt2860sta, rt2870sta and rt3070sta contain non-free > > firmware which should be distributed separately. > > Where is it now distributed? I don't want to break people's machines > that were working before this patch is applied. The canonical source is <http://www.ralinktech.com/ralink/Home/Support/Linux.html> The files are now also in the Debian repository for our firmware-nonfree package and in <http://git.decadent.org.uk/git/linux-firmware.git>. I've asked David Woodhouse to pull from that into his linux-firmware.git so that they get into other distros. Ben. [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] Fix rt28{6,7}0sta to use firmware loader 2009-04-14 0:12 ` Ben Hutchings @ 2009-04-14 2:24 ` Greg KH 2009-04-20 10:19 ` David Woodhouse 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2009-04-14 2:24 UTC (permalink / raw) To: Ben Hutchings; +Cc: linux-kernel, David Woodhouse, Darren Salt On Tue, Apr 14, 2009 at 01:12:41AM +0100, Ben Hutchings wrote: > On Sun, 2009-04-12 at 19:44 -0700, Greg KH wrote: > > On Mon, Apr 13, 2009 at 03:33:12AM +0100, Ben Hutchings wrote: > > > Greg, > > > > > > The Ralink drivers rt2860sta, rt2870sta and rt3070sta contain non-free > > > firmware which should be distributed separately. > > > > Where is it now distributed? I don't want to break people's machines > > that were working before this patch is applied. > > The canonical source is > <http://www.ralinktech.com/ralink/Home/Support/Linux.html> Yes, and that is where I got the code that is in the driver tree that you are objecting to now :) > The files are now also in the Debian repository for our firmware-nonfree > package and in <http://git.decadent.org.uk/git/linux-firmware.git>. > I've asked David Woodhouse to pull from that into his linux-firmware.git > so that they get into other distros. When David pulls it into his tree, and does a release, please let me know and I'll be glad to accept your patch. Until then, I can't accept this patch as it would break people's machines that were previously working. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] Fix rt28{6,7}0sta to use firmware loader 2009-04-14 2:24 ` Greg KH @ 2009-04-20 10:19 ` David Woodhouse 2009-04-22 23:13 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: David Woodhouse @ 2009-04-20 10:19 UTC (permalink / raw) To: Greg KH; +Cc: Ben Hutchings, linux-kernel, Darren Salt On Mon, 2009-04-13 at 19:24 -0700, Greg KH wrote: > On Tue, Apr 14, 2009 at 01:12:41AM +0100, Ben Hutchings wrote: > > On Sun, 2009-04-12 at 19:44 -0700, Greg KH wrote: > > > On Mon, Apr 13, 2009 at 03:33:12AM +0100, Ben Hutchings wrote: > > > > Greg, > > > > > > > > The Ralink drivers rt2860sta, rt2870sta and rt3070sta contain non-free > > > > firmware which should be distributed separately. > > > > > > Where is it now distributed? I don't want to break people's machines > > > that were working before this patch is applied. > > > > The canonical source is > > <http://www.ralinktech.com/ralink/Home/Support/Linux.html> > > Yes, and that is where I got the code that is in the driver tree that > you are objecting to now :) You shouldn't have done. We stopped including firmware for new wireless drivers _years_ ago. It's perfectly normal that users are expected to fetch the firmware separately (or their distribution does it for them). > > The files are now also in the Debian repository for our firmware-nonfree > > package and in <http://git.decadent.org.uk/git/linux-firmware.git>. > > I've asked David Woodhouse to pull from that into his linux-firmware.git > > so that they get into other distros. I'd be a lot happier with that having a signed-off-by from within Ralink, even though the licence is unambiguous. But I've pulled it anyway, this time. You can download the 'release' at http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=snapshot;h=HEAD (Still haven't really worked out what the best strategy for 'releases' is, given that people should just be using the latest version from the tree. Maybe an automatic git-archive from cron each day, if something's change from the previous day?) -- dwmw2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] Fix rt28{6,7}0sta to use firmware loader 2009-04-20 10:19 ` David Woodhouse @ 2009-04-22 23:13 ` Greg KH 0 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2009-04-22 23:13 UTC (permalink / raw) To: David Woodhouse; +Cc: Ben Hutchings, linux-kernel, Darren Salt On Mon, Apr 20, 2009 at 11:19:06AM +0100, David Woodhouse wrote: > On Mon, 2009-04-13 at 19:24 -0700, Greg KH wrote: > > On Tue, Apr 14, 2009 at 01:12:41AM +0100, Ben Hutchings wrote: > > > On Sun, 2009-04-12 at 19:44 -0700, Greg KH wrote: > > > > On Mon, Apr 13, 2009 at 03:33:12AM +0100, Ben Hutchings wrote: > > > > > Greg, > > > > > > > > > > The Ralink drivers rt2860sta, rt2870sta and rt3070sta contain non-free > > > > > firmware which should be distributed separately. > > > > > > > > Where is it now distributed? I don't want to break people's machines > > > > that were working before this patch is applied. > > > > > > The canonical source is > > > <http://www.ralinktech.com/ralink/Home/Support/Linux.html> > > > > Yes, and that is where I got the code that is in the driver tree that > > you are objecting to now :) > > You shouldn't have done. We stopped including firmware for new wireless > drivers _years_ ago. It's perfectly normal that users are expected to > fetch the firmware separately (or their distribution does it for them). Sorry, I should have added it to your tree in the beginning. > > > The files are now also in the Debian repository for our firmware-nonfree > > > package and in <http://git.decadent.org.uk/git/linux-firmware.git>. > > > I've asked David Woodhouse to pull from that into his linux-firmware.git > > > so that they get into other distros. > > I'd be a lot happier with that having a signed-off-by from within > Ralink, even though the licence is unambiguous. But I've pulled it > anyway, this time. You can download the 'release' at > http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=snapshot;h=HEAD Nice, thanks for doing this. > (Still haven't really worked out what the best strategy for 'releases' > is, given that people should just be using the latest version from the > tree. Maybe an automatic git-archive from cron each day, if something's > change from the previous day?) Yes, that would be a good idea. And a way to send an email to people who are packaging this up for distros to know and go update them would be good as well. I have a firmware package now in the Gentoo tree, and am working on making the SuSE one public (it's right now buried behind the firewall, but will be pushed out soon.) thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-04-22 23:22 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2009-04-13 2:33 [PATCH 0/3] Fix rt28{6,7}0sta to use firmware loader Ben Hutchings 2009-04-13 2:44 ` Greg KH 2009-04-14 0:12 ` Ben Hutchings 2009-04-14 2:24 ` Greg KH 2009-04-20 10:19 ` David Woodhouse 2009-04-22 23:13 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.