All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@caiaq.de>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: alsa-devel@alsa-project.org, Paul Shen <bshen9@marvell.com>,
	linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
	Philipp Zabel <philipp.zabel@gmail.com>,
	Mark Brown <broonie@sirena.org.uk>
Subject: Re: [RFC PATCH 4/5] ASoC: remove those unnecessary	#ifdef CONFIG_PXA3xx .. #endif
Date: Thu, 23 Apr 2009 09:08:15 +0200	[thread overview]
Message-ID: <20090423070815.GB23901@buzzloop.caiaq.de> (raw)
In-Reply-To: <f17812d70904222206h27c58e40t5c8383133df1a7d0@mail.gmail.com>

Hi Eric,

On Thu, Apr 23, 2009 at 01:06:55PM +0800, Eric Miao wrote:
> @@ -652,10 +643,8 @@ static int pxa_ssp_hw_params(struct
> snd_pcm_substream *substream,
>  	sscr0 = ssp_read_reg(ssp, SSCR0);
>  	switch (params_format(params)) {
>  	case SNDRV_PCM_FORMAT_S16_LE:
> -#ifdef CONFIG_PXA3xx
>  		if (cpu_is_pxa3xx())
>  			sscr0 |= SSCR0_FPCKE;
> -#endif
>  		sscr0 |= SSCR0_DataSize(16);
>  		break;
>  	case SNDRV_PCM_FORMAT_S24_LE:
> @@ -682,7 +671,6 @@ static int pxa_ssp_hw_params(struct
> snd_pcm_substream *substream,
>  			* needed for that mode are only available on PXA3xx.
>  			*/
> 
> -#ifdef CONFIG_PXA3xx
>  			if (!cpu_is_pxa3xx())
>  				return -EINVAL;
> 
> @@ -691,9 +679,6 @@ static int pxa_ssp_hw_params(struct
> snd_pcm_substream *substream,
>  			sspsp |= SSPSP_EDMYSTOP(3);
>  			sspsp |= SSPSP_DMYSTOP(3);
>  			sspsp |= SSPSP_DMYSTRT(1);

These macros are only defined for PXA3xx since the register bits are not
used on other PXAs. Hence, the usage of these macros must be conditional
as well. Was this ever compiled for PXA2xx?

Daniel

  reply	other threads:[~2009-04-23  7:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23  5:06 [RFC PATCH 4/5] ASoC: remove those unnecessary #ifdef CONFIG_PXA3xx .. #endif Eric Miao
2009-04-23  7:08 ` Daniel Mack [this message]
2009-04-23  8:17 ` Mark Brown
2009-04-23  8:33   ` Eric Miao
2009-04-23  9:04     ` Daniel Mack
2009-04-23  9:18       ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090423070815.GB23901@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@sirena.org.uk \
    --cc=bshen9@marvell.com \
    --cc=eric.y.miao@gmail.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=philipp.zabel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.