From: Eric Miao <eric.y.miao@gmail.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org, Paul Shen <bshen9@marvell.com>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [RFC PATCH 4/5] ASoC: remove those unnecessary #ifdef CONFIG_PXA3xx .. #endif
Date: Thu, 23 Apr 2009 16:33:34 +0800 [thread overview]
Message-ID: <f17812d70904230133l34f77174sc18d4f30879dac64@mail.gmail.com> (raw)
In-Reply-To: <20090423081715.GA30105@sirena.org.uk>
On Thu, Apr 23, 2009 at 4:17 PM, Mark Brown <broonie@sirena.org.uk> wrote:
> On Thu, Apr 23, 2009 at 01:06:55PM +0800, Eric Miao wrote:
>> These are unnecessary since the compiler is smart enough to optimize
>> the code away if CONFIG_PXA3xx is not defined, when cpu_is_pxa3xx()
>> will just be expanded to constant 0.
>
> This isn't done for compiler optimisation - it's done because the
> register bit macros are only defined if PXA3xx support is being built
> in. I've no problem with removing those guards but without that you'll
> get build failures on PXA2xx.
>
Yeah, indeed. This is a rush (so the title is RFC), sorry. I'll get those
conditional #ifdef .. #endif removed as well in the ssp-regs.h, it
always makes me upset. And possibly to get ssp-regs.h merged
into ssp.h. No one else now wants to use either one of these
header files.
--
Cheers
- eric
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2009-04-23 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 5:06 [RFC PATCH 4/5] ASoC: remove those unnecessary #ifdef CONFIG_PXA3xx .. #endif Eric Miao
2009-04-23 7:08 ` Daniel Mack
2009-04-23 8:17 ` Mark Brown
2009-04-23 8:33 ` Eric Miao [this message]
2009-04-23 9:04 ` Daniel Mack
2009-04-23 9:18 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17812d70904230133l34f77174sc18d4f30879dac64@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=bshen9@marvell.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.