From: Josh Boyer <jwboyer@linux.vnet.ibm.com> To: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org> Subject: Re: linux-next: upstream tree build failure Date: Thu, 23 Apr 2009 06:33:36 -0400 [thread overview] Message-ID: <20090423103336.GA3825@zod.rchland.ibm.com> (raw) In-Reply-To: <20090423160656.fac84e3f.sfr@canb.auug.org.au> On Thu, Apr 23, 2009 at 04:06:56PM +1000, Stephen Rothwell wrote: >Hi all, > >[I am now using gcc version 4.4.0 ...] > >Today's linux-next build (powerpc ppc44x_defconfig) failed like this: > >arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no expression > >Previous gcc versions didn't notice this because one of the preceding >#ifs always evaluated to true. I have applied the following patch for today. > >-- >Cheers, >Stephen Rothwell sfr@canb.auug.org.au >http://www.canb.auug.org.au/~sfr/ > >From: Stephen Rothwell <sfr@canb.auug.org.au> >Date: Thu, 23 Apr 2009 16:00:47 +1000 >Subject: [PATCH] powerpc: fix for long standing bug noticed by gcc 4.4.0 > >Previous gcc versions didn't notice this because one of the preceding > >gcc 4.4.0 produced this error: > >arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no expression > >Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Your changelog got truncated in the first sentence. No big deal. I have a gcc 4.4.0 system as well. I'll try a bunch of various builds to see if it catches anything else. This fix looks good to me in the meantime. Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com> josh >--- > arch/powerpc/mm/tlb_nohash_low.S | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/arch/powerpc/mm/tlb_nohash_low.S b/arch/powerpc/mm/tlb_nohash_low.S >index 45fed36..21e1b9a 100644 >--- a/arch/powerpc/mm/tlb_nohash_low.S >+++ b/arch/powerpc/mm/tlb_nohash_low.S >@@ -203,6 +203,6 @@ ALT_MMU_FTR_SECTION_END_IFCLR(MMU_FTR_USE_TLBILX) > isync > 1: wrtee r10 > blr >-#elif >+#else > #error Unsupported processor type ! > #endif
WARNING: multiple messages have this Message-ID (diff)
From: Josh Boyer <jwboyer@linux.vnet.ibm.com> To: Stephen Rothwell <sfr@canb.auug.org.au> Cc: linux-next@vger.kernel.org, Paul Mackerras <paulus@samba.org>, LKML <linux-kernel@vger.kernel.org>, linuxppc-dev@ozlabs.org Subject: Re: linux-next: upstream tree build failure Date: Thu, 23 Apr 2009 06:33:36 -0400 [thread overview] Message-ID: <20090423103336.GA3825@zod.rchland.ibm.com> (raw) In-Reply-To: <20090423160656.fac84e3f.sfr@canb.auug.org.au> On Thu, Apr 23, 2009 at 04:06:56PM +1000, Stephen Rothwell wrote: >Hi all, > >[I am now using gcc version 4.4.0 ...] > >Today's linux-next build (powerpc ppc44x_defconfig) failed like this: > >arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no expression > >Previous gcc versions didn't notice this because one of the preceding >#ifs always evaluated to true. I have applied the following patch for today. > >-- >Cheers, >Stephen Rothwell sfr@canb.auug.org.au >http://www.canb.auug.org.au/~sfr/ > >From: Stephen Rothwell <sfr@canb.auug.org.au> >Date: Thu, 23 Apr 2009 16:00:47 +1000 >Subject: [PATCH] powerpc: fix for long standing bug noticed by gcc 4.4.0 > >Previous gcc versions didn't notice this because one of the preceding > >gcc 4.4.0 produced this error: > >arch/powerpc/mm/tlb_nohash_low.S:206:6: error: #elif with no expression > >Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Your changelog got truncated in the first sentence. No big deal. I have a gcc 4.4.0 system as well. I'll try a bunch of various builds to see if it catches anything else. This fix looks good to me in the meantime. Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com> josh >--- > arch/powerpc/mm/tlb_nohash_low.S | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/arch/powerpc/mm/tlb_nohash_low.S b/arch/powerpc/mm/tlb_nohash_low.S >index 45fed36..21e1b9a 100644 >--- a/arch/powerpc/mm/tlb_nohash_low.S >+++ b/arch/powerpc/mm/tlb_nohash_low.S >@@ -203,6 +203,6 @@ ALT_MMU_FTR_SECTION_END_IFCLR(MMU_FTR_USE_TLBILX) > isync > 1: wrtee r10 > blr >-#elif >+#else > #error Unsupported processor type ! > #endif
next prev parent reply other threads:[~2009-04-23 10:34 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-04-23 6:06 linux-next: upstream tree build failure Stephen Rothwell 2009-04-23 6:06 ` Stephen Rothwell 2009-04-23 10:33 ` Josh Boyer [this message] 2009-04-23 10:33 ` Josh Boyer 2009-04-23 12:56 ` [PATCH v2] powerpc: fix for long standing bug noticed by gcc 4.4.0 Stephen Rothwell 2009-04-23 12:56 ` Stephen Rothwell 2009-04-23 13:55 ` Kumar Gala 2009-04-23 13:55 ` Kumar Gala
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090423103336.GA3825@zod.rchland.ibm.com \ --to=jwboyer@linux.vnet.ibm.com \ --cc=benh@kernel.crashing.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=paulus@samba.org \ --cc=sfr@canb.auug.org.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.