ath5k irq warning message

ath5k irq warning message

[Ben Greear]

I'm working on debugging some sort of live-lock related to irqs
in ath5k with lots of virtual stations.

I notice this code in the ath5k_intr method.

Won't counter be -1 if you break out of this due to the 'counter-- > 0'
clause?

If so, then that warning won't be printed regardless...

	} while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);

	if (unlikely(!counter))
		ATH5K_WARN(sc, "too many interrupts, giving up for now\n");


Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: ath5k irq warning message

[Bob Copeland]

On Wed, Apr 22, 2009 at 02:56:06PM -0700, Ben Greear wrote:
> I notice this code in the ath5k_intr method.
>
> Won't counter be -1 if you break out of this due to the 'counter-- > 0'
> clause?
>
> 	} while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);

Good catch, I guess it should be --counter...

-- 
Bob Copeland %% www.bobcopeland.com

Re: ath5k irq warning message

[Ben Greear]

Bob Copeland wrote:
> On Wed, Apr 22, 2009 at 02:56:06PM -0700, Ben Greear wrote:
>> I notice this code in the ath5k_intr method.
>>
>> Won't counter be -1 if you break out of this due to the 'counter-- > 0'
>> clause?
>>
>> 	} while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);
> 
> Good catch, I guess it should be --counter...

That works for me.

Seems the root cause of my problem might have been fixed already
by the patch to turn off BMISS irqs, btw...about to start
testing that now.

Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com