* [U-Boot] [PATCH 1/2] ubifs: BUG realpath string must be ended with NULL
@ 2009-04-27 7:13 Ricardo Ribalda Delgado
2009-04-27 7:37 ` Stefan Roese
2009-04-27 23:21 ` Wolfgang Denk
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2009-04-27 7:13 UTC (permalink / raw)
To: u-boot
If the memory used to copy the link_make is "dirty" the string wont
be ended with NULL, throwing out multiple memory bugs.
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>
---
v3: s/ZERO/NULL/, s/=/ = /
v2: better doc and remove duplicated memcpy
fs/ubifs/ubifs.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
index 32f9ff8..427d84a 100644
--- a/fs/ubifs/ubifs.c
+++ b/fs/ubifs/ubifs.c
@@ -641,6 +641,7 @@ int ubifs_load(char *filename, u32 addr, u32 size)
ui = ubifs_inode(inode);
if (((inode->i_mode & S_IFMT) == S_IFLNK) && ui->data_len) {
memcpy(link_name, ui->data, ui->data_len);
+ link_name[ui->data_len] = '\0';
printf("%s is linked to %s!\n", filename, link_name);
ubifs_iput(inode);
--
1.6.2.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/2] ubifs: BUG realpath string must be ended with NULL
2009-04-27 7:13 [U-Boot] [PATCH 1/2] ubifs: BUG realpath string must be ended with NULL Ricardo Ribalda Delgado
@ 2009-04-27 7:37 ` Stefan Roese
2009-04-27 23:21 ` Wolfgang Denk
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2009-04-27 7:37 UTC (permalink / raw)
To: u-boot
On Monday 27 April 2009, Ricardo Ribalda Delgado wrote:
> If the memory used to copy the link_make is "dirty" the string wont
> be ended with NULL, throwing out multiple memory bugs.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>
Acked-by: Stefan Roese <sr@denx.de>
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH 1/2] ubifs: BUG realpath string must be ended with NULL
2009-04-27 7:13 [U-Boot] [PATCH 1/2] ubifs: BUG realpath string must be ended with NULL Ricardo Ribalda Delgado
2009-04-27 7:37 ` Stefan Roese
@ 2009-04-27 23:21 ` Wolfgang Denk
1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2009-04-27 23:21 UTC (permalink / raw)
To: u-boot
Dear Ricardo Ribalda Delgado,
In message <1240816411-16585-1-git-send-email-ricardo.ribalda@uam.es> you wrote:
> If the memory used to copy the link_make is "dirty" the string wont
> be ended with NULL, throwing out multiple memory bugs.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>
> ---
> v3: s/ZERO/NULL/, s/=/ = /
> v2: better doc and remove duplicated memcpy
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Software entities are more complex for their size than perhaps any
other human construct because no two parts are alike. If they are, we
make the two similar parts into a subroutine -- open or closed. In
this respect, software systems differ profoundly from computers,
buildings, or automobiles, where repeated elements abound.
- Fred Brooks, Jr.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-27 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-27 7:13 [U-Boot] [PATCH 1/2] ubifs: BUG realpath string must be ended with NULL Ricardo Ribalda Delgado
2009-04-27 7:37 ` Stefan Roese
2009-04-27 23:21 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.