From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> To: nishimura@mxp.nes.nec.co.jp Cc: Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>, "hugh@veritas.com" <hugh@veritas.com> Subject: Re: [RFC][PATCH] fix swap entries is not reclaimed in proper way for memg v3. Date: Mon, 27 Apr 2009 16:39:30 +0900 [thread overview] Message-ID: <20090427163930.50604bf9.kamezawa.hiroyu@jp.fujitsu.com> (raw) In-Reply-To: <20090426010658.c0fa3258.d-nishimura@mtf.biglobe.ne.jp> On Sun, 26 Apr 2009 01:06:58 +0900 Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp> wrote: > A few minor nitpicks :) > > > > +static void memcg_fixup_stale_swapcache(struct work_struct *work) > > > +{ > > > + int pos = 0; > > > + swp_entry_t entry; > > > + struct page *page; > > > + int forget, ret; > > > + > > > + while (ssc.num) { > > > + spin_lock(&ssc.lock); > > > + pos = find_next_bit(ssc.usemap, STALE_ENTS, pos); > > > + spin_unlock(&ssc.lock); > > > + > > > + if (pos >= STALE_ENTS) > > > + break; > > > + > > > + entry = ssc.ents[pos]; > > > + > > > + forget = 1; > > > + page = lookup_swap_cache(entry); > I think using find_get_page() would be better. > lookup_swap_cache() update swapcache_info. > ok, and I have to add put_page() somewhere. > > > + if (page) { > > > + lock_page(page); > > > + ret = try_to_free_swap(page); > > > + /* If it's still under I/O, don't forget it */ > > > + if (!ret && PageWriteback(page)) > > > + forget = 0; > > > + unlock_page(page); > > I think we need page_cache_release(). > > lookup_swap_cache() gets the page. > > > > > + } > > > + if (forget) { > > > + spin_lock(&ssc.lock); > > > + clear_bit(pos, ssc.usemap); > > > + ssc.num--; > > > + if (ssc.num < STALE_ENTS/2) > > > + ssc.congestion = 0; > > > + spin_unlock(&ssc.lock); > > > + } > > > + pos++; > > > + } > > > + if (ssc.num) /* schedule me again */ > > > + schedule_delayed_work(&ssc.gc_work, HZ/10); > We can use schedule_ssc_gc() here. > (It should be defined before this, of course. And can be inlined.) > Sure. will soon post v2. (removing RFC) Thanks, -Kame > > "if (ssc.congestion)" would be better ? > > > > > + return; > > > +} > > > + > > > > Thanks, > Daisuke Nishimura. >
WARNING: multiple messages have this Message-ID (diff)
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> To: nishimura@mxp.nes.nec.co.jp Cc: Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>, "hugh@veritas.com" <hugh@veritas.com> Subject: Re: [RFC][PATCH] fix swap entries is not reclaimed in proper way for memg v3. Date: Mon, 27 Apr 2009 16:39:30 +0900 [thread overview] Message-ID: <20090427163930.50604bf9.kamezawa.hiroyu@jp.fujitsu.com> (raw) In-Reply-To: <20090426010658.c0fa3258.d-nishimura@mtf.biglobe.ne.jp> On Sun, 26 Apr 2009 01:06:58 +0900 Daisuke Nishimura <d-nishimura@mtf.biglobe.ne.jp> wrote: > A few minor nitpicks :) > > > > +static void memcg_fixup_stale_swapcache(struct work_struct *work) > > > +{ > > > + int pos = 0; > > > + swp_entry_t entry; > > > + struct page *page; > > > + int forget, ret; > > > + > > > + while (ssc.num) { > > > + spin_lock(&ssc.lock); > > > + pos = find_next_bit(ssc.usemap, STALE_ENTS, pos); > > > + spin_unlock(&ssc.lock); > > > + > > > + if (pos >= STALE_ENTS) > > > + break; > > > + > > > + entry = ssc.ents[pos]; > > > + > > > + forget = 1; > > > + page = lookup_swap_cache(entry); > I think using find_get_page() would be better. > lookup_swap_cache() update swapcache_info. > ok, and I have to add put_page() somewhere. > > > + if (page) { > > > + lock_page(page); > > > + ret = try_to_free_swap(page); > > > + /* If it's still under I/O, don't forget it */ > > > + if (!ret && PageWriteback(page)) > > > + forget = 0; > > > + unlock_page(page); > > I think we need page_cache_release(). > > lookup_swap_cache() gets the page. > > > > > + } > > > + if (forget) { > > > + spin_lock(&ssc.lock); > > > + clear_bit(pos, ssc.usemap); > > > + ssc.num--; > > > + if (ssc.num < STALE_ENTS/2) > > > + ssc.congestion = 0; > > > + spin_unlock(&ssc.lock); > > > + } > > > + pos++; > > > + } > > > + if (ssc.num) /* schedule me again */ > > > + schedule_delayed_work(&ssc.gc_work, HZ/10); > We can use schedule_ssc_gc() here. > (It should be defined before this, of course. And can be inlined.) > Sure. will soon post v2. (removing RFC) Thanks, -Kame > > "if (ssc.congestion)" would be better ? > > > > > + return; > > > +} > > > + > > > > Thanks, > Daisuke Nishimura. > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-27 7:41 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-04-21 7:21 [RFC][PATCH] fix swap entries is not reclaimed in proper way for mem+swap controller KAMEZAWA Hiroyuki 2009-04-21 7:21 ` KAMEZAWA Hiroyuki 2009-04-22 5:38 ` Daisuke Nishimura 2009-04-22 5:38 ` Daisuke Nishimura 2009-04-22 6:10 ` KAMEZAWA Hiroyuki 2009-04-22 6:10 ` KAMEZAWA Hiroyuki 2009-04-23 4:14 ` Daisuke Nishimura 2009-04-23 4:14 ` Daisuke Nishimura 2009-04-23 8:45 ` KAMEZAWA Hiroyuki 2009-04-23 8:45 ` KAMEZAWA Hiroyuki 2009-04-24 4:33 ` KAMEZAWA Hiroyuki 2009-04-24 4:33 ` KAMEZAWA Hiroyuki 2009-04-24 6:21 ` Daisuke Nishimura 2009-04-24 6:21 ` Daisuke Nishimura 2009-04-24 7:28 ` [RFC][PATCH] fix swap entries is not reclaimed in proper way for memg v3 KAMEZAWA Hiroyuki 2009-04-24 7:28 ` KAMEZAWA Hiroyuki 2009-04-24 8:07 ` Daisuke Nishimura 2009-04-24 8:07 ` Daisuke Nishimura 2009-04-25 12:54 ` Daisuke Nishimura 2009-04-25 12:54 ` Daisuke Nishimura 2009-04-25 16:06 ` Daisuke Nishimura 2009-04-25 16:06 ` Daisuke Nishimura 2009-04-27 7:39 ` KAMEZAWA Hiroyuki [this message] 2009-04-27 7:39 ` KAMEZAWA Hiroyuki 2009-04-27 8:12 ` Balbir Singh 2009-04-27 8:12 ` Balbir Singh 2009-04-27 8:21 ` KAMEZAWA Hiroyuki 2009-04-27 8:21 ` KAMEZAWA Hiroyuki 2009-04-27 8:43 ` Balbir Singh 2009-04-27 8:43 ` Balbir Singh 2009-04-27 8:49 ` KAMEZAWA Hiroyuki 2009-04-27 8:49 ` KAMEZAWA Hiroyuki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090427163930.50604bf9.kamezawa.hiroyu@jp.fujitsu.com \ --to=kamezawa.hiroyu@jp.fujitsu.com \ --cc=balbir@linux.vnet.ibm.com \ --cc=d-nishimura@mtf.biglobe.ne.jp \ --cc=hugh@veritas.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=nishimura@mxp.nes.nec.co.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.