Re: [PATCH] 83xx: add support for the kmeter1 board.

[Scott Wood <scottwood@freescale.com>]

On Mon, Apr 27, 2009 at 07:38:38AM +0200, Heiko Schocher wrote:
> 1) add in the soc node an "errata" node and in this "errata" node
>    we can add all CPU specific errata as an example the qe_enet10
>    errata, which above code covers:

What about errata discovered after the device tree is deployed?

>         soc8360@e0000000 {
> 	[...]
>                 errata {
>                         device_type = "errata";

device_type is deprecated except for a couple of legacy uses.  Please do
not add new ones.

>                         compatible = "fsl,mpc83xx_errata";

To be bound to by an "errata driver"? :-P

>                         #address-cells = <1>;
>                         #size-cells = <1>;
> 
>                         qe_enet10@14a8 {
>                                 device_type = "errata";
>                                 compatible = "fsl,mpc83xx_errata_qe_enet10";
>                                 reg = <0x14a8 0x08>;

But that register is part of the "QE parallel I/O port" block (even if it
happens to be undocumented within that block), not part of the "QE ENET10
erratum" block.  The device tree describes the hardware, not what you
want to do with it.

The presence of the erratum itself is indicated by the presence of the
buggy device, possibly in conjunction with SVR if the device tree is not
specific enough.

-Scott