Re: [PATCH v4] 83xx: add support for the kmeter1 board.

[Heiko Schocher <hs@denx.de>]

Hello David,

David Gibson wrote:
> On Thu, Jun 11, 2009 at 08:10:41PM +0200, Heiko Schocher wrote:
>> The following series implements basic board support for
>> the kmeter1 board from keymile, based on a MPC8360.
> 
> [snip]
>> +		par_io@1400 {
>> +			reg = <0x1400 0x100>;
>> +			device_type = "par_io";
> 
> This should have a compatible value instead of a device_type value.

compatible = "fsl,mpc8360-par_io"; ?

> [snip]
> 
>> +			num-ports = <7>;
>> +
>> +			pio_ucc1: ucc_pin@00 {
> 
> Since these nodes have addresses, they should also have reg
> properties.  And the parent should have #address-cells and
> #size-cells.

added "#address-cells" and "#size-cells", but couldn;t find what
I should write in a "reg" entry ... I think something like that:

reg = <0x00 0x01>;

?

> [snip]
>> +		qe@100000 {
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			device_type = "qe";
> 
> This device_type should not be here.

deleted.

>> +			compatible = "fsl,qe";
>> +			ranges = <0x0 0x100000 0x100000>;
>> +			reg = <0x100000 0x480>;
>> +			clock-frequency = <0>;	/* Filled in by U-Boot */
>> +			brg-frequency = <0>;	/* Filled in by U-Boot */
>> +			bus-frequency = <0>;	/* Filled in by U-Boot */

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany