[U-Boot] [PATCH 1/8] Add simple hwconfig infrastructure

[Wolfgang Denk <wd@denx.de>]

Dear Anton,

In message <20090429215000.GA1092@oksana.dev.rtsoft.ru> you wrote:
> This patch implements simple hwconfig infrastructure: an
> interface for software knobs to control a hardware.

Thanks a lot.

> 3. We support hwconfig options with arguments. For example,
> 
>    set hwconfig dr_usb,dr_usb_mode:peripheral,dr_usb_phy_type:ulpi
> 
>    There are three hwconfig options selected:
>    1. dr_usb - enable Dual-Role USB controller;
>    2. dr_usb_mode:peripheral - USB in Function mode;
>    3. dr_usb_phy_type:ulpi - USB should work with ULPI PHYs.

That gives a lot of typing, which in turn results in lots of typing
errors, which in this case are probably nasty to debug.

Suggestion: instead of

	set hwconfig dr_usb,dr_usb_mode:peripheral,dr_usb_phy_type:ulpi

use:

	set hwconfig dr_usb:mode=peripheral,phy_type=ulpi

What do you think?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Copy from one, it's plagiarism; copy from two, it's research.