Re: [PATCH][RESEND][mmc/host]:Blackfin SD Host Controller Driver

From: Pierre Ossman <pierre@ossman.eu>
To: "Cai, Cliff" <Cliff.Cai@analog.com>
Cc: linux-kernel@vger.kernel.org, "Cliff Cai" <cliffcai.sh@gmail.com>
Subject: Re: [PATCH][RESEND][mmc/host]:Blackfin SD Host Controller Driver
Date: Sun, 3 May 2009 21:09:10 +0200	[thread overview]
Message-ID: <20090503210910.42a78397@mjolnir.ossman.eu> (raw)
In-Reply-To: <0F1B54C89D5F954D8535DB252AF412FA03F20154@chinexm1.ad.analog.com>

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

On Mon, 27 Apr 2009 09:47:15 +0800
"Cai, Cliff" <Cliff.Cai@analog.com> wrote:

> >
> >If the controller can only do DAT3-detection, then I think 
> >it's best if we put it into polling mode.
> 
> What did you mean the polling mode,using a timer?
> 

The MMC core handles it for you. Just set MMC_CAP_NEEDS_POLL.

> >
> >You cannot index sg lists directly anymore. You have to 
> >iterate over them using the iteration helpers.
> 
> Why?
> 

Because you'll read bogus data otherwise and can even cause a oops. The
sg lists can be linked, which introduces special entries.

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]