* [PATCH] mfd: Mark WM8350 mask revision as readable to match silicon
@ 2009-04-30 13:44 Mark Brown
2009-05-03 21:57 ` Samuel Ortiz
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2009-04-30 13:44 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, Mark Brown
No impact unless someone has written additional kernel code.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/wm8350-regmap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/wm8350-regmap.c b/drivers/mfd/wm8350-regmap.c
index 9a4cc95..97d6aad 100644
--- a/drivers/mfd/wm8350-regmap.c
+++ b/drivers/mfd/wm8350-regmap.c
@@ -3186,7 +3186,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = {
/* read write volatile */
{ 0xFFFF, 0xFFFF, 0xFFFF }, /* R0 - Reset/ID */
{ 0x7CFF, 0x0C00, 0x7FFF }, /* R1 - ID */
- { 0x0000, 0x0000, 0x0000 }, /* R2 */
+ { 0x007F, 0x0000, 0x0000 }, /* R2 - ROM Mask ID */
{ 0xBE3B, 0xBE3B, 0x8000 }, /* R3 - System Control 1 */
{ 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */
{ 0x80FF, 0x80FF, 0x8000 }, /* R5 - System Hibernate */
--
1.6.2.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] mfd: Mark WM8350 mask revision as readable to match silicon
2009-04-30 13:44 [PATCH] mfd: Mark WM8350 mask revision as readable to match silicon Mark Brown
@ 2009-05-03 21:57 ` Samuel Ortiz
2009-05-03 22:04 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Samuel Ortiz @ 2009-05-03 21:57 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel
Hi Mark,
On Thu, Apr 30, 2009 at 02:44:29PM +0100, Mark Brown wrote:
> No impact unless someone has written additional kernel code.
All 3 patches applied to my for-next branch, thanks.
Cheers,
Samuel.
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/wm8350-regmap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/wm8350-regmap.c b/drivers/mfd/wm8350-regmap.c
> index 9a4cc95..97d6aad 100644
> --- a/drivers/mfd/wm8350-regmap.c
> +++ b/drivers/mfd/wm8350-regmap.c
> @@ -3186,7 +3186,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = {
> /* read write volatile */
> { 0xFFFF, 0xFFFF, 0xFFFF }, /* R0 - Reset/ID */
> { 0x7CFF, 0x0C00, 0x7FFF }, /* R1 - ID */
> - { 0x0000, 0x0000, 0x0000 }, /* R2 */
> + { 0x007F, 0x0000, 0x0000 }, /* R2 - ROM Mask ID */
> { 0xBE3B, 0xBE3B, 0x8000 }, /* R3 - System Control 1 */
> { 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */
> { 0x80FF, 0x80FF, 0x8000 }, /* R5 - System Hibernate */
> --
> 1.6.2.4
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mfd: Mark WM8350 mask revision as readable to match silicon
2009-05-03 21:57 ` Samuel Ortiz
@ 2009-05-03 22:04 ` Mark Brown
2009-05-04 7:50 ` Samuel Ortiz
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2009-05-03 22:04 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel
On Sun, May 03, 2009 at 11:57:29PM +0200, Samuel Ortiz wrote:
> On Thu, Apr 30, 2009 at 02:44:29PM +0100, Mark Brown wrote:
> > No impact unless someone has written additional kernel code.
> All 3 patches applied to my for-next branch, thanks.
At least the patch for the caching of volatile registers really ought to
go into 2.6.30 if possible - not having it breaks the audio driver for
the chip.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: Mark WM8350 mask revision as readable to match silicon
2009-05-03 22:04 ` Mark Brown
@ 2009-05-04 7:50 ` Samuel Ortiz
0 siblings, 0 replies; 6+ messages in thread
From: Samuel Ortiz @ 2009-05-04 7:50 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel
On Sun, May 03, 2009 at 11:04:22PM +0100, Mark Brown wrote:
> On Sun, May 03, 2009 at 11:57:29PM +0200, Samuel Ortiz wrote:
> > On Thu, Apr 30, 2009 at 02:44:29PM +0100, Mark Brown wrote:
>
> > > No impact unless someone has written additional kernel code.
>
> > All 3 patches applied to my for-next branch, thanks.
>
> At least the patch for the caching of volatile registers really ought to
> go into 2.6.30 if possible - not having it breaks the audio driver for
> the chip.
Yes, I'll include it to one of my 2.6.30 pull requests.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mfd: Mark WM8350 mask revision as readable to match silicon
@ 2009-04-22 20:46 Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2009-04-22 20:46 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, Mark Brown
No impact unless someone has written additional kernel code.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/wm8350-regmap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/wm8350-regmap.c b/drivers/mfd/wm8350-regmap.c
index 9a4cc95..97d6aad 100644
--- a/drivers/mfd/wm8350-regmap.c
+++ b/drivers/mfd/wm8350-regmap.c
@@ -3186,7 +3186,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = {
/* read write volatile */
{ 0xFFFF, 0xFFFF, 0xFFFF }, /* R0 - Reset/ID */
{ 0x7CFF, 0x0C00, 0x7FFF }, /* R1 - ID */
- { 0x0000, 0x0000, 0x0000 }, /* R2 */
+ { 0x007F, 0x0000, 0x0000 }, /* R2 - ROM Mask ID */
{ 0xBE3B, 0xBE3B, 0x8000 }, /* R3 - System Control 1 */
{ 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */
{ 0x80FF, 0x80FF, 0x8000 }, /* R5 - System Hibernate */
--
1.6.2.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] mfd: Mark WM8350 mask revision as readable to match silicon
@ 2009-03-12 10:17 Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2009-03-12 10:17 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, Mark Brown
No impact unless someone has written additional kernel code.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/wm8350-regmap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/wm8350-regmap.c b/drivers/mfd/wm8350-regmap.c
index 9a4cc95..97d6aad 100644
--- a/drivers/mfd/wm8350-regmap.c
+++ b/drivers/mfd/wm8350-regmap.c
@@ -3186,7 +3186,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = {
/* read write volatile */
{ 0xFFFF, 0xFFFF, 0xFFFF }, /* R0 - Reset/ID */
{ 0x7CFF, 0x0C00, 0x7FFF }, /* R1 - ID */
- { 0x0000, 0x0000, 0x0000 }, /* R2 */
+ { 0x007F, 0x0000, 0x0000 }, /* R2 - ROM Mask ID */
{ 0xBE3B, 0xBE3B, 0x8000 }, /* R3 - System Control 1 */
{ 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */
{ 0x80FF, 0x80FF, 0x8000 }, /* R5 - System Hibernate */
--
1.6.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-05-04 7:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-30 13:44 [PATCH] mfd: Mark WM8350 mask revision as readable to match silicon Mark Brown
2009-05-03 21:57 ` Samuel Ortiz
2009-05-03 22:04 ` Mark Brown
2009-05-04 7:50 ` Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2009-04-22 20:46 Mark Brown
2009-03-12 10:17 Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.