bad register name `%sil' when building debug enabled xen 3.3.1 with gcc 4.4.0 on fedora 11

bad register name `%sil' when building debug enabled xen 3.3.1 with gcc 4.4.0 on fedora 11

[Pasi Kärkkäinen]

Hello!

Has anyone seen this error?:

traps.c: Assembler messages:
traps.c:1343: Error: bad register name `%sil'
make[4]: *** [traps.o] Error 1
make[4]: Leaving directory `/root/rpmbuild/BUILD/xen-3.3.1/xen/arch/x86'
make[3]: *** [/root/rpmbuild/BUILD/xen-3.3.1/xen/arch/x86/built_in.o] Error 2

I'm trying to rebuild Fedora xen-3.3.1-11.fc11.src.rpm with debugging
enabled ("debug=y verbose=y crash_debug=y").

Normal non-debug build succeeds fine without errors.. gcc bug? xen bug?

Thanks!

-- Pasi

Re: bad register name `%sil' when building debug enabled xen 3.3.1 with gcc 4.4.0 on fedora 11

[Pasi Kärkkäinen]

On Mon, May 04, 2009 at 10:00:56PM +0300, Pasi Kärkkäinen wrote:
> Hello!
> 
> Has anyone seen this error?:
> 
> traps.c: Assembler messages:
> traps.c:1343: Error: bad register name `%sil'
> make[4]: *** [traps.o] Error 1
> make[4]: Leaving directory `/root/rpmbuild/BUILD/xen-3.3.1/xen/arch/x86'
> make[3]: *** [/root/rpmbuild/BUILD/xen-3.3.1/xen/arch/x86/built_in.o] Error 2
> 
> I'm trying to rebuild Fedora xen-3.3.1-11.fc11.src.rpm with debugging
> enabled ("debug=y verbose=y crash_debug=y").
> 
> Normal non-debug build succeeds fine without errors.. gcc bug? xen bug?
> 

# gcc --version
gcc (GCC) 4.4.0 20090427 (Red Hat 4.4.0-3)
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

-- Pasi

> Thanks!
> 
> -- Pasi
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: bad register name `%sil' when building debug enabled xen 3.3.1 with gcc 4.4.0 on fedora 11

[Keir Fraser]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

On 04/05/2009 20:00, "Pasi Kärkkäinen" <pasik@iki.fi> wrote:

> I'm trying to rebuild Fedora xen-3.3.1-11.fc11.src.rpm with debugging
> enabled ("debug=y verbose=y crash_debug=y").
> 
> Normal non-debug build succeeds fine without errors.. gcc bug? xen bug?

A couple of asm constraints should be "=qm" rather than "=rm". I will fix
for 3.4.0 and 3.3.1. You can use the attached patch to fix your build.

 -- Keir


[-- Attachment #2: x86.patch --]
[-- Type: application/octet-stream, Size: 971 bytes --]

# HG changeset patch
# User Keir Fraser <keir.fraser@citrix.com>
# Date 1241473938 -3600
# Node ID 7a73e3aeb2244e1b9754cbea44cd61cfd594e88d
# Parent  f80cf52a4fb6bae6a9f023425ff8e7a9f3ea726a
x86: Fix a couple of asm constraints.
Signed-off-by: Keir Fraser <keir.fraser@citrix.com>

diff -r f80cf52a4fb6 -r 7a73e3aeb224 xen/arch/x86/traps.c
--- a/xen/arch/x86/traps.c	Thu Apr 30 14:34:15 2009 +0100
+++ b/xen/arch/x86/traps.c	Mon May 04 22:52:18 2009 +0100
@@ -1364,11 +1364,11 @@
 
             asm volatile (
                 "larl %2,%0 ; setz %1"
-                : "=r" (a), "=rm" (valid) : "rm" (sel));
+                : "=r" (a), "=qm" (valid) : "rm" (sel));
             BUG_ON(valid && ((a & 0x00f0ff00) != *ar));
             asm volatile (
                 "lsll %2,%0 ; setz %1"
-                : "=r" (l), "=rm" (valid) : "rm" (sel));
+                : "=r" (l), "=qm" (valid) : "rm" (sel));
             BUG_ON(valid && (l != *limit));
         }
 #endif

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: bad register name `%sil' when building debug enabled xen 3.3.1 with gcc 4.4.0 on fedora 11

[Pasi Kärkkäinen]

On Mon, May 04, 2009 at 10:53:16PM +0100, Keir Fraser wrote:
> On 04/05/2009 20:00, "Pasi Kärkkäinen" <pasik@iki.fi> wrote:
> 
> > I'm trying to rebuild Fedora xen-3.3.1-11.fc11.src.rpm with debugging
> > enabled ("debug=y verbose=y crash_debug=y").
> > 
> > Normal non-debug build succeeds fine without errors.. gcc bug? xen bug?
> 
> A couple of asm constraints should be "=qm" rather than "=rm". I will fix
> for 3.4.0 and 3.3.1. You can use the attached patch to fix your build.
> 

Thanks!

I'll try the patch later today.

-- Pasi

Re: bad register name `%sil' when building debug enabled xen 3.3.1 with gcc 4.4.0 on fedora 11

[Pasi Kärkkäinen]

On Tue, May 05, 2009 at 09:19:00AM +0300, Pasi Kärkkäinen wrote:
> On Mon, May 04, 2009 at 10:53:16PM +0100, Keir Fraser wrote:
> > On 04/05/2009 20:00, "Pasi Kärkkäinen" <pasik@iki.fi> wrote:
> > 
> > > I'm trying to rebuild Fedora xen-3.3.1-11.fc11.src.rpm with debugging
> > > enabled ("debug=y verbose=y crash_debug=y").
> > > 
> > > Normal non-debug build succeeds fine without errors.. gcc bug? xen bug?
> > 
> > A couple of asm constraints should be "=qm" rather than "=rm". I will fix
> > for 3.4.0 and 3.3.1. You can use the attached patch to fix your build.
> > 
> 
> Thanks!
> 
> I'll try the patch later today.
> 

And indeed, the attached patch fixes the problem!

Thanks again.

Now back to debugging pv_ops dom0 kernels :-)

-- Pasi