From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
virtualization@lists.linux-foundation.org,
Anthony Liguori <anthony@codemonkey.ws>,
kvm@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations
Date: Sun, 10 May 2009 10:25:38 +0300 [thread overview]
Message-ID: <20090510072538.GA5335@redhat.com> (raw)
In-Reply-To: <200905101337.06836.rusty@rustcorp.com.au>
On Sun, May 10, 2009 at 01:37:06PM +0930, Rusty Russell wrote:
> Yes, and in fact a rough look at your patch reveals that we don't actually
> need del_vq: now we track them, we can just do that as part of vdev
> destruction, right?
Let's assume that a driver encounters an error in probe
after it calls find_vq. It would need a way to revert
find_vq, won't it?
It seems to me that bus->remove does not get called
on probe failure. Isn't that right?
--
MST
next prev parent reply other threads:[~2009-05-10 7:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1241700929.git.mst@redhat.com>
2009-05-07 14:10 ` [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations Michael S. Tsirkin
2009-05-07 14:10 ` Michael S. Tsirkin
2009-05-08 7:07 ` Rusty Russell
2009-05-08 12:48 ` Michael S. Tsirkin
2009-05-10 4:07 ` Rusty Russell
2009-05-10 4:07 ` Rusty Russell
2009-05-10 7:25 ` Michael S. Tsirkin
2009-05-10 7:25 ` Michael S. Tsirkin [this message]
2009-05-12 13:03 ` Rusty Russell
2009-05-12 13:03 ` Rusty Russell
2009-05-10 18:51 ` Christian Borntraeger
2009-05-10 18:51 ` Christian Borntraeger
2009-05-08 12:48 ` Michael S. Tsirkin
2009-05-08 7:07 ` Rusty Russell
2009-05-07 14:11 ` [PATCH 2/3] virtio_pci: split up vp_interrupt Michael S. Tsirkin
2009-05-07 14:11 ` Michael S. Tsirkin
2009-05-07 14:12 ` [PATCH 3/3] virtio_pci: optional MSI-X support Michael S. Tsirkin
2009-05-07 14:12 ` Michael S. Tsirkin
[not found] <cover.1242080138.git.mst@redhat.com>
2009-05-11 22:19 ` [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations Michael S. Tsirkin
2009-05-12 8:55 ` Christian Borntraeger
2009-05-12 8:55 ` Christian Borntraeger
2009-05-12 14:30 ` Rusty Russell
2009-05-12 14:30 ` Rusty Russell
2009-05-12 15:33 ` Michael S. Tsirkin
2009-05-12 15:33 ` Michael S. Tsirkin
2009-05-13 1:17 ` Rusty Russell
2009-05-13 7:18 ` Michael S. Tsirkin
2009-05-13 7:18 ` Michael S. Tsirkin
2009-05-13 7:26 ` Avi Kivity
2009-05-13 7:26 ` Avi Kivity
2009-05-13 11:33 ` Rusty Russell
2009-05-13 11:33 ` Rusty Russell
2009-05-13 1:17 ` Rusty Russell
2009-05-11 22:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090510072538.GA5335@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.