From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
avi@redhat.com, kvm@vger.kernel.org,
Anthony Liguori <anthony@codemonkey.ws>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations
Date: Sun, 10 May 2009 13:37:06 +0930 [thread overview]
Message-ID: <200905101337.06836.rusty__42077.7297382758$1241928528$gmane$org@rustcorp.com.au> (raw)
In-Reply-To: <20090508124821.GA3073@redhat.com>
On Fri, 8 May 2009 10:18:22 pm Michael S. Tsirkin wrote:
> On Fri, May 08, 2009 at 04:37:06PM +0930, Rusty Russell wrote:
> > On Thu, 7 May 2009 11:40:39 pm Michael S. Tsirkin wrote:
> > > This replaces find_vq/del_vq with find_vqs/del_vqs virtio operations,
> > > and updates all drivers. This is needed for MSI support, because MSI
> > > needs to know the total number of vectors upfront.
> >
> > Hmm, I have a similar need for a dev to vq mapping (debugging stats).
> > How's this as a common basis?
>
> This helps. Should I redo mine on top of this?
Yep, it should make your smaller as well.
> > void vring_del_virtqueue(struct virtqueue *vq)
> > {
> > + list_del(&vq->list);
> > kfree(to_vvq(vq));
> > }
> > EXPORT_SYMBOL_GPL(vring_del_virtqueue);
>
> I note lack of locking here. This is okay in practice as
> drivers don't really call find/del vq in parallel,
> but making this explicit with find_vqs will be best, yes?
Yes, and in fact a rough look at your patch reveals that we don't actually
need del_vq: now we track them, we can just do that as part of vdev
destruction, right?
If you agree, please do that patch first, then do the find_vqs change on top of
that.
Thanks!
Rusty.
next prev parent reply other threads:[~2009-05-10 4:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1241700929.git.mst@redhat.com>
2009-05-07 14:10 ` [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations Michael S. Tsirkin
2009-05-07 14:10 ` Michael S. Tsirkin
2009-05-08 7:07 ` Rusty Russell
2009-05-08 12:48 ` Michael S. Tsirkin
2009-05-10 4:07 ` Rusty Russell [this message]
2009-05-10 4:07 ` Rusty Russell
2009-05-10 7:25 ` Michael S. Tsirkin
2009-05-10 7:25 ` Michael S. Tsirkin
2009-05-12 13:03 ` Rusty Russell
2009-05-12 13:03 ` Rusty Russell
2009-05-10 18:51 ` Christian Borntraeger
2009-05-10 18:51 ` Christian Borntraeger
2009-05-08 12:48 ` Michael S. Tsirkin
2009-05-08 7:07 ` Rusty Russell
2009-05-07 14:11 ` [PATCH 2/3] virtio_pci: split up vp_interrupt Michael S. Tsirkin
2009-05-07 14:11 ` Michael S. Tsirkin
2009-05-07 14:12 ` [PATCH 3/3] virtio_pci: optional MSI-X support Michael S. Tsirkin
2009-05-07 14:12 ` Michael S. Tsirkin
[not found] <cover.1242080138.git.mst@redhat.com>
2009-05-11 22:19 ` [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations Michael S. Tsirkin
2009-05-12 8:55 ` Christian Borntraeger
2009-05-12 8:55 ` Christian Borntraeger
2009-05-12 14:30 ` Rusty Russell
2009-05-12 14:30 ` Rusty Russell
2009-05-12 15:33 ` Michael S. Tsirkin
2009-05-12 15:33 ` Michael S. Tsirkin
2009-05-13 1:17 ` Rusty Russell
2009-05-13 7:18 ` Michael S. Tsirkin
2009-05-13 7:18 ` Michael S. Tsirkin
2009-05-13 7:26 ` Avi Kivity
2009-05-13 7:26 ` Avi Kivity
2009-05-13 11:33 ` Rusty Russell
2009-05-13 11:33 ` Rusty Russell
2009-05-13 1:17 ` Rusty Russell
2009-05-11 22:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='200905101337.06836.rusty__42077.7297382758$1241928528$gmane$org@rustcorp.com.au' \
--to=rusty@rustcorp.com.au \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.