All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH v2 0/7] can: CAN network device driver interface and drivers
@ 2009-05-12  9:46 Subrata Modak
  2009-05-12  9:58 ` Wolfgang Grandegger
  2011-07-10 12:18   ` [LTP] " Oliver Hartkopp
  0 siblings, 2 replies; 12+ messages in thread
From: Subrata Modak @ 2009-05-12  9:46 UTC (permalink / raw)
  To: Oliver Hartkopp, Wolfgang Grandegger
  Cc: Subrata Modak, ltp-list, socketcan-users, netdev

Hi Oliver/Wolfgang,

> Hello,
> 
> here comes v2 of the patch series posted some time ago. See
> 
>  http://marc.info/?l=linux-netdev&m=123507025810612&w=4.
> 
> Changes since v1:
> 
> - The SysFS interface has been replaced by the Netlink interface as
>  suggested by Patrick. For further information have a look to
>  chapter 6.5 of "Documentation/networking/can.txt" and the header
>  file "include/linux/can/netdev.h". The patch for the "ip" program of
>  the iproute2 utility suite will be provided separately.
> 
> - The restart function is now properly protected by "dev->tx_lock"
>  using the "netif_tx_[lock|unlock]" functions.
> 
> - For the  restart, the device driver must now handle CAN_MODE_STOP as
>  well, apart from CAN_MODE_START to avoid race conditions.
> 
> - The "irq_lock" member of "struct can_priv" has been removed. The CAN
>  controller driver may should provide its own synchronization if
>  necessary.
> 
> - The restart function is now protected by "dev->tx_lock" using the
>  "netif_tx_lock/unlock" functions.
> 
> - Cleanup timer usage for the restart function.
> 
> - The unused do_set/get_ctrlmode member of "struct can_priv" have been
>  removed.
> 
> - "const" has been added to "struct net_device" for some functions not
>  allowed to touch that structure.
> 
> - The library functions "can_set_bittiming" and "can_close_cleanup" have
>  been renamed to the more general names "open_candev" and
>  "close_candev", respectively.
> 
> - Use "del_timer_sync" instead of "del_timer" for the  re-start timer.
> 
> - The macro "ND2D()" has been replaced by "dev->dev.parent" as it does
>  not make the code more readable.
> 
> - Fix improper BTR setting for triple-sampling for the SJA1000 as
>  pointed out by Oliver.
> 
> - Dont use __u8 but __u32 as before for some members of "struct
>  can_bittiming[_const]" to avoid alignment trouble.
> 
> - Definitions shared with user-space applications have been moved to
>  "include/linux/can/netlink.h".
> 
> - Various other minor correction suggested on the netdev ML.
> 
> - The MSCAN driver for the MPC5200 has been removed. It needs to be
>  presented on the Linuxppc-dev and Devicetree-discuss ML as well,
>  which will be done by a sub-sequent patch.
> 
> - Add more source code documentation, especially for the structures
>  and functions related to bit-timing.
> 
> The PF_CAN protocol family for the Controller Area Network is available
> in the kernel since version 2.6.25 but drivers for real CAN devices are
> still missing. This patch series adds a generic CAN network device
> driver interface and, as a start, a few drivers. It is the result of the
> on-going discussion and development of the Socket-CAN project hosted at
> the BerliOS web-server (http://developer.berlios.de/projects/socketcan).
> The patch series consists of the following patches:
> 
>  1/8) can: Documentation for the CAN device driver interface
>  2/8) can: Update MAINTAINERS and CREDITS file
>  3/8) can: CAN Network device driver and Netlink interface
>  4/8) can: Driver for the SJA1000 CAN controller
>  5/8) can: SJA1000 generic platform bus driver
>  6/8) can: SJA1000 driver for EMS PCI cards
>  7/8) can: SJA1000 driver for Kvaser PCI cards

Would you also like to send a patch to update the testcases for CAN in LTP
(http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/network/can/filter-tests/) ?
These tests were originally picked up from:
http://svn.berlios.de/wsvn/socketcan/trunk/test/?rev=877&sc=1

Regards--
Subrata

> 
> Please consider these patches for inclusion.
> 
> Thanks,
> 
> Wolfgang.
> 
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH v2 0/7] can: CAN network device driver interface and drivers
@ 2009-05-12  9:27 Wolfgang Grandegger
  0 siblings, 0 replies; 12+ messages in thread
From: Wolfgang Grandegger @ 2009-05-12  9:27 UTC (permalink / raw)
  To: netdev; +Cc: linux-kernel

Hello,

here comes v2 of the patch series posted some time ago. See

  http://marc.info/?l=linux-netdev&m=123507025810612&w=4.

Changes since v1:

- The SysFS interface has been replaced by the Netlink interface as
  suggested by Patrick. For further information have a look to
  chapter 6.5 of "Documentation/networking/can.txt" and the header
  file "include/linux/can/netdev.h". The patch for the "ip" program of
  the iproute2 utility suite will be provided separately.

- The restart function is now properly protected by "dev->tx_lock"
  using the "netif_tx_[lock|unlock]" functions.

- For the  restart, the device driver must now handle CAN_MODE_STOP as
  well, apart from CAN_MODE_START to avoid race conditions.

- The "irq_lock" member of "struct can_priv" has been removed. The CAN
  controller driver may should provide its own synchronization if
  necessary.

- The restart function is now protected by "dev->tx_lock" using the
  "netif_tx_lock/unlock" functions.

- Cleanup timer usage for the restart function.

- The unused do_set/get_ctrlmode member of "struct can_priv" have been
  removed.

- "const" has been added to "struct net_device" for some functions not
  allowed to touch that structure.

- The library functions "can_set_bittiming" and "can_close_cleanup" have
  been renamed to the more general names "open_candev" and
  "close_candev", respectively.

- Use "del_timer_sync" instead of "del_timer" for the  re-start timer.

- The macro "ND2D()" has been replaced by "dev->dev.parent" as it does
  not make the code more readable.

- Fix improper BTR setting for triple-sampling for the SJA1000 as
  pointed out by Oliver.

- Dont use __u8 but __u32 as before for some members of "struct
  can_bittiming[_const]" to avoid alignment trouble.

- Definitions shared with user-space applications have been moved to
  "include/linux/can/netlink.h".

- Various other minor correction suggested on the netdev ML.

- The MSCAN driver for the MPC5200 has been removed. It needs to be
  presented on the Linuxppc-dev and Devicetree-discuss ML as well,
  which will be done by a sub-sequent patch.

- Add more source code documentation, especially for the structures
  and functions related to bit-timing.

The PF_CAN protocol family for the Controller Area Network is available
in the kernel since version 2.6.25 but drivers for real CAN devices are
still missing. This patch series adds a generic CAN network device
driver interface and, as a start, a few drivers. It is the result of the
on-going discussion and development of the Socket-CAN project hosted at
the BerliOS web-server (http://developer.berlios.de/projects/socketcan).
The patch series consists of the following patches:

 1/8) can: Documentation for the CAN device driver interface
 2/8) can: Update MAINTAINERS and CREDITS file
 3/8) can: CAN Network device driver and Netlink interface
 4/8) can: Driver for the SJA1000 CAN controller
 5/8) can: SJA1000 generic platform bus driver
 6/8) can: SJA1000 driver for EMS PCI cards
 7/8) can: SJA1000 driver for Kvaser PCI cards

Please consider these patches for inclusion.

Thanks,

Wolfgang.


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2011-07-11 17:32 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-12  9:46 [PATCH v2 0/7] can: CAN network device driver interface and drivers Subrata Modak
2009-05-12  9:58 ` Wolfgang Grandegger
2009-05-12 10:46   ` Oliver Hartkopp
2009-05-12 10:59     ` Subrata Modak
2009-06-18 17:31       ` [LTP] [PATCH v2 0/7] can: CAN network device driver interfaceand drivers Subrata Modak
2009-06-18 17:31         ` Subrata Modak
2011-07-10 12:18 ` Update for CAN LTP tests Oliver Hartkopp
2011-07-10 12:18   ` [LTP] " Oliver Hartkopp
2011-07-11 16:15   ` Cyril Hrubis
2011-07-11 16:15     ` Cyril Hrubis
2011-07-11 17:32     ` CAN: major update for the Controller Area Network " Oliver Hartkopp
  -- strict thread matches above, loose matches on Subject: below --
2009-05-12  9:27 [PATCH v2 0/7] can: CAN network device driver interface and drivers Wolfgang Grandegger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.