All of lore.kernel.org
 help / color / mirror / Atom feed
* [alternative-merged] drivers-usb-serial-ti_usb_3410_5052c-ti_usb-returns-eio-when-reopening-the-device.patch removed from -mm tree
@ 2009-05-13  0:36 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2009-05-13  0:36 UTC (permalink / raw)
  To: christoph.mair, alan, greg, stable, mm-commits


The patch titled
     drivers/usb/serial/ti_usb_3410_5052.c: ti_usb returns EIO when reopening the device
has been removed from the -mm tree.  Its filename was
     drivers-usb-serial-ti_usb_3410_5052c-ti_usb-returns-eio-when-reopening-the-device.patch

This patch was dropped because an alternative patch was merged

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: drivers/usb/serial/ti_usb_3410_5052.c: ti_usb returns EIO when reopening the device
From: Christoph Mair <christoph.mair@gmail.com>

Fix regression introduced by 4a90f09b20f4622dcbff1f0e1e6bae1704f8ad8c
("tty: usb-serial krefs").

The driver works as expected until you close the device and try to reopen
it.  All you get from now on, is an I/O error.  It seems that something
isn't released correctly, because the refcount of the usbserial module
does not drop to zero, even when unloading all dependent drivers.

Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Greg KH <greg@kroah.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/usb/serial/ti_usb_3410_5052.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/usb/serial/ti_usb_3410_5052.c~drivers-usb-serial-ti_usb_3410_5052c-ti_usb-returns-eio-when-reopening-the-device drivers/usb/serial/ti_usb_3410_5052.c
--- a/drivers/usb/serial/ti_usb_3410_5052.c~drivers-usb-serial-ti_usb_3410_5052c-ti_usb-returns-eio-when-reopening-the-device
+++ a/drivers/usb/serial/ti_usb_3410_5052.c
@@ -1218,8 +1218,8 @@ static void ti_bulk_in_callback(struct u
 			tport->tp_icount.rx += urb->actual_length;
 			spin_unlock(&tport->tp_lock);
 		}
-		tty_kref_put(tty);
 	}
+	tty_kref_put(tty);
 
 exit:
 	/* continue to read unless stopping */
_

Patches currently in -mm which might be from christoph.mair@gmail.com are

drivers-usb-serial-ti_usb_3410_5052c-ti_usb-returns-eio-when-reopening-the-device.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-05-13  0:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-13  0:36 [alternative-merged] drivers-usb-serial-ti_usb_3410_5052c-ti_usb-returns-eio-when-reopening-the-device.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.