[PATCH] ftrace: fix check for return value of register_module_notifier in event_trace_init

[PATCH] ftrace: fix check for return value of register_module_notifier in event_trace_init

[Frederic Weisbecker]

Hi Ingo,

Here is a fixlet from Ming Lei which fixes a spurious warning.

Thanks.


The following changes since commit fd51d251e4cdb21f68e9dbc4336514d64a105a79:
  Stefan Raspl (1):
        blktrace: remove debugfs entries on bad path

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
	tracing/core

Ming Lei (1):
      ftrace: fix check for return value of register_module_notifier in event_trace_init

 kernel/trace/trace_events.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
>From 5537937696c55530447c20aa27daccb8d0d29b33 Mon Sep 17 00:00:00 2001
From: Ming Lei <tom.leiming@gmail.com>
Date: Mon, 18 May 2009 23:04:46 +0800
Subject: [PATCH] ftrace: fix check for return value of register_module_notifier in event_trace_init

register_module_notifier() returns zero in the success case.
So fix the inverted fail case check in trace events modules
handler.

[ Impact: fix spurious warning on ftrace initialization]

Reported-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 kernel/trace/trace_events.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 0eec0c5..9e91c4a 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1174,7 +1174,7 @@ static __init int event_trace_init(void)
 	}
 
 	ret = register_module_notifier(&trace_module_nb);
-	if (!ret)
+	if (ret)
 		pr_warning("Failed to register trace events module notifier\n");
 
 	return 0;
-- 
1.6.2.3

Re: [PATCH] ftrace: fix check for return value of register_module_notifier in event_trace_init

[Ingo Molnar]

* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Hi Ingo,
> 
> Here is a fixlet from Ming Lei which fixes a spurious warning.
> 
> Thanks.
> 
> 
> The following changes since commit fd51d251e4cdb21f68e9dbc4336514d64a105a79:
>   Stefan Raspl (1):
>         blktrace: remove debugfs entries on bad path
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
> 	tracing/core
> 
> Ming Lei (1):
>       ftrace: fix check for return value of register_module_notifier in event_trace_init
> 
>  kernel/trace/trace_events.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Pulled, thanks!

	Ingo