All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb1400_ts: fix access to "device data" in resume function
@ 2009-05-26 17:04 Sebastian Andrzej Siewior
  2009-05-27 13:28 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2009-05-26 17:04 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: Manuel Traut, linux-input, dtor, Marek Vasiut

From: Manuel Traut <manut@linutronix.de>

platform_data != driver_data

driver data is actually the "correct" place of the struct however it is
not placed there due to the need of the ac97 struct. This is broken since
d9105c2b01 aka "[ARM] 5184/1: Split ucb1400_ts into core and touchscreen"

Signed-off-by: Manuel Traut <manut@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
This is suspend/resume tested.
What happend actually to [0]? It is not merged.

[0] http://markmail.org/message/cp5koxmiotxrf4xl

 drivers/input/touchscreen/ucb1400_ts.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c
index 1647bc4..a42226e 100644
--- a/drivers/input/touchscreen/ucb1400_ts.c
+++ b/drivers/input/touchscreen/ucb1400_ts.c
@@ -418,7 +418,7 @@ static int ucb1400_ts_remove(struct platform_device *dev)
 #ifdef CONFIG_PM
 static int ucb1400_ts_resume(struct platform_device *dev)
 {
-	struct ucb1400_ts *ucb = platform_get_drvdata(dev);
+	struct ucb1400_ts *ucb = dev->dev.platform_data;
 
 	if (ucb->ts_task) {
 		/*
-- 
1.6.0.6


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb1400_ts: fix access to "device data" in resume function
  2009-05-26 17:04 [PATCH] usb1400_ts: fix access to "device data" in resume function Sebastian Andrzej Siewior
@ 2009-05-27 13:28 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2009-05-27 13:28 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior; +Cc: Manuel Traut, linux-input, Marek Vasiut

On Tue, May 26, 2009 at 07:04:40PM +0200, Sebastian Andrzej Siewior wrote:
> From: Manuel Traut <manut@linutronix.de>
> 
> platform_data != driver_data
> 
> driver data is actually the "correct" place of the struct however it is
> not placed there due to the need of the ac97 struct. This is broken since
> d9105c2b01 aka "[ARM] 5184/1: Split ucb1400_ts into core and touchscreen"
> 
> Signed-off-by: Manuel Traut <manut@linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Applied, to 'for-linus' branch, thank you Sebastian.

> ---
> This is suspend/resume tested.
> What happend actually to [0]? It is not merged.
> 
> [0] http://markmail.org/message/cp5koxmiotxrf4xl

Just applied it to my 'next' branch.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-27 13:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-26 17:04 [PATCH] usb1400_ts: fix access to "device data" in resume function Sebastian Andrzej Siewior
2009-05-27 13:28 ` Dmitry Torokhov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.