All of lore.kernel.org
 help / color / mirror / Atom feed
* [nacked] ima-return-proper-error-value-on-failure-of-dentry_open.patch removed from -mm tree
@ 2009-06-02  5:21 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2009-06-02  5:21 UTC (permalink / raw)
  To: vibi_sreenivasan, jmorris, sailer, serue, zohar, mm-commits


The patch titled
     ima: return proper error value on failure of dentry_open()
has been removed from the -mm tree.  Its filename was
     ima-return-proper-error-value-on-failure-of-dentry_open.patch

This patch was dropped because it was nacked

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: ima: return proper error value on failure of dentry_open()
From: vibi sreenivasan <vibi_sreenivasan@cms.com>

dentry_open can return error value on error.  Check that value before
calling fput & return proper error value

Signed-off-by: vibi sreenivasan <vibi_sreenivasan@cms.com>
Cc: Mimi Zohar <zohar@us.ibm.com>
Cc: Serge Hallyn <serue@us.ibm.com>
Cc: Reiner Sailer <sailer@watson.ibm.com>
Cc: James Morris <jmorris@namei.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 security/integrity/ima/ima_main.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN security/integrity/ima/ima_main.c~ima-return-proper-error-value-on-failure-of-dentry_open security/integrity/ima/ima_main.c
--- a/security/integrity/ima/ima_main.c~ima-return-proper-error-value-on-failure-of-dentry_open
+++ a/security/integrity/ima/ima_main.c
@@ -198,10 +198,10 @@ int ima_path_check(struct path *path, in
 	}
 out:
 	mutex_unlock(&iint->mutex);
-	if (file)
+	if (IS_ERR(file))
 		fput(file);
 	kref_put(&iint->refcount, iint_free);
-	return 0;
+	return rc;
 }
 EXPORT_SYMBOL_GPL(ima_path_check);
 
_

Patches currently in -mm which might be from vibi_sreenivasan@cms.com are

ima-return-proper-error-value-on-failure-of-dentry_open.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-02  5:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-02  5:21 [nacked] ima-return-proper-error-value-on-failure-of-dentry_open.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.