All of lore.kernel.org
 help / color / mirror / Atom feed
* + jffs2-jffs2_start_garbage_collect_thread-return-value-cleanup.patch added to -mm tree
@ 2009-06-02 22:11 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2009-06-02 22:11 UTC (permalink / raw)
  To: mm-commits; +Cc: gerard.lledo, dwmw2


The patch titled
     jffs2: jffs2_start_garbage_collect_thread() return value cleanup
has been added to the -mm tree.  Its filename is
     jffs2-jffs2_start_garbage_collect_thread-return-value-cleanup.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: jffs2: jffs2_start_garbage_collect_thread() return value cleanup
From: Gerard Lledo <gerard.lledo@gmail.com>

There is no user of this return value in the kernel.  Change it to return void
instead.

Signed-off-by: Gerard Lledo <gerard.lledo@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/jffs2/background.c |    7 +------
 fs/jffs2/os-linux.h   |    2 +-
 2 files changed, 2 insertions(+), 7 deletions(-)

diff -puN fs/jffs2/background.c~jffs2-jffs2_start_garbage_collect_thread-return-value-cleanup fs/jffs2/background.c
--- a/fs/jffs2/background.c~jffs2-jffs2_start_garbage_collect_thread-return-value-cleanup
+++ a/fs/jffs2/background.c
@@ -30,10 +30,9 @@ void jffs2_garbage_collect_trigger(struc
 }
 
 /* This must only ever be called when no GC thread is currently running */
-int jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)
+void jffs2_start_garbage_collect_thread(struct jffs2_sb_info *c)
 {
 	struct task_struct *tsk;
-	int ret = 0;
 
 	BUG_ON(c->gc_task);
 
@@ -44,15 +43,11 @@ int jffs2_start_garbage_collect_thread(s
 	if (IS_ERR(tsk)) {
 		printk(KERN_WARNING "fork failed for JFFS2 garbage collect thread: %ld\n", -PTR_ERR(tsk));
 		complete(&c->gc_thread_exit);
-		ret = PTR_ERR(tsk);
 	} else {
 		/* Wait for it... */
 		D1(printk(KERN_DEBUG "JFFS2: Garbage collect thread is pid %d\n", tsk->pid));
 		wait_for_completion(&c->gc_thread_start);
-		ret = tsk->pid;
 	}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-02 22:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-02 22:11 + jffs2-jffs2_start_garbage_collect_thread-return-value-cleanup.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.